From: Sander Vanheule <sander@svanheule.net>
To: Jonas Jelonek <jelonek.jonas@gmail.com>,
Oleksij Rempel <o.rempel@pengutronix.de>,
Kory Maincent <kory.maincent@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Daniel Golle" <daniel@makrotopia.org>,
"Bjørn Mork" <bjorn@mork.no>,
"Conor Dooley" <conor.dooley@microchip.com>
Subject: Re: [PATCH net-next v8 1/4] dt-bindings: net: pse-pd: add bindings for Realtek PSE MCU
Date: Wed, 22 Jul 2026 19:49:56 +0200 [thread overview]
Message-ID: <b3456b41152613ed45bcfde92aff89d0c33fa243.camel@svanheule.net> (raw)
In-Reply-To: <20260715075530.2491534-2-jelonek.jonas@gmail.com>
Hi,
On Wed, 2026-07-15 at 07:55 +0000, Jonas Jelonek wrote:
> Add a binding for the microcontroller (MCU) that fronts the PSE silicon
> on a range of managed Realtek-based switches. The host talks only to the
> MCU, over I2C/SMBus or UART, using a fixed message-based protocol; the
> PSE chips behind it never appear on the bus.
>
> The device is the MCU together with its Realtek firmware: the firmware
> and its host protocol are what the binding describes, not the
> general-purpose microcontroller they run on. The PSE silicon behind the
> MCU (Realtek or Broadcom) is reported by the MCU and detected at runtime,
> so it is not described here - hence the 'realtek' vendor prefix.
>
> Two protocol generations exist, both Realtek's, selected by the
> compatible: gen1 on older boards (fronting Broadcom PSE silicon) and gen2,
> the altered protocol used with Realtek's own PSE silicon. On an I2C
> attachment the framing the MCU firmware expects is part of the compatible
> as well - '-smbus' or raw '-i2c'; a UART attachment carries no framing
> suffix, as the transport is given by the parent serial node.
>
> Each board additionally carries a device-specific compatible that falls
> back to one of the protocol compatibles above. Drivers bind on the
> protocol compatible; the device-specific string identifies the board and
> reserves a place for a future per-board quirk without having to retrofit
> device trees already in the field.
>
> Signed-off-by: Jonas Jelonek <jelonek.jonas@gmail.com>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
[...]
> + power-supply:
> + description: Regulator supplying the PoE power rail.
As I reported to Jonas earlier [1], I used this property to define a power
supply for the 54V rail. While everything was working nicely, I still got this
warning for the missing vpwr-supply property on the PSE-PI nodes:
regulator regulator.2: supply vpwr not found, using dummy regulator
Of course I don't like seeing warnings when everything is seemingly working
fine, but I was also wondering if this duplicated way of providing the PoE power
rail is a good way to go forward and if the generic pse-pi@n/vpwr-supply
shouldn't just be used instead. The latter is admittedly more verbose, with a
property on every node, but going forward offers a few advantages IMHO:
* Being able to reserve "power-supply" on the main node for the MCU's actual
3.3V regulator (not needed anywhere at the moment AFAIK)
* Being able to take advantage of the generic pse-pi framework evolving to take
into account more properties of the parent regulator, such as requesting more
power, or ensuring the parent supply is not overdrawn by the combined PSE-PI
outputs.
[1] https://github.com/openwrt/openwrt/pull/23222#issuecomment-5032841546
Best,
Sander
next prev parent reply other threads:[~2026-07-22 17:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 7:55 [PATCH net-next v8 0/4] net: pse-pd: add Realtek PSE MCU support Jonas Jelonek
2026-07-15 7:55 ` [PATCH net-next v8 1/4] dt-bindings: net: pse-pd: add bindings for Realtek PSE MCU Jonas Jelonek
2026-07-17 9:39 ` Kory Maincent
2026-07-22 17:49 ` Sander Vanheule [this message]
2026-07-22 19:49 ` Jonas Jelonek
2026-07-23 7:36 ` Oleksij Rempel
2026-07-23 9:45 ` Jonas Jelonek
2026-07-23 10:20 ` Oleksij Rempel
2026-07-24 7:18 ` Jonas Jelonek
2026-07-24 7:44 ` Oleksij Rempel
2026-07-15 7:55 ` [PATCH net-next v8 2/4] net: pse-pd: add Realtek PSE MCU core Jonas Jelonek
2026-07-17 9:41 ` Kory Maincent
2026-07-15 7:55 ` [PATCH net-next v8 3/4] net: pse-pd: realtek-pse-mcu: add I2C transport Jonas Jelonek
2026-07-17 9:45 ` Kory Maincent
2026-07-15 7:55 ` [PATCH net-next v8 4/4] net: pse-pd: realtek-pse-mcu: add UART transport Jonas Jelonek
2026-07-17 9:46 ` Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3456b41152613ed45bcfde92aff89d0c33fa243.camel@svanheule.net \
--to=sander@svanheule.net \
--cc=andrew+netdev@lunn.ch \
--cc=bjorn@mork.no \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jelonek.jonas@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox