Netdev List
 help / color / mirror / Atom feed
From: Bastian Germann <bage@debian.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Russell King <linux@armlinux.org.uk>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH net-next] net: mdio: handle broken-turn-around for non-PHY MDIO devices
Date: Fri, 20 Nov 2026 23:44:16 +0100	[thread overview]
Message-ID: <b41df4eb-855a-44eb-94a0-663945c11ac8@debian.org> (raw)
In-Reply-To: <bb2edd63-c727-4b91-869a-2b26c0d7521f@lunn.ch>

On 11/20/26 23:07, Andrew Lunn wrote:
> On Fri, Nov 20, 2026 at 10:40:55PM +0100, Bastian Germann wrote:
>> On 11/20/26 01:33, Andrew Lunn wrote:
>>> On Fri, Nov 20, 2026 at 12:13:19AM +0100, Bastian Germann wrote:
>>>> The "broken-turn-around" property is documented in mdio.yaml for any
>>>> MDIO device, but the MDIO core currently parses it only for PHY devices
>>>> in fwnode_mdiobus_phy_device_register(). Non-PHY devices, such as DSA
>>>> switches, are registered through of_mdiobus_register_device(), where the
>>>> property is ignored, so MDIO bus drivers that rely on phy_ignore_ta_mask
>>>> still treat the turn-around/read failure as an error.
>>>>
>>>> Parse the property when registering a non-PHY MDIO device and set the
>>>> corresponding bit in phy_ignore_ta_mask before registering the device.
>>> What switch is causing you problems?
>> It is with mv88e6085.
>>
>> I have just found that Nathan Rossi sent basically the same patch as
>> <20210217044443.1246392-1-nathan@nathanrossi.com>.
> [Goes and find the thread]
>
> Are you bit banging as well? Or do you have another MDIO bus
> controller?
>
> The point about the mv88e6085 using multiple addresses is valid. How
> do you have the mv88e6085 configured?

It is with the TI CPSW3G MDIO controller (ti,davinci_mdio, ti,cpsw-mdio).
As this is on a AM64x, errata i2329 applies and davinci_mdio runs with 
bitbanging.

The mv88e6085 (88E6341) is configured in multi-chip/indirect mode at 
  reg = <1>.
It does not use multiple addresses.


      reply	other threads:[~2026-11-20 22:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 23:13 [PATCH net-next] net: mdio: handle broken-turn-around for non-PHY MDIO devices Bastian Germann
2026-11-20  0:33 ` Andrew Lunn
2026-11-20 21:40   ` Bastian Germann
2026-11-20 22:07     ` Andrew Lunn
2026-11-20 22:44       ` Bastian Germann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b41df4eb-855a-44eb-94a0-663945c11ac8@debian.org \
    --to=bage@debian.org \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox