From: Andrew Lunn <andrew@lunn.ch>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: javen <javen_xu@realsil.com.cn>,
nic_swsd@realtek.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC Patch net-next v1 1/9] r8169: add some register definitions
Date: Mon, 27 Apr 2026 04:30:06 +0200 [thread overview]
Message-ID: <b468f0df-5bea-4d3e-920b-ef35113a8b58@lunn.ch> (raw)
In-Reply-To: <59c06e34-2782-438e-bfd7-a8d475f34f95@gmail.com>
> > +#define RXS_8125B_RSS_UDP_V4 BIT(27)
>
> This register naming is unfortunate. What stands 8125B for, and what V4?
> Does V4 stand for a global version of the Realtek RSS IP block?
> Then the 8125B would be redundant.
Maybe UDP carried inside an IPv4 package?
> > + RSS_CTRL_IPV4_SUPP = (1 << 1),
> > + RSS_CTRL_TCP_IPV6_SUPP = (1 << 2),
> > + RSS_CTRL_IPV6_SUPP = (1 << 3),
> > + RSS_CTRL_IPV6_EXT_SUPP = (1 << 4),
> > + RSS_CTRL_TCP_IPV6_EXT_SUPP = (1 << 5),
> > + RSS_CTRL_UDP_IPV4_SUPP = (1 << 11),
> > + RSS_CTRL_UDP_IPV6_SUPP = (1 << 12),
> > + RSS_CTRL_UDP_IPV6_EXT_SUPP = (1 << 13),
> > + RSS_INDIRECTION_TBL_8125_V2 = 0x4700,
> > + RSS_KEY_8125 = 0x4600,
> > + RxUDPT_v4 = (1 << 19),
> > + RxTCPT_v4 = (1 << 18),
> > + RxUDPF_v4 = (1 << 16), /* UDP/IP checksum failed */
> > + RxTCPF_v4 = (1 << 15), /* TCP/IP checksum failed */
I agree that in general there needs to be better naming. These could
again be referring to IPv4? But the v2 references are clearly not an
IP version.
Andrew
next prev parent reply other threads:[~2026-04-27 2:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 2:19 [RFC Patch net-next v1 0/9] r8169: add RSS support for RTL8127 javen
2026-04-20 2:19 ` [RFC Patch net-next v1 1/9] r8169: add some register definitions javen
2026-04-25 22:32 ` Heiner Kallweit
2026-04-27 6:41 ` Javen
2026-04-27 14:22 ` Andrew Lunn
2026-04-26 18:08 ` Subbaraya Sundeep
2026-04-26 20:12 ` Heiner Kallweit
2026-04-27 2:30 ` Andrew Lunn [this message]
2026-04-27 6:42 ` Javen
2026-04-27 14:34 ` Andrew Lunn
2026-04-20 2:19 ` [RFC Patch net-next v1 2/9] r8169: add napi and irq support javen
2026-04-26 18:35 ` Subbaraya Sundeep
2026-04-20 2:19 ` [RFC Patch net-next v1 3/9] r8169: add support for multi tx queues javen
2026-04-26 19:48 ` Heiner Kallweit
2026-04-20 2:19 ` [RFC Patch net-next v1 4/9] r8169: add support for multi rx queues javen
2026-04-25 22:23 ` Heiner Kallweit
2026-04-20 2:19 ` [RFC Patch net-next v1 5/9] r8169: add support for msix javen
2026-04-25 22:14 ` Heiner Kallweit
2026-04-27 6:40 ` Javen
2026-04-20 2:19 ` [RFC Patch net-next v1 6/9] r8169: enable msix for RTL8127 javen
2026-04-20 2:19 ` [RFC Patch net-next v1 7/9] r8169: add support and enable rss javen
2026-04-20 2:19 ` [RFC Patch net-next v1 8/9] r8169: move struct ethtool_ops javen
2026-04-20 14:33 ` Andrew Lunn
2026-04-20 2:19 ` [RFC Patch net-next v1 9/9] r8169: add support for ethtool javen
2026-04-20 13:10 ` Andrew Lunn
2026-04-22 7:47 ` Javen
2026-04-26 18:05 ` Subbaraya Sundeep
2026-04-28 6:37 ` Javen
2026-04-20 11:06 ` [RFC Patch net-next v1 0/9] r8169: add RSS support for RTL8127 FUKAUMI Naoki
2026-04-25 22:49 ` Heiner Kallweit
2026-04-27 6:55 ` Javen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b468f0df-5bea-4d3e-920b-ef35113a8b58@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=javen_xu@realsil.com.cn \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox