* [PATCH] net: dsa: vitesse-vsc73xx: Convert to plain comments to avoid kerneldoc warnings
@ 2020-07-05 21:05 Andrew Lunn
2020-07-05 21:08 ` Florian Fainelli
2020-07-05 22:49 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Lunn @ 2020-07-05 21:05 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Florian Fainelli, Andrew Lunn
The comments before struct vsc73xx_platform and struct vsc73xx_spi use
kerneldoc format, but then fail to document the members of these
structures. All the structure members are self evident, and the driver
has not other kerneldoc comments, so change these to plain comments to
avoid warnings.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
drivers/net/dsa/vitesse-vsc73xx-platform.c | 2 +-
drivers/net/dsa/vitesse-vsc73xx-spi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dsa/vitesse-vsc73xx-platform.c b/drivers/net/dsa/vitesse-vsc73xx-platform.c
index 5e54a5726aa4..2a57f337b2a2 100644
--- a/drivers/net/dsa/vitesse-vsc73xx-platform.c
+++ b/drivers/net/dsa/vitesse-vsc73xx-platform.c
@@ -28,7 +28,7 @@
#define VSC73XX_CMD_PLATFORM_SUBBLOCK_MASK 0xf
#define VSC73XX_CMD_PLATFORM_REGISTER_SHIFT 2
-/**
+/*
* struct vsc73xx_platform - VSC73xx Platform state container
*/
struct vsc73xx_platform {
diff --git a/drivers/net/dsa/vitesse-vsc73xx-spi.c b/drivers/net/dsa/vitesse-vsc73xx-spi.c
index e73c8fcddc9f..81eca4a5781d 100644
--- a/drivers/net/dsa/vitesse-vsc73xx-spi.c
+++ b/drivers/net/dsa/vitesse-vsc73xx-spi.c
@@ -26,7 +26,7 @@
#define VSC73XX_CMD_SPI_BLOCK_MASK 0x7
#define VSC73XX_CMD_SPI_SUBBLOCK_MASK 0xf
-/**
+/*
* struct vsc73xx_spi - VSC73xx SPI state container
*/
struct vsc73xx_spi {
--
2.27.0.rc2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: dsa: vitesse-vsc73xx: Convert to plain comments to avoid kerneldoc warnings
2020-07-05 21:05 [PATCH] net: dsa: vitesse-vsc73xx: Convert to plain comments to avoid kerneldoc warnings Andrew Lunn
@ 2020-07-05 21:08 ` Florian Fainelli
2020-07-05 22:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2020-07-05 21:08 UTC (permalink / raw)
To: Andrew Lunn, David Miller; +Cc: netdev
On 7/5/2020 2:05 PM, Andrew Lunn wrote:
> The comments before struct vsc73xx_platform and struct vsc73xx_spi use
> kerneldoc format, but then fail to document the members of these
> structures. All the structure members are self evident, and the driver
> has not other kerneldoc comments, so change these to plain comments to
> avoid warnings.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: dsa: vitesse-vsc73xx: Convert to plain comments to avoid kerneldoc warnings
2020-07-05 21:05 [PATCH] net: dsa: vitesse-vsc73xx: Convert to plain comments to avoid kerneldoc warnings Andrew Lunn
2020-07-05 21:08 ` Florian Fainelli
@ 2020-07-05 22:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2020-07-05 22:49 UTC (permalink / raw)
To: andrew; +Cc: netdev, f.fainelli
From: Andrew Lunn <andrew@lunn.ch>
Date: Sun, 5 Jul 2020 23:05:08 +0200
> The comments before struct vsc73xx_platform and struct vsc73xx_spi use
> kerneldoc format, but then fail to document the members of these
> structures. All the structure members are self evident, and the driver
> has not other kerneldoc comments, so change these to plain comments to
> avoid warnings.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Applied to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-05 22:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-07-05 21:05 [PATCH] net: dsa: vitesse-vsc73xx: Convert to plain comments to avoid kerneldoc warnings Andrew Lunn
2020-07-05 21:08 ` Florian Fainelli
2020-07-05 22:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox