From: Gal Pressman <gal@nvidia.com>
To: Marc Harvey <marcharvey@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org,
Kuniyuki Iwashima <kuniyu@google.com>
Subject: Re: [PATCH net-next] net/mlx5: Add MLX5_VXLAN config option
Date: Thu, 14 May 2026 08:39:35 +0300 [thread overview]
Message-ID: <b635e3ec-9c24-4347-9495-c421b7d69243@nvidia.com> (raw)
In-Reply-To: <CANkEMgmhh40uE8asRO3WJpAtDZWDcSjJNVCzh54TgwcMUonhdA@mail.gmail.com>
On 13/05/2026 19:20, Marc Harvey wrote:
> On Tue, May 5, 2026 at 1:21 AM Gal Pressman <gal@nvidia.com> wrote:
>>
>> Hi Marc,
>>
>> On 05/05/2026 4:10, Jakub Kicinski wrote:
>>>
>>> Sorry, I don't know mlx5 very well. Sounds like you have to talk
>>> to nVidia or/and run some experiments. The current patch is a no-go.
>>>
>>
>> The hardware offloads 4789 by default, hence the
>> UDP_TUNNEL_NIC_INFO_STATIC_IANA_VXLAN, you cannot simply remove it.
>>
>> Have you tried disabling tx-udp_tnl-segmentation through ethtool?
>
> Thanks for the responses.
>
> Gal, by "the hardware offloads 4789 by default," does that mean the
> hardware offloads 4789 even without an explicit command from the
> driver? I ask because mlx5 does send a command to offload 4789, but
> perhaps this command is redundant and only for bookkeeping purposes.
Yes, we add the port so features_check flow would see this port is
offloaded.
>
> I haven't tried changing the offload related ethtool parameters, and I
> will, but I suspect it won't help in this specific case since the
> perceived regression involved non-tunneled traffic.
What is the purpose of this patch then?
>
> If the hardware indeed offloads 4789 autonomously, then the perceived
> regression we saw might not have been real or related to enabling
> vxlan.
Can you elaborate more on the regression?
What is the issue? When did is start happening?
Maybe you're experiencing this?
https://lore.kernel.org/all/6c3fb15e-711d-4b8d-b152-e03d9b05293f@linux.dev/
prev parent reply other threads:[~2026-05-14 5:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 22:44 [PATCH net-next] net/mlx5: Add MLX5_VXLAN config option Marc Harvey
2026-04-29 1:46 ` Jakub Kicinski
2026-04-30 0:46 ` Marc Harvey
2026-04-30 2:01 ` Jakub Kicinski
2026-05-04 22:44 ` Marc Harvey
2026-05-05 1:10 ` Jakub Kicinski
2026-05-05 6:21 ` Gal Pressman
2026-05-13 16:20 ` Marc Harvey
2026-05-14 5:39 ` Gal Pressman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b635e3ec-9c24-4347-9495-c421b7d69243@nvidia.com \
--to=gal@nvidia.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=marcharvey@google.com \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox