From: Florian Fainelli <f.fainelli@gmail.com>
To: Tobias Waldekranz <tobias@waldekranz.com>,
davem@davemloft.net, kuba@kernel.org
Cc: andrew@lunn.ch, vivien.didelot@gmail.com, olteanv@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers
Date: Tue, 10 Nov 2020 19:41:11 -0800 [thread overview]
Message-ID: <b953f38d-47e3-ac3d-39e1-84e9df807803@gmail.com> (raw)
In-Reply-To: <20201110091325.21582-1-tobias@waldekranz.com>
On 11/10/2020 1:13 AM, Tobias Waldekranz wrote:
> Ethertype DSA encodes exactly the same information in the DSA tag as
> the non-ethertype variety. So refactor out the common parts and reuse
> them for both protocols.
>
> This is ensures tag parsing and generation as always consistent across
> all mv88e6xxx chips.
s/as/is/?
This looks good to me! This made me remember that we do not really
interface with devlink traps today in DSA, but we may be able to.
--
Florian
next prev parent reply other threads:[~2020-11-11 3:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 9:13 [PATCH] net: dsa: tag_dsa: Unify regular and ethertype DSA taggers Tobias Waldekranz
2020-11-10 12:59 ` Vladimir Oltean
2020-11-10 16:57 ` Tobias Waldekranz
2020-11-10 13:49 ` Andrew Lunn
2020-11-11 0:24 ` Jakub Kicinski
2020-11-11 3:41 ` Florian Fainelli [this message]
2020-11-11 13:14 ` Tobias Waldekranz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b953f38d-47e3-ac3d-39e1-84e9df807803@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox