From: YueHaibing <yuehaibing@huawei.com>
To: <zbr@ioremap.net>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] connector: hide unused procfs helpers
Date: Fri, 13 Jul 2018 17:31:21 +0800 [thread overview]
Message-ID: <b9d2c823-56c3-b861-b56f-1ea83491e26a@huawei.com> (raw)
In-Reply-To: <20180713071141.15996-1-yuehaibing@huawei.com>
pls ignore this,my bad.
On 2018/7/13 15:11, YueHaibing wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
>
> drivers/connector/connector.c:242:12: warning: ‘cn_proc_show’ defined but not used [-Wunused-function]
> static int cn_proc_show(struct seq_file *m, void *v)
> ^
> fix this by adding #ifdef around it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/connector/connector.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c
> index e718b8c..e2636d4 100644
> --- a/drivers/connector/connector.c
> +++ b/drivers/connector/connector.c
> @@ -239,6 +239,7 @@ void cn_del_callback(struct cb_id *id)
> }
> EXPORT_SYMBOL_GPL(cn_del_callback);
>
> +#ifdef CONFIG_PROC_FS
> static int cn_proc_show(struct seq_file *m, void *v)
> {
> struct cn_queue_dev *dev = cdev.cbdev;
> @@ -259,6 +260,7 @@ static int cn_proc_show(struct seq_file *m, void *v)
>
> return 0;
> }
> +#endif
>
> static struct cn_dev cdev = {
> .input = cn_rx_skb,
>
prev parent reply other threads:[~2018-07-13 9:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 7:11 [PATCH] connector: hide unused procfs helpers YueHaibing
2018-07-13 9:31 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9d2c823-56c3-b861-b56f-1ea83491e26a@huawei.com \
--to=yuehaibing@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox