From: Paolo Abeni <pabeni@redhat.com>
To: netdev-bot+sashiko@kernel.org, kurt@linutronix.de
Cc: maxime.chevallier@bootlin.com, andrew+netdev@lunn.ch,
davem@davemloft.net, kuba@kernel.org, edumazet@kernel.org,
mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
john.fastabend@gmail.com, sdf@fomichev.me,
yoong.siang.song@intel.com, faizal.abdul.rahim@intel.com,
boon.leong.ong@intel.com, bigeasy@linutronix.de,
maciej.fijalkowski@intel.com, nb@tipi-net.de,
netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org
Subject: Re: [PATCH net-next v4 2/2] net: stmmac: Stop Tx queue when (en|dis)abling XSK pools
Date: Thu, 29 Oct 2026 11:14:01 +0100 [thread overview]
Message-ID: <bdc71cf3-5b16-4dbf-ac33-8f35b1a97d9f@redhat.com> (raw)
In-Reply-To: <179299947058.3134.16617492920924670801@kernel.org>
On 10/26/26 08:24, netdev-bot+sashiko@kernel.org wrote:
> - [High] stmmac_xdp_enable_pool() (stmmac_xdp.c:59) and
> stmmac_xdp_disable_pool() (stmmac_xdp.c:102) now call…
> - [Medium] The patch only works if __QUEUE_STATE_DRV_XOFF stays set from
> stmmac_xdp_stop_tx_queue() until the ring is rebuilt.
> - [Medium] In stmmac_xdp_xmit_xdpf(), first_entry and entry are read from
> tx_q->cur_tx when the locals are declared (stmmac_main.c:5263-5264).
I understand that the comments raised on patch 1/2 are sort of pre-existing,
as the reported races can be reached by __stmmac_release(), but the above
ones look legit and unaddressed/unanswered.
You can target `net` with the next revision, and please reply also to
already discussed comments, even with just a pointer to the previous
discussion.
/P
prev parent reply other threads:[~2026-10-29 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 7:01 [PATCH net-next v4 0/2] net: stmmac: Fix XSK crashes on stm32mp2 Kurt Kanzenbach
2026-10-22 7:01 ` [PATCH net-next v4 1/2] net: stmmac: Disable NAPI before stopping Tx queues in stmmac_xdp_release() Kurt Kanzenbach
2026-10-26 7:24 ` netdev-bot+sashiko
2026-10-22 7:01 ` [PATCH net-next v4 2/2] net: stmmac: Stop Tx queue when (en|dis)abling XSK pools Kurt Kanzenbach
2026-10-26 7:24 ` netdev-bot+sashiko
2026-10-29 10:14 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bdc71cf3-5b16-4dbf-ac33-8f35b1a97d9f@redhat.com \
--to=pabeni@redhat.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=boon.leong.ong@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=faizal.abdul.rahim@intel.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maciej.fijalkowski@intel.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nb@tipi-net.de \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@fomichev.me \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox