From: YueHaibing <yuehaibing@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <dmitry.tarnyagin@lockless.no>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] net: caif: fix return type of ndo_start_xmit function
Date: Sun, 30 Sep 2018 09:52:55 +0800 [thread overview]
Message-ID: <be1fc45d-3dca-3c41-a68a-e8d614bc4e6f@huawei.com> (raw)
In-Reply-To: <20180929.113802.1016843680571572182.davem@davemloft.net>
On 2018/9/30 2:38, David Miller wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> Date: Wed, 26 Sep 2018 17:27:05 +0800
>
>> @@ -1014,7 +1014,7 @@ static int cfhsi_xmit(struct sk_buff *skb, struct net_device *dev)
>> int prio;
>>
>> if (!dev)
>> - return -EINVAL;
>> + return NETDEV_TX_BUSY;
>>
>> cfhsi = netdev_priv(dev);
>>
>
> Even though the return type of ndo_start_xmit is netdev_tx_t, negative error codes are
> still allowed I believe.
I missed this and do the wrong thing.
>
> Look, reviewing these are pretty stressful for me, because you aren't documenting your
> changes and in many cases the transformations look incorrect.
>
I'm really sorry for this.
> I'm tossing the rest of your changes in this area for now, sorry.
>
> Please double check your work and resubmit this at some time in the not-too-near
> future.
>
> Thank you.
>
> .
>
prev parent reply other threads:[~2018-09-30 1:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 9:27 [PATCH net-next] net: caif: fix return type of ndo_start_xmit function YueHaibing
2018-09-29 18:38 ` David Miller
2018-09-30 1:52 ` YueHaibing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be1fc45d-3dca-3c41-a68a-e8d614bc4e6f@huawei.com \
--to=yuehaibing@huawei.com \
--cc=davem@davemloft.net \
--cc=dmitry.tarnyagin@lockless.no \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox