From: Qingfang Deng <qingfang.deng@linux.dev>
To: netdev-bot+sinfo@kernel.org
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Breno Leitao <leitao@debian.org>, Kees Cook <kees@kernel.org>,
Taegu Ha <hataegu0826@gmail.com>,
Tom Parkin <tparkin@katalix.com>,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
James Chapman <jchapman@katalix.com>,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH net] ppp: linearize bridged packets when required
Date: Wed, 21 Oct 2026 11:07:27 +0800 [thread overview]
Message-ID: <c0f348bf-0e13-4cb1-8014-cd9b7787bfe6@linux.dev> (raw)
In-Reply-To: <179255036282.3290.8488375760281728576@kernel.org>
On 2026/10/21 10:39, netdev-bot+sinfo@kernel.org wrote:
> Hi!
>
> This is an automated message. This series looks like a fix, but its
> commit messages seem to be missing some information:
>
> - Whether the issue was actually triggered, or is only theoretical
> (e.g. found by code inspection). If it was triggered please include
> the symptoms, like the stack trace or error messages.
This is reproduced in a VM, with a TAP interface bridged to a PTY. When
IFF_NAPI_FRAGS is set, a non-linear skb is passed to PPPoE and then to
ppp_async_send() without linearization. The packet sent to the PTY then
contains garbage data.
>
> Please do not repost the series just to address the above. Instead,
> reply to this email with the missing information, so that reviewers
> can take it into account. If the series needs another revision for
> other reasons, please include the information in the commit messages
> then.
>
> The evaluation is done by an LLM so it may be wrong, if you think
> that is the case please reply and explain.
next prev parent reply other threads:[~2026-10-21 3:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 2:36 [PATCH net] ppp: linearize bridged packets when required Qingfang Deng
2026-10-21 2:39 ` netdev-bot+sinfo
2026-10-21 3:07 ` Qingfang Deng [this message]
2026-10-21 9:24 ` Eric Dumazet
2026-10-21 10:27 ` Qingfang Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0f348bf-0e13-4cb1-8014-cd9b7787bfe6@linux.dev \
--to=qingfang.deng@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hataegu0826@gmail.com \
--cc=jchapman@katalix.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=netdev-bot+sinfo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashiko-bot@kernel.org \
--cc=tparkin@katalix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox