From: David Ahern <dsahern@kernel.org>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com, wenxu <wenxu@ucloud.cn>
Subject: Re: [PATCH net] inet: shrink struct flowi_common
Date: Thu, 26 Oct 2023 11:17:25 -0600 [thread overview]
Message-ID: <c3921640-5a77-4ddc-a774-9fb40a110db3@kernel.org> (raw)
In-Reply-To: <20231025141037.3448203-1-edumazet@google.com>
On 10/25/23 8:10 AM, Eric Dumazet wrote:
> I am looking at syzbot reports triggering kernel stack overflows
> involving a cascade of ipvlan devices.
>
> We can save 8 bytes in struct flowi_common.
>
> This patch alone will not fix the issue, but is a start.
>
> Fixes: 24ba14406c5c ("route: Add multipath_hash in flowi_common to make user-define hash")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: wenxu <wenxu@ucloud.cn>
> ---
> include/net/flow.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2023-10-26 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-25 14:10 [PATCH net] inet: shrink struct flowi_common Eric Dumazet
2023-10-26 17:17 ` David Ahern [this message]
2023-11-02 9:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3921640-5a77-4ddc-a774-9fb40a110db3@kernel.org \
--to=dsahern@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wenxu@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox