* [PATCH net] inet: shrink struct flowi_common
@ 2023-10-25 14:10 Eric Dumazet
2023-10-26 17:17 ` David Ahern
2023-11-02 9:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Eric Dumazet @ 2023-10-25 14:10 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: netdev, eric.dumazet, Eric Dumazet, wenxu
I am looking at syzbot reports triggering kernel stack overflows
involving a cascade of ipvlan devices.
We can save 8 bytes in struct flowi_common.
This patch alone will not fix the issue, but is a start.
Fixes: 24ba14406c5c ("route: Add multipath_hash in flowi_common to make user-define hash")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: wenxu <wenxu@ucloud.cn>
---
include/net/flow.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/flow.h b/include/net/flow.h
index 7f0adda3bf2fed28c53352d9021574b5eade2738..335bbc52171c10eb4b4b7e03a18eb8147902c6ac 100644
--- a/include/net/flow.h
+++ b/include/net/flow.h
@@ -40,8 +40,8 @@ struct flowi_common {
#define FLOWI_FLAG_KNOWN_NH 0x02
__u32 flowic_secid;
kuid_t flowic_uid;
- struct flowi_tunnel flowic_tun_key;
__u32 flowic_multipath_hash;
+ struct flowi_tunnel flowic_tun_key;
};
union flowi_uli {
--
2.42.0.758.gaed0368e0e-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] inet: shrink struct flowi_common
2023-10-25 14:10 [PATCH net] inet: shrink struct flowi_common Eric Dumazet
@ 2023-10-26 17:17 ` David Ahern
2023-11-02 9:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: David Ahern @ 2023-10-26 17:17 UTC (permalink / raw)
To: Eric Dumazet, David S . Miller, Jakub Kicinski, Paolo Abeni
Cc: netdev, eric.dumazet, wenxu
On 10/25/23 8:10 AM, Eric Dumazet wrote:
> I am looking at syzbot reports triggering kernel stack overflows
> involving a cascade of ipvlan devices.
>
> We can save 8 bytes in struct flowi_common.
>
> This patch alone will not fix the issue, but is a start.
>
> Fixes: 24ba14406c5c ("route: Add multipath_hash in flowi_common to make user-define hash")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: wenxu <wenxu@ucloud.cn>
> ---
> include/net/flow.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] inet: shrink struct flowi_common
2023-10-25 14:10 [PATCH net] inet: shrink struct flowi_common Eric Dumazet
2023-10-26 17:17 ` David Ahern
@ 2023-11-02 9:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-11-02 9:40 UTC (permalink / raw)
To: Eric Dumazet; +Cc: davem, kuba, pabeni, netdev, eric.dumazet, wenxu
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 25 Oct 2023 14:10:37 +0000 you wrote:
> I am looking at syzbot reports triggering kernel stack overflows
> involving a cascade of ipvlan devices.
>
> We can save 8 bytes in struct flowi_common.
>
> This patch alone will not fix the issue, but is a start.
>
> [...]
Here is the summary with links:
- [net] inet: shrink struct flowi_common
https://git.kernel.org/netdev/net/c/1726483b79a7
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-02 9:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-25 14:10 [PATCH net] inet: shrink struct flowi_common Eric Dumazet
2023-10-26 17:17 ` David Ahern
2023-11-02 9:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox