From: Paolo Abeni <pabeni@redhat.com>
To: netdev-bot+sashiko@kernel.org, edumazet@kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, willemb@google.com,
horms@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org,
david.laight.linux@gmail.com, willemdebruijn.kernel@gmail.com
Subject: Re: [PATCH v2 net] udp: restore hlist_nulls for primary and secondary hash tables
Date: Tue, 3 Nov 2026 09:40:20 +0100 [thread overview]
Message-ID: <c573bbcc-e0d8-4f43-b14b-09c676a6fe38@redhat.com> (raw)
In-Reply-To: <179362213820.3131.12108035098960840444@kernel.org>
On 11/2/26 13:22, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
>
> Critical: 0 · High: 1 · Medium: 0 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] The hlist_nulls restart does not work when an IPv6 SO_REUSEPORT
> socket is tail-inserted back into the bucket it was just removed from.
This look real to me. On the flip side the most straight forward fix - avoid
tail insertion in udp_lib_get_port() would re-introduce the issue addressed
by commit d894ba18d4e449b3a7f6eb491f16c9e02933736e. But rehash already avoids
tail insertion...
/P
next prev parent reply other threads:[~2026-11-03 8:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-30 12:20 [PATCH v2 net] udp: restore hlist_nulls for primary and secondary hash tables Eric Dumazet
2026-10-30 12:24 ` netdev-bot+sinfo
2026-10-30 16:21 ` Alexei Starovoitov
2026-11-02 12:22 ` netdev-bot+sashiko
2026-11-03 8:40 ` Paolo Abeni [this message]
2026-11-03 13:34 ` Eric Dumazet
2026-11-03 22:01 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c573bbcc-e0d8-4f43-b14b-09c676a6fe38@redhat.com \
--to=pabeni@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=david.laight.linux@gmail.com \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox