From: Paul Blakey <paulb@mellanox.com>
To: David Miller <davem@davemloft.net>
Cc: Jiri Pirko <jiri@mellanox.com>, Roi Dayan <roid@mellanox.com>,
Yossi Kuperman <yossiku@mellanox.com>,
Oz Shlomo <ozsh@mellanox.com>,
"marcelo.leitner@gmail.com" <marcelo.leitner@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"aconole@redhat.com" <aconole@redhat.com>,
"wangzhike@jd.com" <wangzhike@jd.com>,
Rony Efraim <ronye@mellanox.com>,
"nst-kernel@redhat.com" <nst-kernel@redhat.com>,
"john.hurley@netronome.com" <john.hurley@netronome.com>,
"simon.horman@netronome.com" <simon.horman@netronome.com>,
"jpettit@ovn.org" <jpettit@ovn.org>
Subject: Re: [PATCH net-next v2 1/4] net/sched: Introduce action ct
Date: Sun, 30 Jun 2019 08:43:58 +0000 [thread overview]
Message-ID: <c67b9fcb-e24d-00d3-13ab-d0f25916ceac@mellanox.com> (raw)
In-Reply-To: <20190627.125339.707372206595841703.davem@davemloft.net>
On 6/27/2019 10:53 PM, David Miller wrote:
> From: Paul Blakey <paulb@mellanox.com>
> Date: Thu, 20 Jun 2019 16:42:18 +0300
>
>> +struct tcf_ct_params {
> ...
>> + struct rcu_head rcu;
>> +
>> +};
> Please get ride of that empty line after the 'rcu' member.
>
>> + switch (skb->protocol) {
>> + case htons(ETH_P_IP):
>> + family = NFPROTO_IPV4;
>> + break;
>> + case htons(ETH_P_IPV6):
>> + family = NFPROTO_IPV6;
>> + break;
>> + default:
>> + break;
> Break statement is not indented properly.
>
>> +static __net_init int ct_init_net(struct net *net)
>> +{
>> + struct tc_ct_action_net *tn = net_generic(net, ct_net_id);
>> + unsigned int n_bits = FIELD_SIZEOF(struct tcf_ct_params, labels) * 8;
> Reverse christmas tree here please.
Sure thanks.
next prev parent reply other threads:[~2019-06-30 8:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 13:42 [PATCH net-next v2 0/4] net/sched: Introduce tc connection tracking Paul Blakey
2019-06-20 13:42 ` [PATCH net-next v2 1/4] net/sched: Introduce action ct Paul Blakey
2019-06-27 19:53 ` David Miller
2019-06-30 8:43 ` Paul Blakey [this message]
2019-06-20 13:42 ` [PATCH net-next v2 2/4] net/flow_dissector: add connection tracking dissection Paul Blakey
2019-06-20 13:42 ` [PATCH net-next v2 3/4] net/sched: cls_flower: Add matching on conntrack info Paul Blakey
2019-06-20 13:42 ` [PATCH net-next v2 4/4] tc-tests: Add tc action ct tests Paul Blakey
2019-06-24 17:59 ` [PATCH net-next v2 0/4] net/sched: Introduce tc connection tracking Cong Wang
2019-06-30 8:43 ` Paul Blakey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c67b9fcb-e24d-00d3-13ab-d0f25916ceac@mellanox.com \
--to=paulb@mellanox.com \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=jiri@mellanox.com \
--cc=john.hurley@netronome.com \
--cc=jpettit@ovn.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nst-kernel@redhat.com \
--cc=ozsh@mellanox.com \
--cc=roid@mellanox.com \
--cc=ronye@mellanox.com \
--cc=simon.horman@netronome.com \
--cc=wangzhike@jd.com \
--cc=yossiku@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox