From: David Miller <davem@davemloft.net>
To: paulb@mellanox.com
Cc: jiri@mellanox.com, roid@mellanox.com, yossiku@mellanox.com,
ozsh@mellanox.com, marcelo.leitner@gmail.com,
netdev@vger.kernel.org, aconole@redhat.com, wangzhike@jd.com,
ronye@mellanox.com, nst-kernel@redhat.com,
john.hurley@netronome.com, simon.horman@netronome.com,
jpettit@ovn.org
Subject: Re: [PATCH net-next v2 1/4] net/sched: Introduce action ct
Date: Thu, 27 Jun 2019 12:53:39 -0700 (PDT) [thread overview]
Message-ID: <20190627.125339.707372206595841703.davem@davemloft.net> (raw)
In-Reply-To: <1561038141-31370-2-git-send-email-paulb@mellanox.com>
From: Paul Blakey <paulb@mellanox.com>
Date: Thu, 20 Jun 2019 16:42:18 +0300
> +struct tcf_ct_params {
...
> + struct rcu_head rcu;
> +
> +};
Please get ride of that empty line after the 'rcu' member.
> + switch (skb->protocol) {
> + case htons(ETH_P_IP):
> + family = NFPROTO_IPV4;
> + break;
> + case htons(ETH_P_IPV6):
> + family = NFPROTO_IPV6;
> + break;
> + default:
> + break;
Break statement is not indented properly.
> +static __net_init int ct_init_net(struct net *net)
> +{
> + struct tc_ct_action_net *tn = net_generic(net, ct_net_id);
> + unsigned int n_bits = FIELD_SIZEOF(struct tcf_ct_params, labels) * 8;
Reverse christmas tree here please.
next prev parent reply other threads:[~2019-06-27 19:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 13:42 [PATCH net-next v2 0/4] net/sched: Introduce tc connection tracking Paul Blakey
2019-06-20 13:42 ` [PATCH net-next v2 1/4] net/sched: Introduce action ct Paul Blakey
2019-06-27 19:53 ` David Miller [this message]
2019-06-30 8:43 ` Paul Blakey
2019-06-20 13:42 ` [PATCH net-next v2 2/4] net/flow_dissector: add connection tracking dissection Paul Blakey
2019-06-20 13:42 ` [PATCH net-next v2 3/4] net/sched: cls_flower: Add matching on conntrack info Paul Blakey
2019-06-20 13:42 ` [PATCH net-next v2 4/4] tc-tests: Add tc action ct tests Paul Blakey
2019-06-24 17:59 ` [PATCH net-next v2 0/4] net/sched: Introduce tc connection tracking Cong Wang
2019-06-30 8:43 ` Paul Blakey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627.125339.707372206595841703.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aconole@redhat.com \
--cc=jiri@mellanox.com \
--cc=john.hurley@netronome.com \
--cc=jpettit@ovn.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nst-kernel@redhat.com \
--cc=ozsh@mellanox.com \
--cc=paulb@mellanox.com \
--cc=roid@mellanox.com \
--cc=ronye@mellanox.com \
--cc=simon.horman@netronome.com \
--cc=wangzhike@jd.com \
--cc=yossiku@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox