Netdev List
 help / color / mirror / Atom feed
From: Quentin Monnet <quentin.monnet@netronome.com>
To: Markus Heiser <markus.heiser@darmarit.de>,
	Daniel Borkmann <daniel@iogearbox.net>
Cc: Jonathan Corbet <corbet@lwn.net>,
	ast@kernel.org, netdev@vger.kernel.org,
	oss-drivers@netronome.com,
	Linux Doc Mailing List <linux-doc@vger.kernel.org>,
	linux-man@vger.kernel.org
Subject: Re: [RFC bpf-next] bpf: document eBPF helpers and add a script to generate man page
Date: Mon, 9 Apr 2018 14:33:02 +0100	[thread overview]
Message-ID: <c8715de7-674e-64e0-1e3b-4b4e884e80ad@netronome.com> (raw)
In-Reply-To: <550CD0C6-10B5-4C8C-9C1E-70AA61ABDC34@darmarit.de>

2018-04-09 12:52 UTC+0200 ~ Markus Heiser <markus.heiser@darmarit.de>
> 
>> Am 09.04.2018 um 12:08 schrieb Daniel Borkmann <daniel@iogearbox.net>:
> [...]
> 
>>> May I completely misunderstood you, so correct my if I'am wrong:
>>>
>>> - ./scripts/bpf_helpers_doc.py : produces reST markup from C-comments
>>> - ./scripts/kerne-doc          : produces reST markup from C-comments
>>>
>>> IMO: both are doing the same job, so why not using kernel-doc?
>>
>> They are not really doing the same job, in bpf_helpers_doc.py case you don't
>> want the whole header rendered, but just a fraction of it, that is, the
>> single big comment which describes all BPF helper functions that a BPF
>> program developer has available to use in user space - aka the entries in
>> the __BPF_FUNC_MAPPER() macro;
> 
> 
>> I also doubt the latter would actually qualify
>> in kdoc context as some sort of a function description.
> 
> latter .. ah, OK .. thanks for clarifying. 
> 
> -- Markus --

As Daniel explained, kernel-doc does not apply in this case, we do not
have the full function prototype for eBPF helpers in the header file.
But to be honest, I didn't even realise kernel-doc was available and
could do something close to what I was looking for, so thanks for your
feedback! :)

Quentin

  reply	other threads:[~2018-04-09 13:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-06 11:11 [RFC bpf-next] bpf: document eBPF helpers and add a script to generate man page Quentin Monnet
2018-04-09  3:48 ` Alexei Starovoitov
2018-04-09  9:01 ` Daniel Borkmann
     [not found]   ` <AB89F6E2-DE8A-4259-B361-BE96AD32E84E@darmarit.de>
2018-04-09  9:25     ` Daniel Borkmann
2018-04-09  9:35       ` Markus Heiser
2018-04-09 10:08         ` Daniel Borkmann
2018-04-09 10:52           ` Markus Heiser
2018-04-09 13:33             ` Quentin Monnet [this message]
2018-04-09  9:26   ` Markus Heiser
2018-04-09 13:25   ` Quentin Monnet
2018-04-10  1:47     ` Alexei Starovoitov
2018-04-10 10:21       ` Quentin Monnet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8715de7-674e-64e0-1e3b-4b4e884e80ad@netronome.com \
    --to=quentin.monnet@netronome.com \
    --cc=ast@kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel@iogearbox.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-man@vger.kernel.org \
    --cc=markus.heiser@darmarit.de \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox