From: Quentin Monnet <quentin.monnet@netronome.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
ast@kernel.org, netdev@vger.kernel.org,
oss-drivers@netronome.com, linux-doc@vger.kernel.org,
linux-man@vger.kernel.org
Subject: Re: [RFC bpf-next] bpf: document eBPF helpers and add a script to generate man page
Date: Tue, 10 Apr 2018 11:21:04 +0100 [thread overview]
Message-ID: <cf228f29-1d41-be4f-7b6b-b1c47ab9f4fa@netronome.com> (raw)
In-Reply-To: <20180410014751.mqwqdyujvybir6g5@ast-mbp.dhcp.thefacebook.com>
2018-04-09 18:47 UTC-0700 ~ Alexei Starovoitov
<alexei.starovoitov@gmail.com>
> On Mon, Apr 09, 2018 at 02:25:26PM +0100, Quentin Monnet wrote:
>>
>> Anyway, I am fine with keeping just signatures, descriptions and return
>> values for now. I will submit a new version with only those items.
>
> Thank you.
>
> Could you also split it into few patches?
> include/uapi/linux/bpf.h | 2237 ++++++++++++++++++++++++++++++++++++--------
> scripts/bpf_helpers_doc.py | 568 +++++++++++
> 2 files changed, 2429 insertions(+), 376 deletions(-)
>
> replying back and forth on a single patch of such size will be tedious
> for others to follow.
> May be document ~10 helpers at a time ? Total of ~7 patches and extra
> patch for .py ?
>
Sure, I'll do that. And I'll try to group helpers in a patch by author,
it should also help for reviewing the descriptions.
Quentin
prev parent reply other threads:[~2018-04-10 10:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-06 11:11 [RFC bpf-next] bpf: document eBPF helpers and add a script to generate man page Quentin Monnet
2018-04-09 3:48 ` Alexei Starovoitov
2018-04-09 9:01 ` Daniel Borkmann
[not found] ` <AB89F6E2-DE8A-4259-B361-BE96AD32E84E@darmarit.de>
2018-04-09 9:25 ` Daniel Borkmann
2018-04-09 9:35 ` Markus Heiser
2018-04-09 10:08 ` Daniel Borkmann
2018-04-09 10:52 ` Markus Heiser
2018-04-09 13:33 ` Quentin Monnet
2018-04-09 9:26 ` Markus Heiser
2018-04-09 13:25 ` Quentin Monnet
2018-04-10 1:47 ` Alexei Starovoitov
2018-04-10 10:21 ` Quentin Monnet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf228f29-1d41-be4f-7b6b-b1c47ab9f4fa@netronome.com \
--to=quentin.monnet@netronome.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox