From: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
To: <jonathan@ogc.us>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>
Subject: Re: [PATCH] RDSRDMA: Fix cleanup of rds_iw_mr_pool
Date: Thu, 29 Sep 2011 11:51:47 -0700 (PDT) [thread overview]
Message-ID: <c8acdbc4-7b18-4232-a636-e83dfbf310e4@default> (raw)
In the rds_iw_mr_pool struct the free_pinned field keeps track of
memory pinned by free MRs. While this field is incremented properly
upon allocation, it is never decremented upon unmapping. This would
cause the rds_rdma module to crash the kernel upon unloading, by
triggering the BUG_ON in the rds_iw_destroy_mr_pool function.
This change keeps track of the MRs that become unpinned, so that
free_pinned can be decremented appropriately.
Signed-off-by: Jonathan Lallinger <jonathan@ogc.us>
Signed-off-by: Steve Wise <swise@ogc.us>
---
Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
Venkat
next reply other threads:[~2011-09-29 18:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 18:51 Venkat Venkatsubra [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-09-29 17:58 [PATCH] RDSRDMA: Fix cleanup of rds_iw_mr_pool Jonathan Lallinger
2011-09-29 18:57 ` David Miller
2011-09-13 19:41 Jonathan Lallinger
2011-09-27 5:32 ` David Miller
2011-09-27 17:26 ` Jonathan Lallinger
2011-09-28 20:03 ` Steve Wise
2011-09-09 14:37 Venkat Venkatsubra
2011-09-09 19:01 ` Steve Wise
2011-09-09 19:05 ` David Miller
2011-09-08 18:09 Jonathan Lallinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8acdbc4-7b18-4232-a636-e83dfbf310e4@default \
--to=venkat.x.venkatsubra@oracle.com \
--cc=davem@davemloft.net \
--cc=jonathan@ogc.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox