Re: [PATCH ipsec-next] xfrm: check for xdo_dev_state_free

[Shannon Nelson <shannon.nelson@oracle.com>]

On 12/13/2017 10:20 PM, Steffen Klassert wrote:
> On Mon, Dec 11, 2017 at 12:57:22PM -0800, Shannon Nelson wrote:
>> The current XFRM code assumes that we've implemented the
>> xdo_dev_state_free() callback, even if it is meaningless to the driver.

<snip>

>> +		if (dev->features & NETIF_F_HW_ESP_TX_CSUM) {
>> +			netdev_err(dev, "NETIF_F_HW_ESP_TX_CSUM without NETIF_F_HW_ESP\n");
>> +			return NOTIFY_BAD;
>> +		} else {
>> +			return NOTIFY_DONE;
>> +		}
>> +	}
>> +
>> +	if (!(dev->xfrmdev_ops &&
>> +	      dev->xfrmdev_ops->xdo_dev_state_add &&
>> +	      dev->xfrmdev_ops->xdo_dev_state_delete)) {
>> +		netdev_err(dev, "add or delete function missing from xfrmdev_ops\n");
> 
> Please remove these error printings, this is not relevant for normal
> users.
> 

Okay.

After I posted this I realized this really should be two patches, so 
I'll split this up as well before resending.

sln