Netdev List
 help / color / mirror / Atom feed
From: Eric Joyner <eric.joyner@amd.com>
To: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	Leon Romanovsky <leon@kernel.org>
Cc: Brett Creeley <brett.creeley@amd.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Abhijit Gangurde <abhijit.gangurde@amd.com>,
	Allen Hubbe <allen.hubbe@amd.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	"Nikhil P . Rao" <nikhil.rao@amd.com>
Subject: Re: [PATCH net-next 4/4] RDMA/ionic: Add DCQCN parameter configuration via debugfs
Date: Thu, 20 Aug 2026 17:24:30 -0700	[thread overview]
Message-ID: <c940bf1d-11d0-4564-ab1e-e423b0c8ceae@amd.com> (raw)
In-Reply-To: <bb6f164e-5f95-48ab-a22c-5582dcef721d@amd.com>

On 7/28/2026 4:16 PM, Eric Joyner wrote:
> 
> Leon,
> 
> From this thread for Patch 3:
> https://lore.kernel.org/linux-rdma/20260514163540.GT15586@unreal/, I understand
> that it's too large and it's exposing too much information; I can shrink that
> down and remove the entries there.
> 
> But before I make changes and resubmit, is what this patch is doing okay? It
> adds DCQCN configuration parameters so that they can be written to in debugfs
> and propagated to the firmware? Would this be considered too much meddling with
> the firmware in debugfs, too? We want to have a driver-configured mode for DCQCN
> and possibly other congestion control profiles.
> 
> - Eric

Hi Leon,

Can you tell me what an acceptable approach would be in terms of the DCQCN
configuration? It didn't get mentioned as part of the debugfs discussion on the
other patch in this series, and I want to know if it's ok if I can modify the
debugfs implementation to have these DCQCN tuning knobs in there, but to drop
everything else from the rdma driver debugfs that looks offensive.

- Eric

  reply	other threads:[~2026-08-21  0:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06  4:19 [PATCH net-next 0/4] RDMA/net/ionic: Misc updates Eric Joyner
2026-05-06  4:19 ` [PATCH net-next 1/4] RDMA/ionic: Update copyright year to 2026 Eric Joyner
2026-05-06  4:19 ` [PATCH net-next 2/4] net/ionic: Add devlink parameter for RDMA Eric Joyner
2026-05-06  4:19 ` [PATCH net-next 3/4] RDMA/ionic: Add debugfs support Eric Joyner
2026-05-13  7:21   ` Leon Romanovsky
2026-05-14  0:23     ` Jakub Kicinski
2026-05-14  6:00       ` Leon Romanovsky
2026-05-14  7:04         ` Greg Kroah-Hartman
2026-05-14 16:35           ` Leon Romanovsky
2026-05-06  4:19 ` [PATCH net-next 4/4] RDMA/ionic: Add DCQCN parameter configuration via debugfs Eric Joyner
2026-07-28 23:16   ` Eric Joyner
2026-08-21  0:24     ` Eric Joyner [this message]
2026-05-06 22:59 ` [PATCH net-next 0/4] RDMA/net/ionic: Misc updates Jakub Kicinski
2026-05-14 14:33   ` Abhijit Gangurde
2026-05-14 16:40     ` Leon Romanovsky
2026-05-14 17:19       ` Creeley, Brett
2026-05-17 14:55         ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c940bf1d-11d0-4564-ab1e-e423b0c8ceae@amd.com \
    --to=eric.joyner@amd.com \
    --cc=abhijit.gangurde@amd.com \
    --cc=allen.hubbe@amd.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=brett.creeley@amd.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jgg@ziepe.ca \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikhil.rao@amd.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox