Re: [PATCH net-next 3/4] RDMA/ionic: Add debugfs support

[Leon Romanovsky <leon@kernel.org>]

On Tue, May 05, 2026 at 09:19:34PM -0700, Eric Joyner wrote:
> From: Allen Hubbe <allen.hubbe@amd.com>
> 
> Adds a per-RDMA device debugfs folder under the parent ionic ethernet
> device's folder for the LIF. Exports RDMA-specific debug information and
> various queue information.
> 
> Signed-off-by: Allen Hubbe <allen.hubbe@amd.com>
> Co-developed-by: Eric Joyner <eric.joyner@amd.com>
> Signed-off-by: Eric Joyner <eric.joyner@amd.com>
> ---
>  drivers/infiniband/hw/ionic/Makefile          |   2 +-
>  drivers/infiniband/hw/ionic/ionic_admin.c     |   4 +
>  .../infiniband/hw/ionic/ionic_controlpath.c   |  14 +
>  drivers/infiniband/hw/ionic/ionic_debugfs.c   | 750 ++++++++++++++++++
>  drivers/infiniband/hw/ionic/ionic_ibdev.c     |   3 +
>  drivers/infiniband/hw/ionic/ionic_ibdev.h     |  29 +
>  drivers/infiniband/hw/ionic/ionic_lif_cfg.c   |   3 +
>  drivers/infiniband/hw/ionic/ionic_lif_cfg.h   |   2 +
>  8 files changed, 806 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/infiniband/hw/ionic/ionic_debugfs.c

I'll comment on this patch only, but the same issues apply to the whole
series.

1. This series should target rdma-next, not net-next.
2. Jakub's feedback is valid and should be addressed.
3. The patch is too large and exposes too many details that should be
   gathered through the FW (fwctl).
4. It exposes a large number of fields from general RDMA structures,
   which suggests that this dump is placed in the wrong layer.

Thanks