Re: [PATCH net-next 4/4] RDMA/ionic: Add DCQCN parameter configuration via debugfs

[Leon Romanovsky <leon@kernel.org>]

On Thu, Aug 20, 2026 at 05:24:30PM -0700, Eric Joyner wrote:
> On 7/28/2026 4:16 PM, Eric Joyner wrote:
> > 
> > Leon,
> > 
> > From this thread for Patch 3:
> > https://lore.kernel.org/linux-rdma/20260514163540.GT15586@unreal/, I understand
> > that it's too large and it's exposing too much information; I can shrink that
> > down and remove the entries there.
> > 
> > But before I make changes and resubmit, is what this patch is doing okay? It
> > adds DCQCN configuration parameters so that they can be written to in debugfs
> > and propagated to the firmware? Would this be considered too much meddling with
> > the firmware in debugfs, too? We want to have a driver-configured mode for DCQCN
> > and possibly other congestion control profiles.
> > 
> > - Eric
> 
> Hi Leon,
> 
> Can you tell me what an acceptable approach would be in terms of the DCQCN
> configuration? It didn't get mentioned as part of the debugfs discussion on the
> other patch in this series, and I want to know if it's ok if I can modify the
> debugfs implementation to have these DCQCN tuning knobs in there, but to drop
> everything else from the rdma driver debugfs that looks offensive.

Yes, see the HNS driver. It added several debugfs knobs for configuring
DCQCN.

Thanks

> 
> - Eric