From: Saeed Mahameed <saeedm@mellanox.com>
To: Sagi Grimberg <sagi@grimberg.me>,
Saeed Mahameed <saeedm@dev.mellanox.co.il>
Cc: "David S. Miller" <davem@davemloft.net>,
Linux Netdev List <netdev@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jes Sorensen <jsorensen@fb.com>
Subject: Re: [net 02/14] Revert "mlx5: move affinity hints assignments to generic code"
Date: Thu, 4 Jan 2018 12:19:30 -0800 [thread overview]
Message-ID: <cae40e8e-dff7-1c2f-71db-97e6545bf098@mellanox.com> (raw)
In-Reply-To: <95a5c181-79fa-da60-1c94-766e19e97dd3@grimberg.me>
On 12/26/2017 9:14 AM, Sagi Grimberg wrote:
>
>> Are you sure it won't get populated at all ? even if you manually set
>> IRQ affinity via sysfs ?
>
> Yes, the msi_desc affinity is not initialized without the affinity
> descriptor passed (which is what PCI_IRQ_AFFINITY is for).
>
>> Anyway we can implement this driver helper function to return the IRQ
>> affinity hint stored in the driver:
>> "cpumask_first(mdev->priv.irq_info[vector].mask);"
>
> minus the cpumask_first, but yea. Please send a new patch so we can
> test it out.
Actually using mdev->priv.irq_info[vector].mask is wrong since it only
gives the initial hint and not the current actual affinity mask.
I found a better way to address this and return the actual dynamic
affinity of an interrupt vector.
I will send a patch to net soon.
next prev parent reply other threads:[~2018-01-04 20:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 22:24 [pull request][net 00/14] Mellanox, mlx5 fixes 2017-12-19 Saeed Mahameed
2017-12-19 22:24 ` [net 01/14] net/mlx5: FPGA, return -EINVAL if size is zero Saeed Mahameed
2017-12-19 22:24 ` [net 02/14] Revert "mlx5: move affinity hints assignments to generic code" Saeed Mahameed
2017-12-19 22:42 ` Jes Sorensen
2017-12-25 13:53 ` Sagi Grimberg
2017-12-26 15:58 ` Saeed Mahameed
2017-12-26 17:14 ` Sagi Grimberg
2018-01-04 20:19 ` Saeed Mahameed [this message]
2017-12-19 22:24 ` [net 03/14] net/mlx5: Fix rate limit packet pacing naming and struct Saeed Mahameed
2017-12-19 22:24 ` [net 04/14] net/mlx5e: Fix ETS BW check Saeed Mahameed
2017-12-20 7:42 ` Or Gerlitz
2017-12-19 22:24 ` [net 05/14] net/mlx5e: Fix features check of IPv6 traffic Saeed Mahameed
2017-12-20 7:45 ` Or Gerlitz
2017-12-19 22:24 ` [net 06/14] net/mlx5e: Fix defaulting RX ring size when not needed Saeed Mahameed
2017-12-19 22:24 ` [net 07/14] net/mlx5: Fix misspelling in the error message and comment Saeed Mahameed
2017-12-19 22:24 ` [net 08/14] net/mlx5: Fix error flow in CREATE_QP command Saeed Mahameed
2017-12-19 22:24 ` [net 09/14] net/mlx5e: Fix possible deadlock of VXLAN lock Saeed Mahameed
2017-12-19 22:24 ` [net 10/14] net/mlx5e: Add refcount to VXLAN structure Saeed Mahameed
2017-12-19 22:24 ` [net 11/14] net/mlx5e: Prevent possible races in VXLAN control flow Saeed Mahameed
2017-12-19 22:24 ` [net 12/14] net/mlx5: Fix steering memory leak Saeed Mahameed
2017-12-19 22:24 ` [net 13/14] net/mlx5: Cleanup IRQs in case of unload failure Saeed Mahameed
2017-12-19 22:24 ` [net 14/14] net/mlx5: Stay in polling mode when command EQ destroy fails Saeed Mahameed
2017-12-20 18:42 ` [pull request][net 00/14] Mellanox, mlx5 fixes 2017-12-19 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cae40e8e-dff7-1c2f-71db-97e6545bf098@mellanox.com \
--to=saeedm@mellanox.com \
--cc=davem@davemloft.net \
--cc=jsorensen@fb.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@dev.mellanox.co.il \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox