* [PATCH net-next] net: phy: check for implementation of both callbacks in phy_drv_supports_irq @ 2018-11-12 20:16 Heiner Kallweit 2018-11-12 20:22 ` Florian Fainelli 2018-11-15 17:30 ` David Miller 0 siblings, 2 replies; 3+ messages in thread From: Heiner Kallweit @ 2018-11-12 20:16 UTC (permalink / raw) To: Andrew Lunn, Florian Fainelli, David Miller; +Cc: netdev@vger.kernel.org Now that the icplus driver has been fixed all PHY drivers supporting interrupts have both callbacks (config_intr and ack_interrupt) implemented - as it should be. Therefore phy_drv_supports_irq() can be changed now to check for both callbacks being implemented. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/phy/phy_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 55202a0ac..e06613f2d 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2122,7 +2122,7 @@ static void of_set_phy_eee_broken(struct phy_device *phydev) static bool phy_drv_supports_irq(struct phy_driver *phydrv) { - return phydrv->config_intr || phydrv->ack_interrupt; + return phydrv->config_intr && phydrv->ack_interrupt; } /** -- 2.19.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: check for implementation of both callbacks in phy_drv_supports_irq 2018-11-12 20:16 [PATCH net-next] net: phy: check for implementation of both callbacks in phy_drv_supports_irq Heiner Kallweit @ 2018-11-12 20:22 ` Florian Fainelli 2018-11-15 17:30 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: Florian Fainelli @ 2018-11-12 20:22 UTC (permalink / raw) To: Heiner Kallweit, Andrew Lunn, David Miller; +Cc: netdev@vger.kernel.org On 11/12/18 12:16 PM, Heiner Kallweit wrote: > Now that the icplus driver has been fixed all PHY drivers supporting > interrupts have both callbacks (config_intr and ack_interrupt) > implemented - as it should be. Therefore phy_drv_supports_irq() > can be changed now to check for both callbacks being implemented. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Acked-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: phy: check for implementation of both callbacks in phy_drv_supports_irq 2018-11-12 20:16 [PATCH net-next] net: phy: check for implementation of both callbacks in phy_drv_supports_irq Heiner Kallweit 2018-11-12 20:22 ` Florian Fainelli @ 2018-11-15 17:30 ` David Miller 1 sibling, 0 replies; 3+ messages in thread From: David Miller @ 2018-11-15 17:30 UTC (permalink / raw) To: hkallweit1; +Cc: andrew, f.fainelli, netdev From: Heiner Kallweit <hkallweit1@gmail.com> Date: Mon, 12 Nov 2018 21:16:06 +0100 > Now that the icplus driver has been fixed all PHY drivers supporting > interrupts have both callbacks (config_intr and ack_interrupt) > implemented - as it should be. Therefore phy_drv_supports_irq() > can be changed now to check for both callbacks being implemented. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Applied, thanks Heiner. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-16 3:39 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-11-12 20:16 [PATCH net-next] net: phy: check for implementation of both callbacks in phy_drv_supports_irq Heiner Kallweit 2018-11-12 20:22 ` Florian Fainelli 2018-11-15 17:30 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox