Netdev List
 help / color / mirror / Atom feed
From: Hui Wang <hui.wang@canonical.com>
To: "Zhang, Rui" <rui.zhang@intel.com>,
	"pmenzel@molgen.mpg.de" <pmenzel@molgen.mpg.de>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"naamax.meir@linux.intel.com" <naamax.meir@linux.intel.com>,
	"Ruinskiy, Dima" <dima.ruinskiy@intel.com>,
	"Lifshits, Vitaly" <vitaly.lifshits@intel.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"intel-wired-lan@lists.osuosl.org"
	<intel-wired-lan@lists.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
	"Neftin, Sasha" <sasha.neftin@intel.com>,
	"edumazet@google.com" <edumazet@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>
Cc: "Keller, Jacob E" <jacob.e.keller@intel.com>,
	"horms@kernel.org" <horms@kernel.org>,
	"Brandt, Todd E" <todd.e.brandt@intel.com>,
	"dmummenschanz@web.de" <dmummenschanz@web.de>,
	"regressions@lists.linux.dev" <regressions@lists.linux.dev>
Subject: Re: [iwl-net][PATCH] Revert "e1000e: move force SMBUS near the end of enable_ulp function"
Date: Tue, 11 Jun 2024 13:45:28 +0800	[thread overview]
Message-ID: <ccca7897-ac53-4056-8617-a3ace57bf7b6@canonical.com> (raw)
In-Reply-To: <98ccb75d7ef48c182425f130e0b2ececeec630ec.camel@intel.com>


On 6/10/24 22:14, Zhang, Rui wrote:
> On Mon, 2024-06-10 at 08:36 +0200, Paul Menzel wrote:
>> Dear Hui,
>>
>>
>>
>> Naama also added Tested-by lines two both commits in question. Could
>> Intel’s test coverage please extended to the problem at hand?
>>
>> Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>
> Plus that,
> 1. Todd and I can test with upstream + this patch to confirm that
>     a. the regression for Todd is gone.
>     b. the s2idle failure for me is back
> 2. I can test with upstream + this patch + revert of commit
> 861e8086029e (e1000e: move force SMBUS from enable ulp function to
> avoid PHY loss issue) to confirm s2idle is working again.
>
> thanks,
> rui
Thanks.
>
>>
>> Kind regards,
>>
>> Paul

  reply	other threads:[~2024-06-11  5:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10  1:32 [iwl-net][PATCH] Revert "e1000e: move force SMBUS near the end of enable_ulp function" Hui Wang
2024-06-10  6:36 ` Paul Menzel
2024-06-10 14:14   ` Zhang, Rui
2024-06-11  5:45     ` Hui Wang [this message]
2024-06-11  5:43   ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccca7897-ac53-4056-8617-a3ace57bf7b6@canonical.com \
    --to=hui.wang@canonical.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=dima.ruinskiy@intel.com \
    --cc=dmummenschanz@web.de \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=naamax.meir@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pmenzel@molgen.mpg.de \
    --cc=regressions@lists.linux.dev \
    --cc=rui.zhang@intel.com \
    --cc=sasha.neftin@intel.com \
    --cc=todd.e.brandt@intel.com \
    --cc=vitaly.lifshits@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox