From: Andrew Lunn <andrew@lunn.ch>
To: Fidan Aliyeva <fidan.aliyeva.ext@ericsson.com>
Cc: olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, marek.behun@nic.cz,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Re: [RFC PATCH 1/1] mv88e6xxx: Cache scratch config of 6352 in setup
Date: Fri, 15 May 2026 17:35:47 +0200 [thread overview]
Message-ID: <ccf88f9d-9617-4ee9-bece-d2e41081bcd2@lunn.ch> (raw)
In-Reply-To: <20260515145042.3091827-1-fidan.aliyeva.ext@ericsson.com>
> I have one more question; now that mv88e6352_g2_scratch_port_has_serdes()
> never returns a value smaller than 0, should all the callers be aware of
> this fact?
You could make it a boolean function.
Shall I change the checks for return value on this function not
> to check for <0 ? All the callers except 1 will be refactored to use
> serdes_get_lane function later, so it might be unnecessary.
but if the code is going to be refactored, it is not really necessary.
Andrew
next prev parent reply other threads:[~2026-05-15 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 21:34 [RFC PATCH 1/1] mv88e6xxx: Cache scratch config of 6352 in setup Fidan Aliyeva
2026-05-10 21:45 ` Fidan Aliyeva
2026-05-10 23:06 ` Andrew Lunn
2026-05-10 23:13 ` Andrew Lunn
2026-05-15 14:50 ` Fidan Aliyeva
2026-05-15 15:35 ` Andrew Lunn [this message]
2026-05-15 22:37 ` [PATCH net-next 0/4] mv88e6xxx: Cache scratch config3 of 6352 Fidan Aliyeva
2026-05-15 22:37 ` [PATCH net-next 1/4] mv88e6xxx: Add mv88e6352_reset for 6352 family Fidan Aliyeva
2026-05-15 22:37 ` [PATCH net-next 2/4] mv88e6xxx: Cache scratch config3 of 6352 Fidan Aliyeva
2026-05-15 22:37 ` [PATCH net-next 3/4] mv88e6xxx: Use cached config3 in 6352 has_serdes Fidan Aliyeva
2026-05-15 22:37 ` [PATCH net-next 4/4] mv88e6xxx: Remove locks for 6352's has_serdes Fidan Aliyeva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ccf88f9d-9617-4ee9-bece-d2e41081bcd2@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fidan.aliyeva.ext@ericsson.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.behun@nic.cz \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox