Netdev List
 help / color / mirror / Atom feed
* NET_RX_DROP vs dev->stats.rx_dropped++ in drivers
@ 2019-02-18  8:30 Joakim Tjernlund
  0 siblings, 0 replies; only message in thread
From: Joakim Tjernlund @ 2019-02-18  8:30 UTC (permalink / raw)
  To: netdev@vger.kernel.org

We have noticed odd dropped packets in a few cases and these comes from
drivers that do this:
...
	dropped = netif_rx(sb);
	if (dropped == NET_RX_DROP) {
		dev->stats.rx_dropped++;
...

This seems a bit odd to me, should drivers account for dropped pkgs in this case?

 Jocke

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-02-18  8:31 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-18  8:30 NET_RX_DROP vs dev->stats.rx_dropped++ in drivers Joakim Tjernlund

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox