* [PATCH 3/3] X25: Fix oops and refcnt problems from x25_dev_get
@ 2009-11-25 1:16 andrew hendry
0 siblings, 0 replies; only message in thread
From: andrew hendry @ 2009-11-25 1:16 UTC (permalink / raw)
To: netdev; +Cc: linux-kernel, linux-x25
Calls to x25_dev_get check for dev = NULL which was not set.
It allowed x25 to set routes and ioctls on down interfaces.
This caused oopses and refcnt problems on device_unregister.
Signed-off-by: Andrew Hendry <andrew.hendry@gmail.com>
--- a/net/x25/x25_route.c 2009-11-25 09:30:52.003038597 +1100
+++ b/net/x25/x25_route.c 2009-11-25 09:33:37.627093701 +1100
@@ -136,8 +136,10 @@ struct net_device *x25_dev_get(char *dev
#if defined(CONFIG_LLC) || defined(CONFIG_LLC_MODULE)
&& dev->type != ARPHRD_ETHER
#endif
- )))
+ ))){
dev_put(dev);
+ dev = NULL;
+ }
return dev;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-11-25 1:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-25 1:16 [PATCH 3/3] X25: Fix oops and refcnt problems from x25_dev_get andrew hendry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox