From: David Ahern <dsahern@gmail.com>
To: Eric Dumazet <edumazet@google.com>
Cc: netdev <netdev@vger.kernel.org>, Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH iproute2-next] tc: fq: support ce_threshold attribute
Date: Sat, 24 Nov 2018 08:38:50 -0700 [thread overview]
Message-ID: <d74e16dd-1c40-dd6d-4e47-69ae45cc32b9@gmail.com> (raw)
In-Reply-To: <20181124063724.169456-1-edumazet@google.com>
On 11/23/18 11:37 PM, Eric Dumazet wrote:
> Kernel commit 48872c11b772 ("net_sched: sch_fq: add dctcp-like marking")
> added support for TCA_FQ_CE_THRESHOLD attribute.
>
> This patch adds iproute2 support for it.
>
> It also makes sure fq_print_xstats() can deal with smaller tc_fq_qd_stats
> structures given by older kernels.
>
> Usage :
>
> FQATTRS="ce_threshold 4ms"
> TXQS=8
>
> for ETH in eth0
> do
> tc qd del dev $ETH root 2>/dev/null
> tc qd add dev $ETH root handle 1: mq
> for i in `seq 1 $TXQS`
> do
> tc qd add dev $ETH parent 1:$i fq $FQATTRS
> done
> done
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
> tc/q_fq.c | 32 ++++++++++++++++++++++++++++----
> 1 file changed, 28 insertions(+), 4 deletions(-)
>
applied to iproute2-next. Thanks
Eric: the fq man page is out of date. Can you update it as well - not
just this argument but other missing ones? Thanks
prev parent reply other threads:[~2018-11-25 2:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 6:37 [PATCH iproute2-next] tc: fq: support ce_threshold attribute Eric Dumazet
2018-11-24 15:38 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d74e16dd-1c40-dd6d-4e47-69ae45cc32b9@gmail.com \
--to=dsahern@gmail.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox