Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Anvesh Jain P <quic_ajainp@quicinc.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <simon.horman@corigine.com>,
	Kuniyuki Iwashima <kuniyu@amazon.com>,
	Hangbin Liu <liuhangbin@gmail.com>, Jiri Pirko <jiri@resnulli.us>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Andy Ren <andy.ren@getcruise.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Venkata Rao Kakani <quic_vkakani@quicinc.com>,
	Vagdhan Kumar <quic_vagdhank@quicinc.com>
Subject: Re: [PATCH] net: export dev_change_name function
Date: Tue, 1 Aug 2023 16:07:15 +0200	[thread overview]
Message-ID: <d88e4980-66e5-4ff2-a868-7f7450181925@lunn.ch> (raw)
In-Reply-To: <8c591002-308e-bdba-de5f-c96113230451@quicinc.com>

> CONFIG_RENAME_DEVICES is the module which needs "dev_change_name" API. Our
> requirement is to change the network device name from kernel space.

Can you give a link to this module. It is very unusual for the kernel
to change the device name. Before accepting this patch, we probably
want a better understanding of the big picture. Which is why we
normally to use the user of an API.

   Andrew

  reply	other threads:[~2023-08-01 14:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01 11:21 [PATCH] net: export dev_change_name function Anvesh Jain P
2023-08-01 12:31 ` Andrew Lunn
2023-08-01 13:07   ` Anvesh Jain P
2023-08-01 14:07     ` Andrew Lunn [this message]
2023-08-01 14:11     ` Eric Dumazet
2023-08-01 17:27 ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d88e4980-66e5-4ff2-a868-7f7450181925@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andy.ren@getcruise.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_ajainp@quicinc.com \
    --cc=quic_vagdhank@quicinc.com \
    --cc=quic_vkakani@quicinc.com \
    --cc=simon.horman@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox