From: Jiri Pirko <jiri@resnulli.us>
To: Anvesh Jain P <quic_ajainp@quicinc.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <simon.horman@corigine.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Hangbin Liu <liuhangbin@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Andy Ren <andy.ren@getcruise.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Venkata Rao Kakani <quic_vkakani@quicinc.com>,
Vagdhan Kumar <quic_vagdhank@quicinc.com>
Subject: Re: [PATCH] net: export dev_change_name function
Date: Tue, 1 Aug 2023 19:27:01 +0200 [thread overview]
Message-ID: <ZMlAZdWX3EToTUVT@nanopsycho> (raw)
In-Reply-To: <20230801112101.15564-1-quic_ajainp@quicinc.com>
Tue, Aug 01, 2023 at 01:21:01PM CEST, quic_ajainp@quicinc.com wrote:
>export dev_change_name function to be used by other modules.
>
>Signed-off-by: Vagdhan Kumar <quic_vagdhank@quicinc.com>
>Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com>
>---
> net/core/dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/net/core/dev.c b/net/core/dev.c
>index 69a3e544676c..1dad68e2950c 100644
>--- a/net/core/dev.c
>+++ b/net/core/dev.c
>@@ -1254,6 +1254,7 @@ int dev_change_name(struct net_device *dev, const char *newname)
>
> return err;
> }
>+EXPORT_SYMBOL(dev_change_name);
>
> /**
> * dev_set_alias - change ifalias of a device
>
>base-commit: 0a8db05b571ad5b8d5c8774a004c0424260a90bd
nack.
1) there is no in-tree user
2) changing name from anywhere else than userspace does not make any
sense. I'll eat my shoes if there is a sane reason for it.
Please don't send patches like this.
>--
>2.17.1
>
prev parent reply other threads:[~2023-08-01 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 11:21 [PATCH] net: export dev_change_name function Anvesh Jain P
2023-08-01 12:31 ` Andrew Lunn
2023-08-01 13:07 ` Anvesh Jain P
2023-08-01 14:07 ` Andrew Lunn
2023-08-01 14:11 ` Eric Dumazet
2023-08-01 17:27 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMlAZdWX3EToTUVT@nanopsycho \
--to=jiri@resnulli.us \
--cc=andy.ren@getcruise.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_ajainp@quicinc.com \
--cc=quic_vagdhank@quicinc.com \
--cc=quic_vkakani@quicinc.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox