[PATCH] net: export dev_change_name function

[PATCH] net: export dev_change_name function

[Anvesh Jain P]

export dev_change_name function to be used by other modules.

Signed-off-by: Vagdhan Kumar <quic_vagdhank@quicinc.com>
Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com>
---
 net/core/dev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/dev.c b/net/core/dev.c
index 69a3e544676c..1dad68e2950c 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -1254,6 +1254,7 @@ int dev_change_name(struct net_device *dev, const char *newname)
 
 	return err;
 }
+EXPORT_SYMBOL(dev_change_name);
 
 /**
  *	dev_set_alias - change ifalias of a device

base-commit: 0a8db05b571ad5b8d5c8774a004c0424260a90bd
-- 
2.17.1

Re: [PATCH] net: export dev_change_name function

[Andrew Lunn]

On Tue, Aug 01, 2023 at 04:51:01PM +0530, Anvesh Jain P wrote:
> export dev_change_name function to be used by other modules.
> 
> Signed-off-by: Vagdhan Kumar <quic_vagdhank@quicinc.com>
> Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com>

It would be normal to include a user of the API when exposing an API.

What module needs to change the name of a device? At the moment, only
user space can do this via netlink or an IOCTL.

     Andrew

Re: [PATCH] net: export dev_change_name function

[Anvesh Jain P]

On 8/1/2023 6:01 PM, Andrew Lunn wrote:
> On Tue, Aug 01, 2023 at 04:51:01PM +0530, Anvesh Jain P wrote:
>> export dev_change_name function to be used by other modules.
>>
>> Signed-off-by: Vagdhan Kumar <quic_vagdhank@quicinc.com>
>> Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com>
> 
> It would be normal to include a user of the API when exposing an API.
> 
> What module needs to change the name of a device? At the moment, only
> user space can do this via netlink or an IOCTL.
> 
>       Andrew
CONFIG_RENAME_DEVICES is the module which needs "dev_change_name" API. 
Our requirement is to change the network device name from kernel space.

Re: [PATCH] net: export dev_change_name function

[Andrew Lunn]

> CONFIG_RENAME_DEVICES is the module which needs "dev_change_name" API. Our
> requirement is to change the network device name from kernel space.

Can you give a link to this module. It is very unusual for the kernel
to change the device name. Before accepting this patch, we probably
want a better understanding of the big picture. Which is why we
normally to use the user of an API.

   Andrew

Re: [PATCH] net: export dev_change_name function

[Eric Dumazet]

On Tue, Aug 1, 2023 at 3:08 PM Anvesh Jain P <quic_ajainp@quicinc.com> wrote:
>
>
>
> On 8/1/2023 6:01 PM, Andrew Lunn wrote:
> > On Tue, Aug 01, 2023 at 04:51:01PM +0530, Anvesh Jain P wrote:
> >> export dev_change_name function to be used by other modules.
> >>
> >> Signed-off-by: Vagdhan Kumar <quic_vagdhank@quicinc.com>
> >> Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com>
> >
> > It would be normal to include a user of the API when exposing an API.
> >
> > What module needs to change the name of a device? At the moment, only
> > user space can do this via netlink or an IOCTL.
> >
> >       Andrew
> CONFIG_RENAME_DEVICES is the module which needs "dev_change_name" API.
> Our requirement is to change the network device name from kernel space.

We do not support out-of-tree code.

You will have to upstream this code first.

Re: [PATCH] net: export dev_change_name function

[Jiri Pirko]

Tue, Aug 01, 2023 at 01:21:01PM CEST, quic_ajainp@quicinc.com wrote:
>export dev_change_name function to be used by other modules.
>
>Signed-off-by: Vagdhan Kumar <quic_vagdhank@quicinc.com>
>Signed-off-by: Anvesh Jain P <quic_ajainp@quicinc.com>
>---
> net/core/dev.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/net/core/dev.c b/net/core/dev.c
>index 69a3e544676c..1dad68e2950c 100644
>--- a/net/core/dev.c
>+++ b/net/core/dev.c
>@@ -1254,6 +1254,7 @@ int dev_change_name(struct net_device *dev, const char *newname)
> 
> 	return err;
> }
>+EXPORT_SYMBOL(dev_change_name);
> 
> /**
>  *	dev_set_alias - change ifalias of a device
>
>base-commit: 0a8db05b571ad5b8d5c8774a004c0424260a90bd

nack.
1) there is no in-tree user
2) changing name from anywhere else than userspace does not make any
   sense. I'll eat my shoes if there is a sane reason for it.

Please don't send patches like this.


>-- 
>2.17.1
>