From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: andreyknvl@google.com, Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [Patch net] ip6mr: avoid double unregister of pim6reg device
Date: Fri, 21 Apr 2017 22:34:20 +0300 [thread overview]
Message-ID: <db28d88e-ed4d-de81-fea2-c404a5b89af0@cumulusnetworks.com> (raw)
In-Reply-To: <1492802839-16851-1-git-send-email-xiyou.wangcong@gmail.com>
On 21/04/17 22:27, Cong Wang wrote:
> If we unregister the pim6reg device via default_device_exit_batch(),
> we will receive a notification and ip6mr_device_event() will
> unregister it again. This causes a kernel BUG at net/core/dev.c:6813.
>
> Like commit 7dc00c82cbb0 ("ipv4: Fix ipmr unregister device oops")
> we should avoid double-unregister in netdevice notifier.
>
> Reported-by: Andrey Konovalov <andreyknvl@google.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
> net/ipv6/ip6mr.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
Cong,
Please read the full thread, I've already provided a fix which is similar.
https://patchwork.ozlabs.org/patch/753531/
Thanks,
Nik
next prev parent reply other threads:[~2017-04-21 19:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 19:27 [Patch net] ip6mr: avoid double unregister of pim6reg device Cong Wang
2017-04-21 19:34 ` Nikolay Aleksandrov [this message]
2017-04-21 20:20 ` Cong Wang
2017-04-21 20:25 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db28d88e-ed4d-de81-fea2-c404a5b89af0@cumulusnetworks.com \
--to=nikolay@cumulusnetworks.com \
--cc=andreyknvl@google.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox