Netdev List
 help / color / mirror / Atom feed
* [PATCH net v2 0/5] net: bcmgenet, systemport: DIM and Rx discard fixes
@ 2026-11-20 22:42 Nicolai Buchwitz
  2026-11-20 22:42 ` [PATCH net v2 1/5] net: bcmgenet: keep DIM from getting stuck after close or suspend Nicolai Buchwitz
                   ` (4 more replies)
  0 siblings, 5 replies; 7+ messages in thread
From: Nicolai Buchwitz @ 2026-11-20 22:42 UTC (permalink / raw)
  To: Doug Berger, Florian Fainelli, Andrew Lunn, David S. Miller,
	Eric Dumazet, Jakub Kicinski, Paolo Abeni
  Cc: Justin Chen, Petri Gynther, Broadcom internal kernel review list,
	netdev, linux-kernel, Nicolai Buchwitz

Sashiko has flagged a few genet bugs over time. I'll work through them
as time permits, fixing the ones that seem worth it.

DIM on genet and systemport wants running totals but gets per-poll
counts, so it picks bogus profiles from the wrong numbers.

The series also fixes DIM getting stuck after a down/up or suspend and
resets the Rx discard count with the ring.

Patches 1-3 have been tested on a Raspberry Pi CM4. I don't have any
systemport hardware, but the bugs there are the same.

---
Changes in v2:
- genet: flush the DIM work instead of cancelling it, which also covers
  WoL suspend (Sashiko)
- genet: reset DIM before switching to running totals, so a stale sample
  can't wrap after a reopen (Sashiko)
- genet, systemport: run net_dim() before napi_complete_done(), so no
  DIM work can be queued after napi_disable()
- systemport: add the same DIM reset (Sashiko)
- systemport: the set_coalesce vs DIM work race is pre-existing and left
  for a separate patch
- Link to v1: https://patch.msgid.link/20261118-nb-genet-dim-stats-net-v1-0-13b275f1e088@tipi-net.de

---
Nicolai Buchwitz (5):
      net: bcmgenet: keep DIM from getting stuck after close or suspend
      net: bcmgenet: accumulate the DIM packet and byte counters
      net: bcmgenet: reset the Rx discard count with the ring
      net: systemport: restart DIM from the default profile on start
      net: systemport: accumulate the DIM packet and byte counters

 drivers/net/ethernet/broadcom/bcmsysport.c     | 20 ++++++++++++--------
 drivers/net/ethernet/broadcom/genet/bcmgenet.c | 19 +++++++++++++------
 2 files changed, 25 insertions(+), 14 deletions(-)
---
base-commit: 2a324a58a084c5cfd7e5a2f55e0786bee170a4a5
change-id: 20261118-nb-genet-dim-stats-net-b6b6fd30398f

Best regards,
--  
Nicolai Buchwitz <nb@tipi-net.de>


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-11-21  0:19 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-20 22:42 [PATCH net v2 0/5] net: bcmgenet, systemport: DIM and Rx discard fixes Nicolai Buchwitz
2026-11-20 22:42 ` [PATCH net v2 1/5] net: bcmgenet: keep DIM from getting stuck after close or suspend Nicolai Buchwitz
2026-11-21  0:19   ` Florian Fainelli
2026-11-20 22:42 ` [PATCH net v2 2/5] net: bcmgenet: accumulate the DIM packet and byte counters Nicolai Buchwitz
2026-11-20 22:42 ` [PATCH net v2 3/5] net: bcmgenet: reset the Rx discard count with the ring Nicolai Buchwitz
2026-11-20 22:42 ` [PATCH net v2 4/5] net: systemport: restart DIM from the default profile on start Nicolai Buchwitz
2026-11-20 22:42 ` [PATCH net v2 5/5] net: systemport: accumulate the DIM packet and byte counters Nicolai Buchwitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox