From: "Ed Swierk" <eswierk@arastra.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] forcedeth: power down phy when interface is down
Date: Tue, 18 Sep 2007 09:58:25 -0700 [thread overview]
Message-ID: <e6c711510709180958j41265e87kd5126b7d5e832c0e@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
Bring the physical link down when the interface is down, by placing
the PHY in power-down state. This mirrors the behavior of other
drivers including e1000 and tg3.
Signed-off-by: Ed Swierk <eswierk@arastra.com>
[-- Attachment #2: forcedeth-phy-power-down.patch --]
[-- Type: application/octet-stream, Size: 1556 bytes --]
Bring the physical link down when the interface is down, by placing the PHY
in power-down state. This mirrors the behavior of other drivers including
e1000 and tg3.
Signed-off-by: Ed Swierk <eswierk@arastra.com>
Index: linux-2.6.22.6/drivers/net/forcedeth.c
===================================================================
--- linux-2.6.22.6.orig/drivers/net/forcedeth.c
+++ linux-2.6.22.6/drivers/net/forcedeth.c
@@ -1307,9 +1307,9 @@ static int phy_init(struct net_device *d
/* some phys clear out pause advertisment on reset, set it back */
mii_rw(dev, np->phyaddr, MII_ADVERTISE, reg);
- /* restart auto negotiation */
+ /* restart auto negotiation, power down phy */
mii_control = mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ);
- mii_control |= (BMCR_ANRESTART | BMCR_ANENABLE);
+ mii_control |= (BMCR_ANRESTART | BMCR_ANENABLE | BMCR_PDOWN);
if (mii_rw(dev, np->phyaddr, MII_BMCR, mii_control)) {
return PHY_ERROR;
}
@@ -4792,6 +4792,10 @@ static int nv_open(struct net_device *de
dprintk(KERN_DEBUG "nv_open: begin\n");
+ /* power up phy */
+ mii_rw(dev, np->phyaddr, MII_BMCR,
+ mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ) & ~BMCR_PDOWN);
+
/* erase previous misconfiguration */
if (np->driver_data & DEV_HAS_POWER_CNTRL)
nv_mac_reset(dev);
@@ -4972,6 +4976,10 @@ static int nv_close(struct net_device *d
nv_start_rx(dev);
}
+ /* power down phy */
+ mii_rw(dev, np->phyaddr, MII_BMCR,
+ mii_rw(dev, np->phyaddr, MII_BMCR, MII_READ) | BMCR_PDOWN);
+
/* FIXME: power down nic */
return 0;
next reply other threads:[~2007-09-18 16:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 16:58 Ed Swierk [this message]
2007-09-20 2:17 ` [PATCH] forcedeth: power down phy when interface is down Ayaz Abdulla
2007-09-21 18:12 ` [updated PATCH] " Ed Swierk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6c711510709180958j41265e87kd5126b7d5e832c0e@mail.gmail.com \
--to=eswierk@arastra.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox