[PATCH net-2.6.25] [NETNS] change net/Kconfig to avoid a broken build when building with network namesapce support.

[PATCH net-2.6.25] [NETNS] change net/Kconfig to avoid a broken build when building with network namesapce support.

[Rami Rosen]

[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]

Hi,

The build is broken with the following kernel configuration:

- net-2.6.25
- Support for network namespaces enabled (CONFIG_NET_NS=y)
- CONFIG_RCU_TRACE=y
	CONFIG_RCU_TRACE can be set by:
	 make menuconfig ->Processor type and features->Enable tracing for RCU.
	
- The error in build is :
	  fs/built-in.o: In function `debugfs_init':
	 /work/src/netGit2.6.25/2.6.25/fs/debugfs/inode.c:435: undefined
	 reference to `kernel_kobj'
	 make: *** [.tmp_vmlinux1] Error 1

The reason is : RCU_TRACE selects DEBUG_FS,
 but CONFIG_NET_NS depends on EXPERIMENTAL && !SYSFS;
 debugfs can't be built without sysfs.

 There is currently a bit of mess with SYSFS and in fact it seems that
maybe selecting DEBUG_FS
should depend on SYSFS; to avoid this problem in the build,
 this patch adds !DEBUG_FS to CONFIG_NET_NS dependencies in net/Kconfig.
 This way, if CONFIG_RCU_TRACE is set, ( or other configuration items which
selects DEBUG_FS), we cannot set CONFIG_NET_NS.

Regards,
Rami Rosen


Signed-off-by: Rami Rosen <ramirose@gmail.com>

[-- Attachment #2: patch.txt --]
[-- Type: text/plain, Size: 397 bytes --]

diff --git a/net/Kconfig b/net/Kconfig
index b6a5d45..82337e2 100644
--- a/net/Kconfig
+++ b/net/Kconfig
@@ -30,7 +30,7 @@ menu "Networking options"
 config NET_NS
 	bool "Network namespace support"
 	default n
-	depends on EXPERIMENTAL && !SYSFS
+	depends on EXPERIMENTAL && !SYSFS && !DEBUG_FS
 	help
 	  Allow user space to create what appear to be multiple instances
 	  of the network stack.