* MTU of bridge after deleting an interface
@ 2015-03-12 22:37 Venkat Venkatsubra
2015-03-12 23:18 ` Roopa Prabhu
0 siblings, 1 reply; 2+ messages in thread
From: Venkat Venkatsubra @ 2015-03-12 22:37 UTC (permalink / raw)
To: netdev; +Cc: davem
Hello All,
When adding an interface the bridge interface's MTU is set to the
minimum of all the interfaces. Call to dev_set_mtu(br->dev, br_min_mtu(br))
in br_add_if() achieves that. But when deleting an interface from the bridge
the MTU is not reset again to the minimum of the current set of interfaces.
Is there a reason it is that way ?
If not I could send a patch that resets the MTU with a call to
dev_set_mtu(br->dev, br_min_mtu(br)) in br_del_if().
Looking forward to your response.
Thanks.
Venkat
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: MTU of bridge after deleting an interface
2015-03-12 22:37 MTU of bridge after deleting an interface Venkat Venkatsubra
@ 2015-03-12 23:18 ` Roopa Prabhu
0 siblings, 0 replies; 2+ messages in thread
From: Roopa Prabhu @ 2015-03-12 23:18 UTC (permalink / raw)
To: Venkat Venkatsubra; +Cc: netdev@vger.kernel.org, davem@davemloft.net
On Thu, Mar 12, 2015 at 3:37 PM, Venkat Venkatsubra
<venkat.x.venkatsubra@oracle.com> wrote:
> Hello All,
>
> When adding an interface the bridge interface's MTU is set to the
> minimum of all the interfaces. Call to dev_set_mtu(br->dev, br_min_mtu(br))
> in br_add_if() achieves that. But when deleting an interface from the bridge
> the MTU is not reset again to the minimum of the current set of interfaces.
> Is there a reason it is that way ?
>
> If not I could send a patch that resets the MTU with a call to
> dev_set_mtu(br->dev, br_min_mtu(br)) in br_del_if().
>
seems like the right thing to do. you should submit a patch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-12 23:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-12 22:37 MTU of bridge after deleting an interface Venkat Venkatsubra
2015-03-12 23:18 ` Roopa Prabhu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox