From: Paolo Abeni <pabeni@redhat.com>
To: Alexandre Cassen <acassen@corp.free.fr>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>, Mark Bloch <mbloch@nvidia.com>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Moshe Shemesh <moshe@nvidia.com>,
Yevgeny Kliteynik <kliteyn@nvidia.com>,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH net 0/2] net/mlx5: HWS, fix reformat release and meter offset
Date: Tue, 13 Oct 2026 15:21:18 +0200 [thread overview]
Message-ID: <f55e07d9-3b47-4f74-b458-9a841234c681@redhat.com> (raw)
In-Reply-To: <25a7141a-7c98-4678-8f17-374e920aad6b@corp.free.fr>
On 10/13/26 14:04, Alexandre Cassen wrote:
> On 10/13/26 12:39, Paolo Abeni wrote:
>> On 10/7/26 16:38, Alexandre Cassen wrote:
>> The actual impact is not clear to me
>
> Both bugs only affect HW steering mode (opt-in). I found them on a ConnectX-7 while offloading multiple tc rules, each with its own encap and meter.
>
> Patch 1 is a leak. In an add/del loop of an L2 to L3 tunnel encap, every iteration after the first leaks a bulk of 64K entries. That is about 2 MB of host memory and 4 MB of device memory.
>
> Patch 2 is more serious. Every tc police action past the second one runs on the meter of another action, so its traffic gets the wrong rate... (my use-case is mobile network where counters accuracy is truly important)
Ok, looks indeed net worthy, thanks!
/P
next prev parent reply other threads:[~2026-10-13 13:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 14:38 [PATCH net 0/2] net/mlx5: HWS, fix reformat release and meter offset Alexandre Cassen
2026-10-07 14:38 ` [PATCH net 1/2] net/mlx5: HWS, release L2 to L3 tunnel reformats to their own pool Alexandre Cassen
2026-10-08 13:32 ` Yevgeny Kliteynik
2026-10-11 6:51 ` Tariq Toukan
2026-10-07 14:38 ` [PATCH net 2/2] net/mlx5: HWS, fix flow meter offset within its bulk Alexandre Cassen
2026-10-08 15:59 ` Moshe Shemesh
2026-10-11 6:52 ` Tariq Toukan
2026-10-07 14:44 ` [PATCH net 0/2] net/mlx5: HWS, fix reformat release and meter offset netdev-bot+sinfo
2026-10-13 10:39 ` Paolo Abeni
2026-10-13 12:04 ` Alexandre Cassen
2026-10-13 13:21 ` Paolo Abeni [this message]
2026-10-13 13:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f55e07d9-3b47-4f74-b458-9a841234c681@redhat.com \
--to=pabeni@redhat.com \
--cc=acassen@corp.free.fr \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kliteyn@nvidia.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox