From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, horms@kernel.org, pabeni@redhat.com,
edumazet@google.com, davem@davemloft.net
Subject: Re: [PATCH 00/13 net-next] Allow compiling an IPv6-only kernel network stack
Date: Mon, 28 Sep 2026 21:15:26 +0200 [thread overview]
Message-ID: <f6f141ec-6294-4fbc-be13-04b9b0e6b45f@suse.de> (raw)
In-Reply-To: <willemdebruijn.kernel.736256d759b9@gmail.com>
On 9/28/26 7:08 PM, Willem de Bruijn wrote:
> Fernando Fernandez Mancera wrote:
>> On 9/15/26 2:24 AM, Jakub Kicinski wrote:
>>> On Thu, 10 Sep 2026 16:48:25 +0200 Fernando Fernandez Mancera wrote:
>>>> The primary goal of this patch series is to enable the compilation of an
>>>> IPv6-only kernel by decoupling the core networking infrastructure from the IPv4
>>>> protocol.
>>>
>>> Could you useful to know for example how many of the recent CVEs were
>>> IPv4 specific, if you have enough token budget to get such data?
>>>
>>
>> Hi Jakub I will include the numbers in the v2 cover letter but in essence:
>>
>> 0.3% (32) of the released CVEs since 2025. FWIW, this only includes
>> strictly IPv4-only code. The percentage is also stable over time if we
>> extend the search up to 2020, 0.3% (57) of the released CVEs.
>>
>>> High level, I don't have must to say beyond what you already know -
>>> the code movement may be too painful for backports. There are too
>>> many ifdefs (as Stan pointed out).
>>>
>>
>> Yes, the code movement is the biggest pain. Regarding the ifdefs, they
>> are being reduced greatly in the v2 as I have decided to rely on DCE
>> (Dead Code Elimination) to avoid using them. The code looks much better
>> this way.
>
> On code movement: are the large code block movements into separate ipv4
> files needed, or could those just as well stay in place, behind an if
> enabled check?
It depends. Most of it could be guarded with ifdefs but that would IMHO
make the code ugly and quite confusing. That code is 100% IPv4-only so
it should be moved out..
In addition, this happened in the past too, e.g net/ipv4/tcp_ipv4.c was
splitted from net/ipv4/tcp.c even before this series.
Of course, I trust maintainers' taste here so if you all insist that it
is much better to put ifdefs.. so be it! But in my opinion, this make
completes sense (while acknowledging the pain it might introduce for
backports). FWIW, the code does not change.. so finding the function in
the other file should be rather easy.
Thanks,
Fernando.
prev parent reply other threads:[~2026-09-28 19:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-10 14:48 [PATCH 00/13 net-next] Allow compiling an IPv6-only kernel network stack Fernando Fernandez Mancera
2026-09-10 14:48 ` [PATCH 01/13 net-next] net: ipv4: introduce CONFIG_IPV4 to decouple the IPv4 stack Fernando Fernandez Mancera
2026-09-10 15:11 ` Nicolai Buchwitz
2026-09-10 15:32 ` Fernando Fernandez Mancera
2026-09-10 15:36 ` Arnd Bergmann
2026-09-10 16:22 ` Fernando Fernandez Mancera
2026-09-10 16:30 ` Fernando Fernandez Mancera
2026-09-10 16:56 ` Sven Eckelmann
2026-09-11 18:39 ` Fernando Fernandez Mancera
2026-09-10 18:55 ` Chuck Lever
2026-09-11 17:46 ` Casey Schaufler
2026-09-11 18:31 ` Fernando Fernandez Mancera
2026-09-11 18:59 ` Casey Schaufler
2026-09-10 14:48 ` [PATCH 02/13 net-next] net: core: add IPv4 fallback stubs and guards for CONFIG_IPV4=n Fernando Fernandez Mancera
2026-09-10 14:48 ` [PATCH 03/13 net-next] net: inet: relocate ip_generic_getfrag and guard IPv4 socket logic Fernando Fernandez Mancera
2026-09-10 21:19 ` Stanislav Fomichev
2026-09-11 18:41 ` Fernando Fernandez Mancera
2026-09-28 13:29 ` Fernando Fernandez Mancera
2026-09-10 14:48 ` [PATCH 04/13 net-next] net: tcp: move protocol agnostic TCP functions out of tcp_ipv4.c Fernando Fernandez Mancera
2026-09-10 14:48 ` [PATCH 05/13 net-next] net: raw: split IPv4 specific logic into raw_ipv4.c Fernando Fernandez Mancera
2026-09-10 14:48 ` [PATCH 06/13 net-next] net: udp: split IPv4 specific logic into udp_ipv4.c Fernando Fernandez Mancera
2026-09-10 14:48 ` [PATCH 07/13 net-next] net: icmp: split IPv4 specific logic into icmp_ipv4.c Fernando Fernandez Mancera
2026-09-10 14:48 ` [PATCH 08/13 net-next] net: ping: split IPv4 specific logic into ping_ipv4.c Fernando Fernandez Mancera
2026-09-10 14:48 ` [PATCH 09/13 net-next] net: fib: split common nexthop logic to fib_core.c Fernando Fernandez Mancera
2026-09-10 14:48 ` [PATCH 10/13 net-next] net: tunnel: guard IPv4 tunnel functions with CONFIG_IPV4 Fernando Fernandez Mancera
2026-09-10 14:48 ` [PATCH 11/13 net-next] netfilter: ipv4: guard ip_route_me_harder() " Fernando Fernandez Mancera
2026-09-10 14:48 ` [PATCH 12/13 net-next] net: ipv4: disable IPv4-only sysctls when CONFIG_IPV4=n Fernando Fernandez Mancera
2026-09-15 12:16 ` Joel Granados
2026-09-10 14:48 ` [PATCH 13/13 net-next] net: ipv4: make CONFIG_IPV4 boolean Fernando Fernandez Mancera
2026-09-15 0:24 ` [PATCH 00/13 net-next] Allow compiling an IPv6-only kernel network stack Jakub Kicinski
2026-09-28 13:37 ` Fernando Fernandez Mancera
2026-09-28 17:08 ` Willem de Bruijn
2026-09-28 19:15 ` Fernando Fernandez Mancera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6f141ec-6294-4fbc-be13-04b9b0e6b45f@suse.de \
--to=fmancera@suse.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox