* [PATCH net] net: wwan: mhi_wwan_mbim: fix dangling links on registration failure
@ 2026-11-11 11:32 Xia Yan
2026-11-17 12:18 ` Paolo Abeni
2026-11-17 12:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Xia Yan @ 2026-11-11 11:32 UTC (permalink / raw)
To: netdev, loic.poulain, ryazanov.s.a
Cc: johannes, andrew+netdev, davem, edumazet, kuba, pabeni,
linux-kernel, stable, yana06070
mhi_mbim_newlink() adds the link to mbim->link_list before calling
register_netdevice(). If registration fails, the caller frees the
netdev without removing the link, leaving a dangling list entry that
RCU readers such as mhi_mbim_rx() can access after free.
Register the netdev before adding the link to the list so that failed
registrations do not publish a link.
Found while reviewing newlink error paths. A UML/KASAN test module
using driver wrappers and a fake MHI context reproduced the use-after-free
in the driver's RCU lookup. The fix passed the registration-failure and
create/delete tests. Both UML builds passed with W=1.
Fixes: aa730a9905b7 ("net: wwan: Add MHI MBIM network driver")
Cc: stable@vger.kernel.org
Signed-off-by: Xia Yan <yanxia@cmss.chinamobile.com>
---
drivers/net/wwan/mhi_wwan_mbim.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wwan/mhi_wwan_mbim.c b/drivers/net/wwan/mhi_wwan_mbim.c
index 336f897..846b317 100644
--- a/drivers/net/wwan/mhi_wwan_mbim.c
+++ b/drivers/net/wwan/mhi_wwan_mbim.c
@@ -561,6 +561,7 @@ static int mhi_mbim_newlink(void *ctxt, struct net_device *ndev, u32 if_id,
{
struct mhi_mbim_link *link = wwan_netdev_drvpriv(ndev);
struct mhi_mbim_context *mbim = ctxt;
+ int ret;
link->mbim = mbim;
link->session = mhi_mbim_get_link_mux_id(link->mbim->mdev->mhi_cntrl) + if_id;
@@ -575,10 +576,14 @@ static int mhi_mbim_newlink(void *ctxt, struct net_device *ndev, u32 if_id,
}
rcu_read_unlock();
+ ret = register_netdevice(ndev);
+ if (ret)
+ return ret;
+
/* Already protected by RTNL lock */
hlist_add_head_rcu(&link->hlnode, &mbim->link_list[LINK_HASH(if_id)]);
- return register_netdevice(ndev);
+ return 0;
}
static void mhi_mbim_dellink(void *ctxt, struct net_device *ndev,
base-commit: 8d5ce4751fad9499ea408163af7f410f18a85782
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: wwan: mhi_wwan_mbim: fix dangling links on registration failure
2026-11-11 11:32 [PATCH net] net: wwan: mhi_wwan_mbim: fix dangling links on registration failure Xia Yan
@ 2026-11-17 12:18 ` Paolo Abeni
2026-11-17 12:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Paolo Abeni @ 2026-11-17 12:18 UTC (permalink / raw)
To: Xia Yan, netdev, loic.poulain, ryazanov.s.a
Cc: johannes, andrew+netdev, davem, edumazet, kuba, linux-kernel,
stable, yana06070
On 11/11/26 12:32, Xia Yan wrote:
> mhi_mbim_newlink() adds the link to mbim->link_list before calling
> register_netdevice(). If registration fails, the caller frees the
> netdev without removing the link, leaving a dangling list entry that
> RCU readers such as mhi_mbim_rx() can access after free.
>
> Register the netdev before adding the link to the list so that failed
> registrations do not publish a link.
>
> Found while reviewing newlink error paths. A UML/KASAN test module
> using driver wrappers and a fake MHI context reproduced the use-after-free
> in the driver's RCU lookup. The fix passed the registration-failure and
> create/delete tests. Both UML builds passed with W=1.
>
> Fixes: aa730a9905b7 ("net: wwan: Add MHI MBIM network driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Xia Yan <yanxia@cmss.chinamobile.com>
This is not 'net' nor stable material.
/P
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: wwan: mhi_wwan_mbim: fix dangling links on registration failure
2026-11-11 11:32 [PATCH net] net: wwan: mhi_wwan_mbim: fix dangling links on registration failure Xia Yan
2026-11-17 12:18 ` Paolo Abeni
@ 2026-11-17 12:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-11-17 12:30 UTC (permalink / raw)
To: Xia Yan
Cc: netdev, loic.poulain, ryazanov.s.a, johannes, andrew+netdev,
davem, edumazet, kuba, pabeni, linux-kernel, stable, yana06070
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 11 Nov 2026 19:32:13 +0800 you wrote:
> mhi_mbim_newlink() adds the link to mbim->link_list before calling
> register_netdevice(). If registration fails, the caller frees the
> netdev without removing the link, leaving a dangling list entry that
> RCU readers such as mhi_mbim_rx() can access after free.
>
> Register the netdev before adding the link to the list so that failed
> registrations do not publish a link.
>
> [...]
Here is the summary with links:
- [net] net: wwan: mhi_wwan_mbim: fix dangling links on registration failure
https://git.kernel.org/netdev/net-next/c/500da33276f5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-17 12:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-11 11:32 [PATCH net] net: wwan: mhi_wwan_mbim: fix dangling links on registration failure Xia Yan
2026-11-17 12:18 ` Paolo Abeni
2026-11-17 12:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox