Re: [PATCH v4 1/3] drm/drm_ras: Add drm_ras netlink error event

["Tauro, Riana" <riana.tauro@intel.com>]

On 09-07-2026 14:52, Raag Jadav wrote:
> On Thu, Jul 09, 2026 at 10:45:27AM +0530, Tauro, Riana wrote:
>> On 09-07-2026 01:51, Rodrigo Vivi wrote:
>>> On Tue, Jul 07, 2026 at 12:02:11PM +0530, Tauro, Riana wrote:
>>>> Hi Rodrigo/Jakub/Aravind
>>>>
>>>> Please let me know if you have any feedback for this patch or can you please
>>>> ack this if it looks good to you.
>>> I looks good to me, but could you please double check the sashiko's comments?
>> Sashiko has a comment regarding namespaces
>>
>> [Severity: Medium]Since the generic netlink family explicitly supports
>> multiple networknamespaces by setting .netnsok = true,
>>   will hardcoding init_net hereprevent listeners in non-init namespaces from
>> receiving error events
>>
>> .netnsok = true is auto generated not explicitly added in code.
> Because that's what ynl_gen_c.py does without it being parsed from
> anywhere.
>
>> But from what i see, drm device is present in the host and not replicated
>> across namespaces
>> and most of the non-network implementations use inet.  (ex: Binder)
>> If this really needs a fix, we can drop the has_listeners suggested by raag
>> in previous patch.
>> I don't think in an error path, allocating a new buffer would be a big
>> overhead if listeners are not present.
> I don't know enough about namespaces to comment on this. I'll rely on
> Jakub's disposition if netnsok is relevant here, or needed at all for
> our usecase.


I tried to find out more about network namespaces.  Network namespaces 
are created everytime docker is run without --network host.
With this patch, event notifications are not received in docker env 
though other commands work correctly.

Since this is a valid usecase for drm, removing has_listeners as it is a 
small overhead in error path and replacing genlmsg_multicast with
genlmsg_multicast_allns.

Thanks
Riana


>
> Raag