From: ebiederm@xmission.com (Eric W. Biederman)
To: Daniel Lezcano <dlezcano@fr.ibm.com>
Cc: davem@davemloft.net, containers@lists.osdl.org, netdev@vger.kernel.org
Subject: Re: [patch 1/1][IPV6] resend: remove duplicate call to proc_net_remove
Date: Tue, 30 Oct 2007 14:53:53 -0600 [thread overview]
Message-ID: <m1k5p4l3xa.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20071030162450.257974469@mai.toulouse-stg.fr.ibm.com> (Daniel Lezcano's message of "Tue, 30 Oct 2007 17:23:45 +0100")
Daniel Lezcano <dlezcano@fr.ibm.com> writes:
> The file /proc/net/if_inet6 is removed twice.
> First time in:
> inet6_exit
> ->addrconf_cleanup
> And followed a few lines after by:
> inet6_exit
> -> if6_proc_exit
>
> Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Looks like a good clean up to me.
> ---
> net/ipv6/addrconf.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> Index: net-2.6/net/ipv6/addrconf.c
> ===================================================================
> --- net-2.6.orig/net/ipv6/addrconf.c
> +++ net-2.6/net/ipv6/addrconf.c
> @@ -4288,8 +4288,4 @@ void __exit addrconf_cleanup(void)
> del_timer(&addr_chk_timer);
>
> rtnl_unlock();
> -
> -#ifdef CONFIG_PROC_FS
> - proc_net_remove(&init_net, "if_inet6");
> -#endif
> }
>
> --
next prev parent reply other threads:[~2007-10-30 20:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071030162344.297260466@mai.toulouse-stg.fr.ibm.com>
2007-10-30 16:23 ` [patch 1/1][IPV6] resend: remove duplicate call to proc_net_remove Daniel Lezcano
2007-10-30 20:53 ` Eric W. Biederman [this message]
2007-10-30 22:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1k5p4l3xa.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=dlezcano@fr.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox