* [patch 1/1][IPV6] resend: remove duplicate call to proc_net_remove
[not found] <20071030162344.297260466@mai.toulouse-stg.fr.ibm.com>
@ 2007-10-30 16:23 ` Daniel Lezcano
2007-10-30 20:53 ` Eric W. Biederman
2007-10-30 22:39 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Daniel Lezcano @ 2007-10-30 16:23 UTC (permalink / raw)
To: davem, ebiederm; +Cc: containers, netdev
[-- Attachment #1: fix-proc-net-remove-called-twice.patch --]
[-- Type: text/plain, Size: 680 bytes --]
The file /proc/net/if_inet6 is removed twice.
First time in:
inet6_exit
->addrconf_cleanup
And followed a few lines after by:
inet6_exit
-> if6_proc_exit
Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
---
net/ipv6/addrconf.c | 4 ----
1 file changed, 4 deletions(-)
Index: net-2.6/net/ipv6/addrconf.c
===================================================================
--- net-2.6.orig/net/ipv6/addrconf.c
+++ net-2.6/net/ipv6/addrconf.c
@@ -4288,8 +4288,4 @@ void __exit addrconf_cleanup(void)
del_timer(&addr_chk_timer);
rtnl_unlock();
-
-#ifdef CONFIG_PROC_FS
- proc_net_remove(&init_net, "if_inet6");
-#endif
}
--
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch 1/1][IPV6] resend: remove duplicate call to proc_net_remove
2007-10-30 16:23 ` [patch 1/1][IPV6] resend: remove duplicate call to proc_net_remove Daniel Lezcano
@ 2007-10-30 20:53 ` Eric W. Biederman
2007-10-30 22:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Eric W. Biederman @ 2007-10-30 20:53 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: davem, containers, netdev
Daniel Lezcano <dlezcano@fr.ibm.com> writes:
> The file /proc/net/if_inet6 is removed twice.
> First time in:
> inet6_exit
> ->addrconf_cleanup
> And followed a few lines after by:
> inet6_exit
> -> if6_proc_exit
>
> Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Looks like a good clean up to me.
> ---
> net/ipv6/addrconf.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> Index: net-2.6/net/ipv6/addrconf.c
> ===================================================================
> --- net-2.6.orig/net/ipv6/addrconf.c
> +++ net-2.6/net/ipv6/addrconf.c
> @@ -4288,8 +4288,4 @@ void __exit addrconf_cleanup(void)
> del_timer(&addr_chk_timer);
>
> rtnl_unlock();
> -
> -#ifdef CONFIG_PROC_FS
> - proc_net_remove(&init_net, "if_inet6");
> -#endif
> }
>
> --
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 1/1][IPV6] resend: remove duplicate call to proc_net_remove
2007-10-30 16:23 ` [patch 1/1][IPV6] resend: remove duplicate call to proc_net_remove Daniel Lezcano
2007-10-30 20:53 ` Eric W. Biederman
@ 2007-10-30 22:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2007-10-30 22:39 UTC (permalink / raw)
To: dlezcano; +Cc: ebiederm, containers, netdev
From: Daniel Lezcano <dlezcano@fr.ibm.com>
Date: Tue, 30 Oct 2007 17:23:45 +0100
> The file /proc/net/if_inet6 is removed twice.
> First time in:
> inet6_exit
> ->addrconf_cleanup
> And followed a few lines after by:
> inet6_exit
> -> if6_proc_exit
>
> Signed-off-by: Daniel Lezcano <dlezcano@fr.ibm.com>
Applied, thanks Daniel.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-30 22:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20071030162344.297260466@mai.toulouse-stg.fr.ibm.com>
2007-10-30 16:23 ` [patch 1/1][IPV6] resend: remove duplicate call to proc_net_remove Daniel Lezcano
2007-10-30 20:53 ` Eric W. Biederman
2007-10-30 22:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox