public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Halasa <khc@pm.waw.pl>
To: "Miguel Ángel Álvarez" <gotzoncabanes@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: qmgr for ixp4xx
Date: Thu, 04 Dec 2008 22:06:21 +0100	[thread overview]
Message-ID: <m3zljby7jm.fsf@maximus.localdomain> (raw)
In-Reply-To: <b0438a630812021044q31845224s206f3998423289af@mail.gmail.com> ("Miguel Ángel Álvarez"'s message of "Tue\, 2 Dec 2008 19\:44\:40 +0100")

"Miguel Ángel Álvarez" <gotzoncabanes@gmail.com> writes:

> As I am trying to use my HSSs as 4E1, I find that the FIFOs for each
> HDLC should be 1 word wide and not 4 words wide. I think that this
> finally means that when accessing the queues, I have to do the
> following modification.
>
> +++ linux-2.6.26.7/include/asm-arm/arch-ixp4xx/qmgr.h	2008-12-02
> 10:47:23.000000000 +0100
> @@ -67,16 +67,17 @@
>  void qmgr_release_queue(unsigned int queue);
>
>
> -static inline void qmgr_put_entry(unsigned int queue, u32 val)
> +static inline void qmgr_put_entry(unsigned int queue, unsigned int pipe,
> +                   u32 val)
>  {
>  	extern struct qmgr_regs __iomem *qmgr_regs;
> -	__raw_writel(val, &qmgr_regs->acc[queue][0]);
> +	__raw_writel(val, &qmgr_regs->acc[queue][pipe]);
>  }
>
> -static inline u32 qmgr_get_entry(unsigned int queue)
> +static inline u32 qmgr_get_entry(unsigned int queue, unsigned int pipe)
>  {
>  	extern struct qmgr_regs __iomem *qmgr_regs;
> -	return __raw_readl(&qmgr_regs->acc[queue][0]);
> +	return __raw_readl(&qmgr_regs->acc[queue][pipe]);
>  }

The FIFOs are some internal property of HDLC controller (it isn't
documented but they probably connect the bus master DMA controller to
the bit-stuffer and transmitter (and bit-destuffer and receiver in the
RX path)). You just need to send a message to HSS to tell it the
correct value.

Queues, on the other hand, can be 1, 2 or 4-words wide (32, 64 or 128
bits). I think nothing uses/needs 2 or 4-word queues so they aren't
implemented.

4E1 mode uses the same 1-word queues. It just uses more queues :-)
-- 
Krzysztof Halasa

  reply	other threads:[~2008-12-04 21:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-02 18:44 qmgr for ixp4xx Miguel Ángel Álvarez
2008-12-04 21:06 ` Krzysztof Halasa [this message]
2008-12-05  8:51   ` Miguel Ángel Álvarez
2008-12-05 16:03     ` Krzysztof Halasa
2008-12-05 16:59       ` Miguel Ángel Álvarez
2008-12-05 18:29         ` Krzysztof Halasa
2008-12-09  9:48           ` Miguel Ángel Álvarez
2008-12-10  0:56             ` Krzysztof Halasa
2008-12-10  9:04               ` Miguel Ángel Álvarez
2008-12-10 16:32                 ` Miguel Ángel Álvarez
2008-12-09 16:44           ` Christian Hohnstaedt
2008-12-10  8:48             ` Miguel Ángel Álvarez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3zljby7jm.fsf@maximus.localdomain \
    --to=khc@pm.waw.pl \
    --cc=gotzoncabanes@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox