* ¸¸18¼¼ ÀÌ»óÀ̸鴩±¸³ª Ãëµæ°¡´É"¾à¿ë½Ä¹°°ü¸®»ç"·Î¹Ì·¡¸¦ ÁغñÇϼ¼¿ä! jc
From: Timothy Daniel @ 2005-08-12 20:10 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/html, Size: 822 bytes --]
^ permalink raw reply
* (unknown),
From: ¸ôīŽÁö±â @ 2005-08-12 19:56 UTC (permalink / raw)
To: linux-xfs
[-- Attachment #1: Type: text/html, Size: 1364 bytes --]
^ permalink raw reply
* ½ºÅ¸Å©·¡ÇÁÆ® Á¤º¹!!ÇÁ·Î°ÔÀ̸ÓÀÇÁö¸§±æ!!
From: ±è¼±¾Æ @ 2005-08-12 19:43 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/html, Size: 1362 bytes --]
^ permalink raw reply
* Penis enhancement patch, doctor approved and recommended.
From: Mortimer @ 2005-08-12 19:40 UTC (permalink / raw)
To: netdev
ADD 3+ inches today - don't get left behind
http://www.nelema.com/pt/?9&locate
Patriotism is the willingness to kill and be killed for trivial reasons.
The biggest shortage of all is the shortage of common sense.
My mother buried three husbands, and two of them were just napping.
A patient man is one who can put up with himself.
When the eagles are silent, the parrots begin to jabber.
^ permalink raw reply
* Re: [PATCH 0/8] netpoll: various bugfixes
From: Olaf Hering @ 2005-08-12 19:31 UTC (permalink / raw)
To: Matt Mackall
Cc: Andrew Morton, David S. Miller, ak, Jeff Moyer, netdev,
linux-kernel, mingo, john.ronciak, rostedt
In-Reply-To: <20050812192152.GJ12284@waste.org>
On Fri, Aug 12, Matt Mackall wrote:
> Does the task dump work without patch 5/8 (add retry timeout)? I'll
> try testing it here.
I spoke to soon, worked once, after reboot not anymore. Will try to play
with individual patches. Does the task dump work for you, at least?
^ permalink raw reply
* COACH¥þ°ê³Ì¤j½æ³õ
From: COACH±M½æ©± @ 2005-08-12 19:27 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/plain, Size: 15 bytes --]
%MAKE_TXT[3-6]
[-- Attachment #2: Type: text/html, Size: 3064 bytes --]
^ permalink raw reply
* Re: [PATCH 0/8] netpoll: various bugfixes
From: Matt Mackall @ 2005-08-12 19:21 UTC (permalink / raw)
To: Olaf Hering
Cc: Andrew Morton, David S. Miller, ak, Jeff Moyer, netdev,
linux-kernel, mingo, john.ronciak, rostedt
In-Reply-To: <20050812172151.GA11104@suse.de>
[corrected akpm's address]
On Fri, Aug 12, 2005 at 07:21:51PM +0200, Olaf Hering wrote:
> On Thu, Aug 11, Matt Mackall wrote:
>
> > This patch series cleans up a few outstanding bugs in netpoll:
> >
> > - two bugfixes from Jeff Moyer's netpoll bonding
> > - a tweak to e1000's netpoll stub
> > - timeout handling for e1000 with carrier loss
> > - prefilling SKBs at init
> > - a fix-up for a race discovered in initialization
> > - an unused variable warning
>
> Matt, I have tested them, the sender doesnt lockup anymore. But a
> task dump doesnt work, I get only the first task. This is on a 3GHz xeon
> with tg3 card.
Does the task dump work without patch 5/8 (add retry timeout)? I'll
try testing it here.
--
Mathematics is the supreme nostalgia of our time.
^ permalink raw reply
* Re: [PATCH 3/8] netpoll: e1000 netpoll tweak
From: Matt Mackall @ 2005-08-12 19:17 UTC (permalink / raw)
To: John Ronciak
Cc: Andrew Morton, David S. Miller, ak, Jeff Moyer, netdev,
linux-kernel, mingo, john.ronciak, rostedt
In-Reply-To: <56a8daef0508121202172bcd17@mail.gmail.com>
[corrected akpm's address]
On Fri, Aug 12, 2005 at 12:02:03PM -0700, John Ronciak wrote:
> Sorry this reply was to go to the whole list but only made it to Matt.
>
> The e1000_intr() routine already calls e1000_clean_tx_irq(). So
> what's the point of this patch? Am I missing something?
Here is Steven's original analysis:
http://lkml.org/lkml/2005/8/5/116
It looked plausible, but I didn't dig much deeper.
> > Index: l/drivers/net/e1000/e1000_main.c
> > ===================================================================
> > --- l.orig/drivers/net/e1000/e1000_main.c 2005-08-06 17:36:32.000000000 -0500
> > +++ l/drivers/net/e1000/e1000_main.c 2005-08-06 17:55:01.000000000 -0500
> > @@ -3789,6 +3789,7 @@ e1000_netpoll(struct net_device *netdev)
> > struct e1000_adapter *adapter = netdev_priv(netdev);
> > disable_irq(adapter->pdev->irq);
> > e1000_intr(adapter->pdev->irq, netdev, NULL);
> > + e1000_clean_tx_irq(adapter);
> > enable_irq(adapter->pdev->irq);
> > }
> > #endif
--
Mathematics is the supreme nostalgia of our time.
^ permalink raw reply
* ´ëÃâ½ÂÀÎ/Ä«µå´ë³³·ü 100% ÃÖ°í¾÷ü!(½Å¿ëºÒ·®Á¦¿Ü) qzqt
From: opevhzaxnlxcg3530213275 @ 2005-08-12 19:16 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/html, Size: 1074 bytes --]
^ permalink raw reply
* Re: [PATCH 3/8] netpoll: e1000 netpoll tweak
From: David S. Miller @ 2005-08-12 19:10 UTC (permalink / raw)
To: john.ronciak
Cc: mpm, akpm, ak, jmoyer, netdev, linux-kernel, mingo, john.ronciak,
rostedt
In-Reply-To: <56a8daef0508121202172bcd17@mail.gmail.com>
From: John Ronciak <john.ronciak@gmail.com>
Subject: Re: [PATCH 3/8] netpoll: e1000 netpoll tweak
Date: Fri, 12 Aug 2005 12:02:03 -0700
> Sorry this reply was to go to the whole list but only made it to Matt.
>
> The e1000_intr() routine already calls e1000_clean_tx_irq(). So
> what's the point of this patch? Am I missing something?
e1000_intr() does not call e1000_clean_tx_irq() when NAPI
is enabled.
^ permalink raw reply
* Re: [PATCH] add new iptables ipt_connbytes match
From: David S. Miller @ 2005-08-12 19:09 UTC (permalink / raw)
To: laforge; +Cc: netdev, netfilter-devel, kaber, ak
In-Reply-To: <20050812190343.GW18580@rama.de.gnumonks.org>
From: Harald Welte <laforge@netfilter.org>
Date: Fri, 12 Aug 2005 21:03:43 +0200
> Ok, I hope everyone is fine with this patch:
It is, but I did not add the connbytes patch into my tree so I can't
use this patch as-is. That's why I replied "this is broken, fix u64
alignment" to the connbytes patch instead of "applied, thanks" :-)
Please untangle this stuff. This is how we end up with a big mess of
noise changesets in the tree, due to how we have been putting
half-working changes in first then a bunch of "fixup" patches. I'd
like to avoid that, because I then spend a lot of time redoing things
when I rebase the tree later.
So in this case, send me the aligned_u64 patch seperately which
doesn't assume connbytes is in the tree. Then another patch which
adds connbytes with the proper usage of aligned_u64.
Thanks Harald.
^ permalink raw reply
* Re: [PATCH] add new iptables ipt_connbytes match
From: Andi Kleen @ 2005-08-12 19:08 UTC (permalink / raw)
To: Harald Welte, David Miller, Patrick McHardy, netdev,
netfilter-devel, Andi Kleen
In-Reply-To: <20050812190343.GW18580@rama.de.gnumonks.org>
Looks good. Thanks,
-Andi
^ permalink raw reply
* °í°´´Ô 5000¸¸¿ø±îÁö¿ù0.7%´ë·Î ¹«¹æ¹®±ÝÀ¶ÀÌ °¡´ÉÇÕ´Ï´ÙÁï½Ã ½ÅûÇϼ¼¿ä
From: ¸ÂÃã´ëÃâÁ¤º¸ @ 2005-08-12 19:06 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/html, Size: 2957 bytes --]
^ permalink raw reply
* Re: [PATCH] add new iptables ipt_connbytes match
From: Harald Welte @ 2005-08-12 19:03 UTC (permalink / raw)
To: David Miller; +Cc: netdev, netfilter-devel, Patrick McHardy, Andi Kleen
In-Reply-To: <20050812182355.GF22901@wotan.suse.de>
[-- Attachment #1.1: Type: text/plain, Size: 878 bytes --]
On Fri, Aug 12, 2005 at 08:23:55PM +0200, Andi Kleen wrote:
> > I don't think that we're ever going to fix that bug in the old
> > {get,set}sockopt interface, but rather introduce a netlink interface
> > when pkt_tables matures.
>
> All new interfaces should be emulation clean, so that if the old interface
> is replaced later it should eventually work. The best way to do that
> is to use aligned_u64. Should probably put that into linux/types.h
Ok, I hope everyone is fine with this patch:
--
- Harald Welte <laforge@netfilter.org> http://netfilter.org/
============================================================================
"Fragmentation is like classful addressing -- an interesting early
architectural error that shows how much experimentation was going
on while IP was being designed." -- Paul Vixie
[-- Attachment #1.2: 48-aligned_u64.patch --]
[-- Type: text/plain, Size: 3326 bytes --]
[NETFILTER] introduce and use aligned_u64 data type
As proposed by Andi Kleen, this is required esp. for x86_64 architecture,
where 64bit code needs 8byte aligned 64bit data types, but 32bit userspace
apps will only align to 4bytes.
Signed-off-by: Harald Welte <laforge@netfilter.org>
---
commit 30da9a3da187af74b2e2d00becf2d9cab3624ddd
tree 7666f6ce67e96beedc8884f1aba18ea80a20e2b1
parent 7c249f391a3b9bc86ec07d734959c532a3c7a3f6
author Harald Welte <laforge@netfilter.org> Fr, 12 Aug 2005 21:00:28 +0200
committer Harald Welte <laforge@netfilter.org> Fr, 12 Aug 2005 21:00:28 +0200
include/linux/netfilter/nfnetlink_log.h | 5 +++--
include/linux/netfilter/nfnetlink_queue.h | 5 +++--
include/linux/netfilter_ipv4/ipt_connbytes.h | 4 ++--
include/linux/types.h | 3 +++
4 files changed, 11 insertions(+), 6 deletions(-)
diff --git a/include/linux/netfilter/nfnetlink_log.h b/include/linux/netfilter/nfnetlink_log.h
--- a/include/linux/netfilter/nfnetlink_log.h
+++ b/include/linux/netfilter/nfnetlink_log.h
@@ -5,6 +5,7 @@
* and not any kind of function definitions. It is shared between kernel and
* userspace. Don't put kernel specific stuff in here */
+#include <linux/types.h>
#include <linux/netfilter/nfnetlink.h>
enum nfulnl_msg_types {
@@ -27,8 +28,8 @@ struct nfulnl_msg_packet_hw {
} __attribute__ ((packed));
struct nfulnl_msg_packet_timestamp {
- u_int64_t sec;
- u_int64_t usec;
+ aligned_u64 sec;
+ aligned_u64 usec;
} __attribute__ ((packed));
#define NFULNL_PREFIXLEN 30 /* just like old log target */
diff --git a/include/linux/netfilter/nfnetlink_queue.h b/include/linux/netfilter/nfnetlink_queue.h
--- a/include/linux/netfilter/nfnetlink_queue.h
+++ b/include/linux/netfilter/nfnetlink_queue.h
@@ -1,6 +1,7 @@
#ifndef _NFNETLINK_QUEUE_H
#define _NFNETLINK_QUEUE_H
+#include <linux/types.h>
#include <linux/netfilter/nfnetlink.h>
enum nfqnl_msg_types {
@@ -24,8 +25,8 @@ struct nfqnl_msg_packet_hw {
} __attribute__ ((packed));
struct nfqnl_msg_packet_timestamp {
- u_int64_t sec;
- u_int64_t usec;
+ aligned_u64 sec;
+ aligned_u64 usec;
} __attribute__ ((packed));
enum nfqnl_attr_type {
diff --git a/include/linux/netfilter_ipv4/ipt_connbytes.h b/include/linux/netfilter_ipv4/ipt_connbytes.h
--- a/include/linux/netfilter_ipv4/ipt_connbytes.h
+++ b/include/linux/netfilter_ipv4/ipt_connbytes.h
@@ -16,8 +16,8 @@ enum ipt_connbytes_direction {
struct ipt_connbytes_info
{
struct {
- u_int64_t from; /* count to be matched */
- u_int64_t to; /* count to be matched */
+ aligned_u64 from; /* count to be matched */
+ aligned_u64 to; /* count to be matched */
} count;
u_int8_t what; /* ipt_connbytes_what */
u_int8_t direction; /* ipt_connbytes_direction */
diff --git a/include/linux/types.h b/include/linux/types.h
--- a/include/linux/types.h
+++ b/include/linux/types.h
@@ -123,6 +123,9 @@ typedef __u64 u_int64_t;
typedef __s64 int64_t;
#endif
+/* this is a special 64bit data type that is 8-byte aligned */
+#define aligned_u64 unsigned long long __attribute__((aligned(8)))
+
/*
* The type used for indexing onto a disc or disc partition.
* If required, asm/types.h can override it and define
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply
* Re: [PATCH 3/8] netpoll: e1000 netpoll tweak
From: John Ronciak @ 2005-08-12 19:02 UTC (permalink / raw)
To: Matt Mackall
Cc: Andrew Morton, David S. Miller, ak, Jeff Moyer, netdev,
linux-kernel, mingo, john.ronciak, rostedt
In-Reply-To: <4.502409567@selenic.com>
Sorry this reply was to go to the whole list but only made it to Matt.
The e1000_intr() routine already calls e1000_clean_tx_irq(). So
what's the point of this patch? Am I missing something?
On 8/11/05, Matt Mackall <mpm@selenic.com> wrote:
> Suggested by Steven Rostedt, matches his patch included in e100.
>
> Signed-off-by: Matt Mackall <mpm@selenic.com>
>
> Index: l/drivers/net/e1000/e1000_main.c
> ===================================================================
> --- l.orig/drivers/net/e1000/e1000_main.c 2005-08-06 17:36:32.000000000 -0500
> +++ l/drivers/net/e1000/e1000_main.c 2005-08-06 17:55:01.000000000 -0500
> @@ -3789,6 +3789,7 @@ e1000_netpoll(struct net_device *netdev)
> struct e1000_adapter *adapter = netdev_priv(netdev);
> disable_irq(adapter->pdev->irq);
> e1000_intr(adapter->pdev->irq, netdev, NULL);
> + e1000_clean_tx_irq(adapter);
> enable_irq(adapter->pdev->irq);
> }
> #endif
>
>
--
Cheers,
John
^ permalink raw reply
* Extra Time - Last 5-10 times longer
From: Courtney Christensen @ 2005-08-12 18:52 UTC (permalink / raw)
To: netdev, netdev-bounce
Hello,
Did you ejaculate before or within a few minutes of
penetration?
Premature ejaculation occurs when you ejaculate too quickly
and without control. It occurs before or shortly after
penetration. Premature ejaculation interferes with the sexual
pleasure of both you and your partner. It causes feelings of
guilt, embarrassment, frustration, and depression.
Extra-Time is the only male sexual performance formula that,
not only stops premature ejaculation, but actually "cures" it.
Extra-Time is the only product that allows "YOU" to control
when you ejaculate.
- Non-hormonal herbal therapy.
- Acts locally on the sex organs.
- Regulates process of ejaculation.
- Acts through neuro-endocrine pathway.
- Acts on the high centers of emotion in the brain.
Look here: http://modelled.net/et/?meds
No thanks: http://modelled.net/rr.php
^ permalink raw reply
* Re: Strange uses of netif_start_queue
From: Thomas Graf @ 2005-08-12 18:46 UTC (permalink / raw)
To: David S. Miller; +Cc: alan, netdev
In-Reply-To: <20050812.110034.63126875.davem@davemloft.net>
* David S. Miller <20050812.110034.63126875.davem@davemloft.net> 2005-08-12 11:00
> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Date: Fri, 12 Aug 2005 14:35:14 +0100
>
> > Something I noticed doing the tty work. the 6pack driver calls
> > netif_start_queue() before it calls register_netdev. I'm curious if this
> > is allowed ?
>
> It's definitely a bug, and when register_netdev() happens it will
> just overwrite that change of state.
>
> Since the queue is not initialized yet, this could also cause
> a crash or hang. :-)
Hmm, maybe I got something wrong but:
As you say correctly, there is no way we can queue packets until
the device has been put up, a device cannot be put up while it is
not present but that doesn't happen before register_netdevice()
so the value of the queue bit doesn't matter at all. Actually the
default state is indeed to have the queue running (bit set to 0)
so the mentioned netif_start_queue() is a simple nop as Patrick
noted already. It will _not_ be overwritten by a call to
register_netdevice() though which is a good thing: It allows the
queue to be stopped from the very beginning without a race between
register_netdevice() and the call to netif_stop_queue().
^ permalink raw reply
* ¡º Á¦1ȸ »çȸº¹Áö»ç¡»º¸°Çº¹ÁöºÎÁÖ°ü(º¹ÁöºÐ¾ßÀǾ÷¹«ÆøÁÖ + Ãë¾÷99.9%)
From: Á¦1ȸ @ 2005-08-12 18:44 UTC (permalink / raw)
To: cvs
[-- Attachment #1: Type: text/html, Size: 2542 bytes --]
^ permalink raw reply
* °í°´´Ô ¾î¶°ÇÑÁ¶°Ç¿¡µµ´ëÃâÇص帳´Ï´Ù. zjeieqh
From: fqmfpglxlarnb3111638188 @ 2005-08-12 18:27 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/html, Size: 1004 bytes --]
^ permalink raw reply
* Re: [PATCH] add new iptables ipt_connbytes match
From: Andi Kleen @ 2005-08-12 18:23 UTC (permalink / raw)
To: Harald Welte, Andi Kleen, Patrick McHardy, David S. Miller,
netdev, netfilter-devel
In-Reply-To: <20050812153730.GR18580@rama.de.gnumonks.org>
> I don't think that we're ever going to fix that bug in the old
> {get,set}sockopt interface, but rather introduce a netlink interface
> when pkt_tables matures.
All new interfaces should be emulation clean, so that if the old interface
is replaced later it should eventually work. The best way to do that
is to use aligned_u64. Should probably put that into linux/types.h
-Andi
^ permalink raw reply
* 8月27-28日/上海 9月3-4日/北京
From: ²ÆÎñ¹ÜÀí(ɳÅÌÄ£Äâ)¿Î³Ì @ 2005-08-12 18:23 UTC (permalink / raw)
To: majordomo@oss.sgi.com
[-- Attachment #1.1: Type: text/html, Size: 7825 bytes --]
^ permalink raw reply
* ¡ØÇö´ëÀÎÀÇÇʼöÇ°:·¹ÀÌÀúºÒºûÀ̳ª¿À´Â Áö½ÃºÀÈÄ·¹½¬ ¸¸´Éº¼Ææ
From: ÇʼöÇ° @ 2005-08-12 18:22 UTC (permalink / raw)
To: kdb
[-- Attachment #1: Type: text/html, Size: 1305 bytes --]
^ permalink raw reply
* ¡ØÇö´ëÀÎÀÇÇʼöÇ°:·¹ÀÌÀúºÒºûÀ̳ª¿À´Â Áö½ÃºÀÈÄ·¹½¬ ¸¸´Éº¼Ææ
From: ÇʼöÇ° @ 2005-08-12 18:20 UTC (permalink / raw)
To: kdb
[-- Attachment #1: Type: text/html, Size: 1305 bytes --]
^ permalink raw reply
* ³ôÀº ´ëÃâ±Ý¸®·Î°ÆÁ¤ÇϽôøºÐµé´ëÃâ±Ý¸® Ä¿Ç°À»»°½À´Ï´Ù.
From: ÀºÇà±Ý¸®´ëÃâ @ 2005-08-12 18:18 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/html, Size: 590 bytes --]
^ permalink raw reply
* ¥x·s»È¦æ±À¥X1.99%§C§Q¥d¥NÀv,¥un¦³¤u§@,«ù¥dº¡¥b¦~§Y¥i¿ì²z...
From: auux @ 2005-08-12 18:17 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/plain, Size: 26 bytes --]
請切換超文本（HTML）格式
[-- Attachment #2: Type: text/html, Size: 5095 bytes --]
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox