* Re: [bisected] Wireless regression in 2.6.32-git
From: Maciej Rutecki @ 2009-09-27 13:24 UTC (permalink / raw)
To: Arjan van de Ven; +Cc: netdev, linux-kernel, linux-wireless
In-Reply-To: <20090927151855.29efcc53@infradead.org>
Did You have similar messages in dmesg like this:
http://bugzilla.intellinuxwireless.org/show_bug.cgi?id=2089
(use WPA)
?
I try make sure, that that result of my bisection is correct.
--
Maciej Rutecki
http://www.maciek.unixy.pl
^ permalink raw reply
* Re: [bisected] Wireless regression in 2.6.32-git
From: Arjan van de Ven @ 2009-09-27 13:32 UTC (permalink / raw)
To: Maciej Rutecki
Cc: netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <8db1092f0909270624l4fc46734u6a91f7cc7ffb0c72-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Sun, 27 Sep 2009 15:24:10 +0200
Maciej Rutecki <maciej.rutecki-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Did You have similar messages in dmesg like this:
>
> http://bugzilla.intellinuxwireless.org/show_bug.cgi?id=2089
> (use WPA)
nope I don't get a Reason 6 disconnect...
(I get a reason 3 local choice, but that's true for working and
non-working both)
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [2.6.31-git17] WARNING: at kernel/hrtimer.c:648 hres_timers_resume+0x40/0x50()/WARNING: at drivers/base/sys.c:353 __sysdev_resume+0xc3/0xe0()
From: Yong Zhang @ 2009-09-27 14:49 UTC (permalink / raw)
To: Maciej Rutecki
Cc: Linux Kernel Mailing List, Rafael J. Wysocki, clemens,
venkatesh.pallipadi, gregkh, zambrano, davem, netdev
In-Reply-To: <2674af740909270701u6febabdbpc5c772fabc193b32@mail.gmail.com>
Add cc'ed.
On Sun, Sep 27, 2009 at 10:01 PM, Yong Zhang <yong.zhang0@gmail.com> wrote:
> On Sun, Sep 27, 2009 at 6:25 PM, Maciej Rutecki
> <maciej.rutecki@gmail.com> wrote:
>> 2009/9/27 Yong Zhang <yong.zhang0@gmail.com>:
>>>
>>> Oops, TABLE is corrupted. Please use the attachment.
>>
>> kernel/time/timekeeping.c: In function ‘timekeeping_resume’:
>> kernel/time/timekeeping.c:577: error: ‘xtime_locks’ undeclared (first
>> use in this function)
>> kernel/time/timekeeping.c:577: error: (Each undeclared identifier is
>> reported only once
>> kernel/time/timekeeping.c:577: error: for each function it appears
>> in.)
>> make[3]: *** [kernel/time/timekeeping.o] Błąd 1
>> make[2]: *** [kernel/time] Błąd 2
>>
>>
>> I change:
>> write_seqlock(&xtime_locks);
>> to:
>> write_seqlock(&xtime_lock);
>>
>
> Oh, typo error.
>
>> Corrected patch in attachment.
>>
>> First warning has gone, but still I have this:
>> [ 120.868049] SMP alternatives: switching to UP code
>> [ 120.872570] CPU0 attaching NULL sched-domain.
>> [ 120.872574] CPU1 attaching NULL sched-domain.
>> [ 120.872581] CPU0 attaching NULL sched-domain.
>> [ 120.872787] CPU1 is down
>> [ 120.872846] Extended CMOS year: 2000
>> [ 120.872945] PM: Creating hibernation image:
>> [ 120.876009] PM: Need to copy 107120 pages
>> [ 120.872009] PM: Restoring platform NVS memory
>> [ 120.872009] CPU0: Thermal monitoring handled by SMI
>> [ 120.872009] Extended CMOS year: 2000
>> [ 120.872009] ------------[ cut here ]------------
>> [ 120.872009] WARNING: at drivers/base/sys.c:353
>> __sysdev_resume+0xc3/0xe0()
>> [ 120.872009] Hardware name: HP Compaq nx6310 (EY501ES#AKD)
>> [ 120.872009] Interrupts enabled after timekeeping_resume+0x0/0x1c0
>
> Irq is enabled after timekeeping_resume(), the previous patch do something
> sensible. But we even don't know when the irq is enabled. such as in
> timekeeping_resume() or before enter timekeeping_resume(). But it
> seem that this is not due to timekeeping_resume(). Instead I'm afraid
> it's caused by buggy driver.
>
It seem this is cause by b44 dirver. Can you give a try?
From 05ee2f22a7ea065e05bf8b5294d222a3700d2cc8 Mon Sep 17 00:00:00 2001
From: Yong Zhang <yong.zhang0@gmail.com>
Date: Sun, 27 Sep 2009 22:42:41 +0800
Subject: [PATCH] net/b44: keep irq state at suspend_resume
suspend() and resume() assume irq is disabled. So keep the irq
state when do this.
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
---
drivers/net/b44.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/b44.c b/drivers/net/b44.c
index e046943..97b467f 100644
--- a/drivers/net/b44.c
+++ b/drivers/net/b44.c
@@ -2258,20 +2258,21 @@ static int b44_suspend(struct ssb_device
*sdev, pm_message_t state)
{
struct net_device *dev = ssb_get_drvdata(sdev);
struct b44 *bp = netdev_priv(dev);
+ unsigned long flags;
if (!netif_running(dev))
return 0;
del_timer_sync(&bp->timer);
- spin_lock_irq(&bp->lock);
+ spin_lock_irqsave(&bp->lock, flags);
b44_halt(bp);
netif_carrier_off(bp->dev);
netif_device_detach(bp->dev);
b44_free_rings(bp);
- spin_unlock_irq(&bp->lock);
+ spin_unlock_irqrestore(&bp->lock, flags);
free_irq(dev->irq, dev);
if (bp->flags & B44_FLAG_WOL_ENABLE) {
@@ -2288,6 +2289,7 @@ static int b44_resume(struct ssb_device *sdev)
struct net_device *dev = ssb_get_drvdata(sdev);
struct b44 *bp = netdev_priv(dev);
int rc = 0;
+ unsigned long flags;
rc = ssb_bus_powerup(sdev->bus, 0);
if (rc) {
@@ -2305,12 +2307,12 @@ static int b44_resume(struct ssb_device *sdev)
return rc;
}
- spin_lock_irq(&bp->lock);
+ spin_lock_irqsave(&bp->lock, flags);
b44_init_rings(bp);
b44_init_hw(bp, B44_FULL_RESET);
netif_device_attach(bp->dev);
- spin_unlock_irq(&bp->lock);
+ spin_unlock_irqrestore(&bp->lock, flags);
b44_enable_ints(bp);
netif_wake_queue(dev);
--
1.6.0.4
> So can you test the follow patch. And show the dmesg info(DEBUG
> level) after WARNING is triggered?
>
> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> index fb0f46f..4a00a1a 100644
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -569,6 +569,9 @@ static int timekeeping_resume(struct sys_device *dev)
> unsigned long flags;
> struct timespec ts;
>
> + WARN_ONCE(!irqs_disabled(),
> + KERN_INFO "timekeeping_resume() called with IRQs enabled!");
> +
> read_persistent_clock(&ts);
>
> clocksource_resume();
>
> Thanks,
> Yong
>
>> [ 120.872009] Modules linked in: i915 drm_kms_helper drm i2c_algo_bit
>> i2c_core sco bnep rfcomm l2cap crc16 xt_tcpudp xt_limit xt_state
>> iptable_filter nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 ip_tables
>> x_tables aes_i586 aes_generic cbc dm_crypt dm_snapshot dm_mirror
>> dm_region_hash dm_log dm_mod hp_wmi fuse sbp2 loop
>> snd_hda_codec_si3054 snd_hda_codec_analog snd_hda_intel snd_hda_codec
>> snd_pcm_oss snd_mixer_oss snd_pcm snd_seq_dummy arc4 snd_seq_oss ecb
>> snd_seq_midi snd_rawmidi iwl3945 snd_seq_midi_event iwlcore btusb
>> firmware_class snd_seq bluetooth snd_timer mac80211 pcmcia
>> snd_seq_device led_class b44 video ohci1394 backlight ssb rtc_cmos snd
>> yenta_socket cfg80211 intel_agp soundcore rsrc_nonstatic uhci_hcd
>> ehci_hcd rtc_core usbcore psmouse snd_page_alloc agpgart pcmcia_core
>> rfkill rtc_lib ieee1394 sg output evdev serio_raw mii fan button ac
>> battery
>> [ 120.872009] Pid: 3510, comm: pm-hibernate Not tainted 2.6.31-git17
>> #1
>> [ 120.872009] Call Trace:
>> [ 120.872009] [<c030f4a3>] ? __sysdev_resume+0xc3/0xe0
>> [ 120.872009] [<c030f4a3>] ? __sysdev_resume+0xc3/0xe0
>> [ 120.872009] [<c013c3a1>] warn_slowpath_common+0x71/0xc0
>> [ 120.872009] [<c030f4a3>] ? __sysdev_resume+0xc3/0xe0
>> [ 120.872009] [<c013c43b>] warn_slowpath_fmt+0x2b/0x30
>> [ 120.872009] [<c030f4a3>] __sysdev_resume+0xc3/0xe0
>> [ 120.872009] [<c015f810>] ? timekeeping_resume+0x0/0x1c0
>> [ 120.872009] [<c030f50f>] sysdev_resume+0x4f/0xc0
>> [ 120.872009] [<c0176909>] ? hibernate_nvs_restore+0x19/0x60
>> [ 120.872009] [<c0172ac1>] hibernation_snapshot+0x1d1/0x210
>> [ 120.872009] [<c0171b54>] ? freeze_processes+0x44/0xa0
>> [ 120.872009] [<c0172bef>] hibernate+0xef/0x190
>> [ 120.872009] [<c0171590>] ? state_store+0x0/0xc0
>> [ 120.872009] [<c017163b>] state_store+0xab/0xc0
>> [ 120.872009] [<c0171590>] ? state_store+0x0/0xc0
>> [ 120.872009] [<c0285e04>] kobj_attr_store+0x24/0x30
>> [ 120.872009] [<c0223d82>] sysfs_write_file+0xa2/0x100
>> [ 120.872009] [<c01d880c>] vfs_write+0x9c/0x150
>> [ 120.872009] [<c0223ce0>] ? sysfs_write_file+0x0/0x100
>> [ 120.872009] [<c01d8982>] sys_write+0x42/0x70
>> [ 120.872009] [<c0102f04>] sysenter_do_call+0x12/0x22
>> [ 120.872009] ---[ end trace 51d3cc987b340170 ]---
>> [ 120.872009] Enabling non-boot CPUs ...
>> [ 120.872009] SMP alternatives: switching to SMP code
>>
>> Regards
>> --
>> Maciej Rutecki
>> http://www.maciek.unixy.pl
>>
>
^ permalink raw reply related
* Re: [2.6.31-git17] WARNING: at kernel/hrtimer.c:648 hres_timers_resume+0x40/0x50()/WARNING: at drivers/base/sys.c:353 __sysdev_resume+0xc3/0xe0()
From: Rafael J. Wysocki @ 2009-09-27 15:40 UTC (permalink / raw)
To: Yong Zhang
Cc: Maciej Rutecki, Linux Kernel Mailing List, clemens,
venkatesh.pallipadi, gregkh, zambrano, davem, netdev
In-Reply-To: <2674af740909270749u339671a1ia81d5736eeb750fa@mail.gmail.com>
On Sunday 27 September 2009, Yong Zhang wrote:
> Add cc'ed.
>
> On Sun, Sep 27, 2009 at 10:01 PM, Yong Zhang <yong.zhang0@gmail.com> wrote:
> > On Sun, Sep 27, 2009 at 6:25 PM, Maciej Rutecki
> > <maciej.rutecki@gmail.com> wrote:
> >> 2009/9/27 Yong Zhang <yong.zhang0@gmail.com>:
> >>>
> >>> Oops, TABLE is corrupted. Please use the attachment.
> >>
> >> kernel/time/timekeeping.c: In function ‘timekeeping_resume’:
> >> kernel/time/timekeeping.c:577: error: ‘xtime_locks’ undeclared (first
> >> use in this function)
> >> kernel/time/timekeeping.c:577: error: (Each undeclared identifier is
> >> reported only once
> >> kernel/time/timekeeping.c:577: error: for each function it appears
> >> in.)
> >> make[3]: *** [kernel/time/timekeeping.o] Błąd 1
> >> make[2]: *** [kernel/time] Błąd 2
> >>
> >>
> >> I change:
> >> write_seqlock(&xtime_locks);
> >> to:
> >> write_seqlock(&xtime_lock);
> >>
> >
> > Oh, typo error.
> >
> >> Corrected patch in attachment.
> >>
> >> First warning has gone, but still I have this:
> >> [ 120.868049] SMP alternatives: switching to UP code
> >> [ 120.872570] CPU0 attaching NULL sched-domain.
> >> [ 120.872574] CPU1 attaching NULL sched-domain.
> >> [ 120.872581] CPU0 attaching NULL sched-domain.
> >> [ 120.872787] CPU1 is down
> >> [ 120.872846] Extended CMOS year: 2000
> >> [ 120.872945] PM: Creating hibernation image:
> >> [ 120.876009] PM: Need to copy 107120 pages
> >> [ 120.872009] PM: Restoring platform NVS memory
> >> [ 120.872009] CPU0: Thermal monitoring handled by SMI
> >> [ 120.872009] Extended CMOS year: 2000
> >> [ 120.872009] ------------[ cut here ]------------
> >> [ 120.872009] WARNING: at drivers/base/sys.c:353
> >> __sysdev_resume+0xc3/0xe0()
> >> [ 120.872009] Hardware name: HP Compaq nx6310 (EY501ES#AKD)
> >> [ 120.872009] Interrupts enabled after timekeeping_resume+0x0/0x1c0
> >
> > Irq is enabled after timekeeping_resume(), the previous patch do something
> > sensible. But we even don't know when the irq is enabled. such as in
> > timekeeping_resume() or before enter timekeeping_resume(). But it
> > seem that this is not due to timekeeping_resume(). Instead I'm afraid
> > it's caused by buggy driver.
> >
>
> It seem this is cause by b44 dirver. Can you give a try?
>
> From 05ee2f22a7ea065e05bf8b5294d222a3700d2cc8 Mon Sep 17 00:00:00 2001
> From: Yong Zhang <yong.zhang0@gmail.com>
> Date: Sun, 27 Sep 2009 22:42:41 +0800
> Subject: [PATCH] net/b44: keep irq state at suspend_resume
>
> suspend() and resume() assume irq is disabled.
No, it doesn't.
Thanks,
Rafael
> So keep the irq state when do this.
>
> Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
> ---
> drivers/net/b44.c | 10 ++++++----
> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/b44.c b/drivers/net/b44.c
> index e046943..97b467f 100644
> --- a/drivers/net/b44.c
> +++ b/drivers/net/b44.c
> @@ -2258,20 +2258,21 @@ static int b44_suspend(struct ssb_device
> *sdev, pm_message_t state)
> {
> struct net_device *dev = ssb_get_drvdata(sdev);
> struct b44 *bp = netdev_priv(dev);
> + unsigned long flags;
>
> if (!netif_running(dev))
> return 0;
>
> del_timer_sync(&bp->timer);
>
> - spin_lock_irq(&bp->lock);
> + spin_lock_irqsave(&bp->lock, flags);
>
> b44_halt(bp);
> netif_carrier_off(bp->dev);
> netif_device_detach(bp->dev);
> b44_free_rings(bp);
>
> - spin_unlock_irq(&bp->lock);
> + spin_unlock_irqrestore(&bp->lock, flags);
>
> free_irq(dev->irq, dev);
> if (bp->flags & B44_FLAG_WOL_ENABLE) {
> @@ -2288,6 +2289,7 @@ static int b44_resume(struct ssb_device *sdev)
> struct net_device *dev = ssb_get_drvdata(sdev);
> struct b44 *bp = netdev_priv(dev);
> int rc = 0;
> + unsigned long flags;
>
> rc = ssb_bus_powerup(sdev->bus, 0);
> if (rc) {
> @@ -2305,12 +2307,12 @@ static int b44_resume(struct ssb_device *sdev)
> return rc;
> }
>
> - spin_lock_irq(&bp->lock);
> + spin_lock_irqsave(&bp->lock, flags);
>
> b44_init_rings(bp);
> b44_init_hw(bp, B44_FULL_RESET);
> netif_device_attach(bp->dev);
> - spin_unlock_irq(&bp->lock);
> + spin_unlock_irqrestore(&bp->lock, flags);
>
> b44_enable_ints(bp);
> netif_wake_queue(dev);
> > So can you test the follow patch. And show the dmesg info(DEBUG
> > level) after WARNING is triggered?
> >
> > diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
> > index fb0f46f..4a00a1a 100644
> > --- a/kernel/time/timekeeping.c
> > +++ b/kernel/time/timekeeping.c
> > @@ -569,6 +569,9 @@ static int timekeeping_resume(struct sys_device *dev)
> > unsigned long flags;
> > struct timespec ts;
> >
> > + WARN_ONCE(!irqs_disabled(),
> > + KERN_INFO "timekeeping_resume() called with IRQs enabled!");
> > +
> > read_persistent_clock(&ts);
> >
> > clocksource_resume();
> >
> > Thanks,
> > Yong
> >
> >> [ 120.872009] Modules linked in: i915 drm_kms_helper drm i2c_algo_bit
> >> i2c_core sco bnep rfcomm l2cap crc16 xt_tcpudp xt_limit xt_state
> >> iptable_filter nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 ip_tables
> >> x_tables aes_i586 aes_generic cbc dm_crypt dm_snapshot dm_mirror
> >> dm_region_hash dm_log dm_mod hp_wmi fuse sbp2 loop
> >> snd_hda_codec_si3054 snd_hda_codec_analog snd_hda_intel snd_hda_codec
> >> snd_pcm_oss snd_mixer_oss snd_pcm snd_seq_dummy arc4 snd_seq_oss ecb
> >> snd_seq_midi snd_rawmidi iwl3945 snd_seq_midi_event iwlcore btusb
> >> firmware_class snd_seq bluetooth snd_timer mac80211 pcmcia
> >> snd_seq_device led_class b44 video ohci1394 backlight ssb rtc_cmos snd
> >> yenta_socket cfg80211 intel_agp soundcore rsrc_nonstatic uhci_hcd
> >> ehci_hcd rtc_core usbcore psmouse snd_page_alloc agpgart pcmcia_core
> >> rfkill rtc_lib ieee1394 sg output evdev serio_raw mii fan button ac
> >> battery
> >> [ 120.872009] Pid: 3510, comm: pm-hibernate Not tainted 2.6.31-git17
> >> #1
> >> [ 120.872009] Call Trace:
> >> [ 120.872009] [<c030f4a3>] ? __sysdev_resume+0xc3/0xe0
> >> [ 120.872009] [<c030f4a3>] ? __sysdev_resume+0xc3/0xe0
> >> [ 120.872009] [<c013c3a1>] warn_slowpath_common+0x71/0xc0
> >> [ 120.872009] [<c030f4a3>] ? __sysdev_resume+0xc3/0xe0
> >> [ 120.872009] [<c013c43b>] warn_slowpath_fmt+0x2b/0x30
> >> [ 120.872009] [<c030f4a3>] __sysdev_resume+0xc3/0xe0
> >> [ 120.872009] [<c015f810>] ? timekeeping_resume+0x0/0x1c0
> >> [ 120.872009] [<c030f50f>] sysdev_resume+0x4f/0xc0
> >> [ 120.872009] [<c0176909>] ? hibernate_nvs_restore+0x19/0x60
> >> [ 120.872009] [<c0172ac1>] hibernation_snapshot+0x1d1/0x210
> >> [ 120.872009] [<c0171b54>] ? freeze_processes+0x44/0xa0
> >> [ 120.872009] [<c0172bef>] hibernate+0xef/0x190
> >> [ 120.872009] [<c0171590>] ? state_store+0x0/0xc0
> >> [ 120.872009] [<c017163b>] state_store+0xab/0xc0
> >> [ 120.872009] [<c0171590>] ? state_store+0x0/0xc0
> >> [ 120.872009] [<c0285e04>] kobj_attr_store+0x24/0x30
> >> [ 120.872009] [<c0223d82>] sysfs_write_file+0xa2/0x100
> >> [ 120.872009] [<c01d880c>] vfs_write+0x9c/0x150
> >> [ 120.872009] [<c0223ce0>] ? sysfs_write_file+0x0/0x100
> >> [ 120.872009] [<c01d8982>] sys_write+0x42/0x70
> >> [ 120.872009] [<c0102f04>] sysenter_do_call+0x12/0x22
> >> [ 120.872009] ---[ end trace 51d3cc987b340170 ]---
> >> [ 120.872009] Enabling non-boot CPUs ...
> >> [ 120.872009] SMP alternatives: switching to SMP code
^ permalink raw reply
* Re: [bisected] Wireless regression in 2.6.32-git
From: Hugh Dickins @ 2009-09-27 16:14 UTC (permalink / raw)
To: Arjan van de Ven
Cc: Johannes Berg, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20090927151855.29efcc53-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
On Sun, 27 Sep 2009, Arjan van de Ven wrote:
>
> With todays git my laptop fails to associate with my access point.
> Bisection points to the commit below, and reverting this one commit on
> the HEAD of tree also fixes the issue, so I'm pretty confident that this
> commit is to blame.
>
> I have a 4965 wifi card in my laptop, and the network I'm trying to
> connect to has no encryption. I'm running Fedora 11 as OS.
>
> I would like to kindly request for this commit to be reverted until a
> more permanent solution is found (I'm happy to test any patches)..
>
> 94f85853324e02c3a32bc3101f090dc9a3f512b4 is first bad commit
> commit 94f85853324e02c3a32bc3101f090dc9a3f512b4
> Author: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
> Date: Thu Sep 17 17:15:31 2009 -0700
>
> cfg80211: don't overwrite privacy setting
>
> When cfg80211 is instructed to connect, it always
> uses the default WEP key for the privacy setting,
> which clearly is wrong when using wpa_supplicant.
> Don't overwrite the setting, and rely on it being
> false when wpa_supplicant is not running, instead
> set it to true when we have keys.
>
> Signed-off-by: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
> Signed-off-by: John W. Linville <linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
>
> :040000 040000 27fb46273e88eefee373699eb7e3f2923ac0886b
> 9518ee3e52c8320613cc5eee5ac54aabf082432f M net
I've a different problem with wireless that Johannes is investigating
for me on linux-wireless; but here's a patch that he pointed me to
along the way, didn't help my issue but I expect it will help yours...
Subject: cfg80211: don't set privacy w/o key
When wpa_supplicant is used to connect to open networks,
it causes the wdev->wext.keys to point to key memory, but
that key memory is all empty. Only use privacy when there
is a default key to be used.
Signed-off-by: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
---
net/wireless/wext-sme.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- wireless-testing.orig/net/wireless/wext-sme.c 2009-09-24 08:51:14.000000000 +0200
+++ wireless-testing/net/wireless/wext-sme.c 2009-09-24 08:57:01.000000000 +0200
@@ -30,7 +30,8 @@ int cfg80211_mgd_wext_connect(struct cfg
if (wdev->wext.keys) {
wdev->wext.keys->def = wdev->wext.default_key;
wdev->wext.keys->defmgmt = wdev->wext.default_mgmt_key;
- wdev->wext.connect.privacy = true;
+ if (wdev->wext.default_key != -1)
+ wdev->wext.connect.privacy = true;
}
if (!wdev->wext.connect.ssid_len)
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [2.6.31-git17] WARNING: at kernel/hrtimer.c:648 hres_timers_resume+0x40/0x50()/WARNING: at drivers/base/sys.c:353 __sysdev_resume+0xc3/0xe0()
From: Maciej Rutecki @ 2009-09-27 16:16 UTC (permalink / raw)
To: Yong Zhang
Cc: Linux Kernel Mailing List, Rafael J. Wysocki, clemens,
venkatesh.pallipadi, gregkh, zambrano, davem, netdev
In-Reply-To: <2674af740909270749u339671a1ia81d5736eeb750fa@mail.gmail.com>
2009/9/27 Yong Zhang <yong.zhang0@gmail.com>:
>
> It seem this is cause by b44 dirver. Can you give a try?
>
> From 05ee2f22a7ea065e05bf8b5294d222a3700d2cc8 Mon Sep 17 00:00:00 2001
> From: Yong Zhang <yong.zhang0@gmail.com>
> Date: Sun, 27 Sep 2009 22:42:41 +0800
> Subject: [PATCH] net/b44: keep irq state at suspend_resume
>
> suspend() and resume() assume irq is disabled. So keep the irq
> state when do this.
Remove previous patch, add it to clean 2.6.31-git17. It doesn't help.
> --
> 1.6.0.4
>
>> So can you test the follow patch. And show the dmesg info(DEBUG
>> level) after WARNING is triggered?
>>
>> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
>> index fb0f46f..4a00a1a 100644
Still test it?
Regards
--
Maciej Rutecki
http://www.maciek.unixy.pl
^ permalink raw reply
* Re: [PATCH] ax25: Fix ax25_cb refcounting in ax25_ctl_ioctl
From: Jarek Poplawski @ 2009-09-27 17:10 UTC (permalink / raw)
To: Ralf Baechle DL5RB
Cc: David Miller, Bernard Pidoux F6BVP, Bernard Pidoux,
Linux Netdev List, linux-hams
In-Reply-To: <20090927072319.GA28089@linux-mips.org>
On Sun, Sep 27, 2009 at 08:23:19AM +0100, Ralf Baechle DL5RB wrote:
> On Fri, Sep 25, 2009 at 08:35:04PM +0200, Jarek Poplawski wrote:
>
> > > > This bug isn't responsible for these oopses here, but looks quite
> > > > obviously. (I'm not sure if it's easy to test/hit with the common
> > > > tools.)
> > >
> > > The issue your patch fixes is obvious enough.
> >
> > Yes, with new code there would be no doubt. But here, if you know it's
> > worked for some time, you wonder if you're not blind. |-)
>
> Most of of the ioctls are used by AX.25 userland which does error
> checking on user supplied values so userland will never attempt invalid
> ioctl calls. So no surprise this went unnoticed.
In this case valid calls (return 0) were affected too, so I guess the
whole thing is rarely used.
Jarek P.
^ permalink raw reply
* Re: [2.6.31-git17] WARNING: at kernel/hrtimer.c:648 hres_timers_resume+0x40/0x50()/WARNING: at drivers/base/sys.c:353 __sysdev_resume+0xc3/0xe0()
From: Rafael J. Wysocki @ 2009-09-27 18:17 UTC (permalink / raw)
To: Maciej Rutecki
Cc: Yong Zhang, Linux Kernel Mailing List, clemens,
venkatesh.pallipadi, gregkh, zambrano, davem, netdev
In-Reply-To: <8db1092f0909270916k79d0c369ub93b5e8ddf66c979@mail.gmail.com>
On Sunday 27 September 2009, Maciej Rutecki wrote:
> 2009/9/27 Yong Zhang <yong.zhang0@gmail.com>:
> >
> > It seem this is cause by b44 dirver. Can you give a try?
> >
> > From 05ee2f22a7ea065e05bf8b5294d222a3700d2cc8 Mon Sep 17 00:00:00 2001
> > From: Yong Zhang <yong.zhang0@gmail.com>
> > Date: Sun, 27 Sep 2009 22:42:41 +0800
> > Subject: [PATCH] net/b44: keep irq state at suspend_resume
> >
> > suspend() and resume() assume irq is disabled. So keep the irq
> > state when do this.
>
> Remove previous patch, add it to clean 2.6.31-git17. It doesn't help.
It couldn't. The problem is elswhere, but I haven't found it yet.
Thanks,
Rafael
^ permalink raw reply
* [PATCH 1/2] net: introduce NETDEV_PRE_INIT notifier
From: Johannes Berg @ 2009-09-27 18:26 UTC (permalink / raw)
To: netdev; +Cc: linux-wireless
For various purposes including a wireless extensions
bugfix, we need to hook into the netdev creation at
a point before netdev_register_kobject(). It seems
more generic, however, to have it even earlier. This
will also ease doing the dev type assignment that
Marcel was working on generically.
Signed-off-by: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
---
include/linux/notifier.h | 1 +
net/core/dev.c | 5 +++++
2 files changed, 6 insertions(+)
--- wireless-testing.orig/include/linux/notifier.h 2009-09-27 15:09:10.000000000 +0200
+++ wireless-testing/include/linux/notifier.h 2009-09-27 15:10:19.000000000 +0200
@@ -199,6 +199,7 @@ static inline int notifier_to_errno(int
#define NETDEV_FEAT_CHANGE 0x000B
#define NETDEV_BONDING_FAILOVER 0x000C
#define NETDEV_PRE_UP 0x000D
+#define NETDEV_PRE_INIT 0x000E
#define SYS_DOWN 0x0001 /* Notify of system down */
#define SYS_RESTART SYS_DOWN
--- wireless-testing.orig/net/core/dev.c 2009-09-27 15:09:56.000000000 +0200
+++ wireless-testing/net/core/dev.c 2009-09-27 15:11:40.000000000 +0200
@@ -4734,6 +4734,11 @@ int register_netdevice(struct net_device
dev->iflink = -1;
+ ret = call_netdevice_notifiers(NETDEV_PRE_INIT, dev);
+ ret = notifier_to_errno(ret);
+ if (ret)
+ goto out;
+
/* Init, if this function is available */
if (dev->netdev_ops->ndo_init) {
ret = dev->netdev_ops->ndo_init(dev);
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [PATCH 2/2] cfg80211: fix wireless handlers assignment
From: Johannes Berg @ 2009-09-27 18:27 UTC (permalink / raw)
To: netdev; +Cc: linux-wireless, Hugh Dickins
The point we assign dev->wireless_handlers at is too
late, we need to do that before netdev_register_kobject()
gets called, so use the new NETDEV_PRE_INIT notifier.
The result of adding wireless_handlers too late is the
disappearance of /sys/class/net/wlan0/wireless which a
bunch of distro scripts still require.
Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
---
This should fix the regression Hugh reported (of course requires the
other patch which unfortunately I forgot to CC you, Hugh, I'll send you
a copy in private).
net/wireless/core.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--- wireless-testing.orig/net/wireless/core.c 2009-09-27 15:12:20.000000000 +0200
+++ wireless-testing/net/wireless/core.c 2009-09-27 15:12:54.000000000 +0200
@@ -641,6 +641,12 @@ static int cfg80211_netdev_notifier_call
WARN_ON(wdev->iftype == NL80211_IFTYPE_UNSPECIFIED);
switch (state) {
+ case NETDEV_PRE_INIT:
+#ifdef CONFIG_WIRELESS_EXT
+ if (!dev->wireless_handlers)
+ dev->wireless_handlers = &cfg80211_wext_handler;
+#endif
+ break;
case NETDEV_REGISTER:
/*
* NB: cannot take rdev->mtx here because this may be
@@ -666,8 +672,6 @@ static int cfg80211_netdev_notifier_call
wdev->sme_state = CFG80211_SME_IDLE;
mutex_unlock(&rdev->devlist_mtx);
#ifdef CONFIG_WIRELESS_EXT
- if (!dev->wireless_handlers)
- dev->wireless_handlers = &cfg80211_wext_handler;
wdev->wext.default_key = -1;
wdev->wext.default_mgmt_key = -1;
wdev->wext.connect.auth_type = NL80211_AUTHTYPE_AUTOMATIC;
^ permalink raw reply
* Re: [bisected] Wireless regression in 2.6.32-git
From: Arjan van de Ven @ 2009-09-27 18:45 UTC (permalink / raw)
To: Hugh Dickins; +Cc: Johannes Berg, netdev, linux-kernel, linux-wireless
In-Reply-To: <Pine.LNX.4.64.0909271708210.8927@sister.anvils>
On Sun, 27 Sep 2009 17:14:04 +0100 (BST)
Hugh Dickins <hugh.dickins@tiscali.co.uk> wrote:
> On Sun, 27 Sep 2009, Arjan van de Ven wrote:
> >
> > With todays git my laptop fails to associate with my access point.
> > Bisection points to the commit below, and reverting this one commit
> > on the HEAD of tree also fixes the issue, so I'm pretty confident
> > that this commit is to blame.
> >
> > I have a 4965 wifi card in my laptop, and the network I'm trying to
> > connect to has no encryption. I'm running Fedora 11 as OS.
> >
> > I would like to kindly request for this commit to be reverted until
> > a more permanent solution is found (I'm happy to test any patches)..
> >
> > 94f85853324e02c3a32bc3101f090dc9a3f512b4 is first bad commit
> > commit 94f85853324e02c3a32bc3101f090dc9a3f512b4
> > Author: Johannes Berg <johannes@sipsolutions.net>
> > Date: Thu Sep 17 17:15:31 2009 -0700
> >
> > cfg80211: don't overwrite privacy setting
> >
> > When cfg80211 is instructed to connect, it always
> > uses the default WEP key for the privacy setting,
> > which clearly is wrong when using wpa_supplicant.
> > Don't overwrite the setting, and rely on it being
> > false when wpa_supplicant is not running, instead
> > set it to true when we have keys.
> >
> > Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
> > Signed-off-by: John W. Linville <linville@tuxdriver.com>
> >
> > :040000 040000 27fb46273e88eefee373699eb7e3f2923ac0886b
> > 9518ee3e52c8320613cc5eee5ac54aabf082432f M net
>
> I've a different problem with wireless that Johannes is investigating
> for me on linux-wireless; but here's a patch that he pointed me to
> along the way, didn't help my issue but I expect it will help yours...
>
>
> Subject: cfg80211: don't set privacy w/o key
>
> When wpa_supplicant is used to connect to open networks,
> it causes the wdev->wext.keys to point to key memory, but
> that key memory is all empty. Only use privacy when there
> is a default key to be used.
indeed it does
can we get this into mainline soon ?
^ permalink raw reply
* Re: [bisected] Wireless regression in 2.6.32-git
From: Johannes Berg @ 2009-09-27 18:46 UTC (permalink / raw)
To: Arjan van de Ven
Cc: Hugh Dickins, netdev-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-wireless-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20090927204548.3ee3768f-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
On Sun, 2009-09-27 at 20:45 +0200, Arjan van de Ven wrote:
> > Subject: cfg80211: don't set privacy w/o key
> >
> > When wpa_supplicant is used to connect to open networks,
> > it causes the wdev->wext.keys to point to key memory, but
> > that key memory is all empty. Only use privacy when there
> > is a default key to be used.
>
>
> indeed it does
>
> can we get this into mainline soon ?
John's on his way home I suppose.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: [PATCH 1/3] lib/vsprintf.c: Add %pU - ptr to a UUID/GUID
From: Joe Perches @ 2009-09-27 19:00 UTC (permalink / raw)
To: Ingo Oeser; +Cc: linux-kernel, netdev, Greg KH
In-Reply-To: <200909271245.34000.ioe-lkml@rameria.de>
On Sun, 2009-09-27 at 12:45 +0200, Ingo Oeser wrote:
> Hi Joe,
Hello Ingo.
> On Sunday 27 September 2009, Joe Perches wrote:
> > UUID/GUIDs are somewhat common in kernel source.
> > Standardize the printed style of UUID/GUIDs by using
> > another extension to %p.
> > %pU: 01020304:0506:0708:090a:0b0c0d0e0f10
> > %pUr: 04030201:0605:0807:0a09:0b0c0d0e0f10
> Code does "01020304-0506-0708-090a-0b0c0d0e0f10".
> This is not, what commit promises. Please change the commit message!
True enough, that can change, no worries.
Does anyone have comments like:
1 what a stupid idea
2 how unnecessary
3 meh
4 bloat alert! linux is supposed to be lean
5 ok idea, bad implementation
6 sure, why not
^ permalink raw reply
* Re: [PATCH] ax25: Fix ax25_cb refcounting in ax25_ctl_ioctl
From: Jarek Poplawski @ 2009-09-27 19:02 UTC (permalink / raw)
To: Ralf Baechle DL5RB
Cc: David Miller, Bernard Pidoux F6BVP, Bernard Pidoux,
Linux Netdev List, linux-hams
In-Reply-To: <20090927171029.GA3297@del.dom.local>
On Sun, Sep 27, 2009 at 07:10:29PM +0200, Jarek Poplawski wrote:
...
> In this case valid calls (return 0) were affected too, so I guess the
> whole thing is rarely used.
And, after all, there would be only a little, invisible memory leak.
Jarek P.
^ permalink raw reply
* Re: [PATCH 1/2] net: introduce NETDEV_PRE_INIT notifier
From: Marcel Holtmann @ 2009-09-27 20:11 UTC (permalink / raw)
To: Johannes Berg; +Cc: netdev, linux-wireless
In-Reply-To: <1254075999.6583.4.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
Hi Johannes,
> For various purposes including a wireless extensions
> bugfix, we need to hook into the netdev creation at
> a point before netdev_register_kobject(). It seems
> more generic, however, to have it even earlier. This
> will also ease doing the dev type assignment that
> Marcel was working on generically.
you are beating me to it. I can only second that this is a good idea for
the dev type assignment. Once Dave acks this I can sent a rebased patch
for the dev type stuff for WiFi.
Regards
Marcel
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 2/2] cfg80211: fix wireless handlers assignment
From: Luis R. Rodriguez @ 2009-09-27 20:30 UTC (permalink / raw)
To: Johannes Berg; +Cc: netdev, linux-wireless, Hugh Dickins
In-Reply-To: <1254076075.6583.6.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
On Sun, Sep 27, 2009 at 11:27 AM, Johannes Berg
<johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> wrote:
> The point we assign dev->wireless_handlers at is too
> late, we need to do that before netdev_register_kobject()
> gets called, so use the new NETDEV_PRE_INIT notifier.
> The result of adding wireless_handlers too late is the
> disappearance of /sys/class/net/wlan0/wireless which a
> bunch of distro scripts still require.
>
> Signed-off-by: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
> ---
> This should fix the regression Hugh reported (of course requires the
> other patch which unfortunately I forgot to CC you, Hugh, I'll send you
> a copy in private).
Are these stable fixes?
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 1/3] lib/vsprintf.c: Add %pU - ptr to a UUID/GUID
From: Greg KH @ 2009-09-27 20:53 UTC (permalink / raw)
To: Joe Perches; +Cc: Ingo Oeser, linux-kernel, netdev
In-Reply-To: <1254078046.28232.183.camel@Joe-Laptop.home>
On Sun, Sep 27, 2009 at 12:00:46PM -0700, Joe Perches wrote:
> On Sun, 2009-09-27 at 12:45 +0200, Ingo Oeser wrote:
> > Hi Joe,
>
> Hello Ingo.
>
> > On Sunday 27 September 2009, Joe Perches wrote:
> > > UUID/GUIDs are somewhat common in kernel source.
> > > Standardize the printed style of UUID/GUIDs by using
> > > another extension to %p.
> > > %pU: 01020304:0506:0708:090a:0b0c0d0e0f10
> > > %pUr: 04030201:0605:0807:0a09:0b0c0d0e0f10
> > Code does "01020304-0506-0708-090a-0b0c0d0e0f10".
> > This is not, what commit promises. Please change the commit message!
>
> True enough, that can change, no worries.
>
> Does anyone have comments like:
>
> 1 what a stupid idea
> 2 how unnecessary
> 3 meh
> 4 bloat alert! linux is supposed to be lean
> 5 ok idea, bad implementation
> 6 sure, why not
Sure, why not :)
^ permalink raw reply
* [PATCH] ax25: Fix possible oops in ax25_make_new
From: Jarek Poplawski @ 2009-09-27 20:57 UTC (permalink / raw)
To: Ralf Baechle DL5RB
Cc: David Miller, Bernard Pidoux F6BVP, Bernard Pidoux,
Linux Netdev List, linux-hams
In-Reply-To: <20090925134052.GA1661@linux-mips.org>
In ax25_make_new, if kmemdup of digipeat returns an error, there would
be an oops in sk_free while calling sk_destruct, because sk_protinfo
is NULL at the moment; move sk->sk_destruct initialization after this.
BTW of reported-by: Bernard Pidoux F6BVP <f6bvp@free.fr>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
---
net/ax25/af_ax25.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
index fbcac76..9884639 100644
--- a/net/ax25/af_ax25.c
+++ b/net/ax25/af_ax25.c
@@ -900,7 +900,6 @@ struct sock *ax25_make_new(struct sock *osk, struct ax25_dev *ax25_dev)
sock_init_data(NULL, sk);
- sk->sk_destruct = ax25_free_sock;
sk->sk_type = osk->sk_type;
sk->sk_priority = osk->sk_priority;
sk->sk_protocol = osk->sk_protocol;
@@ -938,6 +937,7 @@ struct sock *ax25_make_new(struct sock *osk, struct ax25_dev *ax25_dev)
}
sk->sk_protinfo = ax25;
+ sk->sk_destruct = ax25_free_sock;
ax25->sk = sk;
return sk;
^ permalink raw reply related
* Re: [PATCH 2/2] cfg80211: fix wireless handlers assignment
From: Hugh Dickins @ 2009-09-27 20:58 UTC (permalink / raw)
To: Johannes Berg; +Cc: netdev, linux-wireless
In-Reply-To: <1254076075.6583.6.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
On Sun, 27 Sep 2009, Johannes Berg wrote:
> The point we assign dev->wireless_handlers at is too
> late, we need to do that before netdev_register_kobject()
> gets called, so use the new NETDEV_PRE_INIT notifier.
> The result of adding wireless_handlers too late is the
> disappearance of /sys/class/net/wlan0/wireless which a
> bunch of distro scripts still require.
>
> Signed-off-by: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>
This 2/2 patch does indeed work: many thanks. But...
> ---
> This should fix the regression Hugh reported (of course requires the
> other patch which unfortunately I forgot to CC you, Hugh, I'll send you
> a copy in private).
... the 1/2 patch has a couple of problems.
The trivial problem is that include/linux/notifier.h in Linus's git has
#define NETDEV_PRE_UP 0x000D
#define NETDEV_BONDING_OLDTYPE 0x000E
#define NETDEV_BONDING_NEWTYPE 0x000F
So it rejects the patch you posted: I changed it to add
#define NETDEV_PRE_INIT 0x0010
just after the NETDEV_BONDING_NEWTYPE line.
The more serious problem is that it stops both my machines from booting,
too early for framebuffer to show any messages, but vga=normal shows a
long stacktrace scrolling offscreen, with some notifier stuff in there.
I've experimented by moving your NETDEV_PRE_INIT hunk later in the
sequence, just before the netdev_initialize_kobject(dev) (so I also
changed the "goto out" to "goto err_uninit"): both* machines then boot
correctly, and this mail leaves me wirelessly.
I'll now experiment to see how early I can move that hunk.
Hugh
* I wrote that hoping the Aspire One build would complete soon,
but it's still going: assume it's fine unless I say otherwise.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 2/2] cfg80211: fix wireless handlers assignment
From: Hugh Dickins @ 2009-09-27 21:50 UTC (permalink / raw)
To: Johannes Berg; +Cc: netdev, linux-wireless
In-Reply-To: <Pine.LNX.4.64.0909272139280.4061-T/S/X05ZC3jbmfIwyoSfiQ@public.gmane.org>
On Sun, 27 Sep 2009, Hugh Dickins wrote:
>
> I've experimented by moving your NETDEV_PRE_INIT hunk later in the
> sequence, just before the netdev_initialize_kobject(dev) (so I also
> changed the "goto out" to "goto err_uninit"): both* machines then boot
> correctly, and this mail leaves me wirelessly.
>
> I'll now experiment to see how early I can move that hunk.
Both machines boot (and do wireless) correctly with your NETDEV_PRE_INIT
hunk placed just after the ndo_init block, instead of just before where
you placed it. That's i386 kernels on both.
But curiouser and curiouser... the laptop can do 64-bit, so I built
my 64-bit kernel, and went through the motions to reproduce the
early boot crash with the patch as you had it: but the x86_64 kernel
boots (and does wireless) correctly with the NETDEV_PRE_INIT hunk
just where you placed it, before the ndo_init block.
Perhaps there's a difference in the 32- and 64-bit startup sequence
with respect to notifiers; or perhaps your change tickles another bug.
I don't know, I'm turning off now.
Hugh
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [2.6.31-git17] WARNING: at kernel/hrtimer.c:648 hres_timers_resume+0x40/0x50()/WARNING: at drivers/base/sys.c:353 __sysdev_resume+0xc3/0xe0()
From: Yong Zhang @ 2009-09-28 1:54 UTC (permalink / raw)
To: Maciej Rutecki
Cc: Linux Kernel Mailing List, Rafael J. Wysocki, clemens,
venkatesh.pallipadi, gregkh, zambrano, davem, netdev
In-Reply-To: <8db1092f0909270916k79d0c369ub93b5e8ddf66c979@mail.gmail.com>
On Mon, Sep 28, 2009 at 12:16 AM, Maciej Rutecki
<maciej.rutecki@gmail.com> wrote:
> 2009/9/27 Yong Zhang <yong.zhang0@gmail.com>:
>>
>> It seem this is cause by b44 dirver. Can you give a try?
>>
>> From 05ee2f22a7ea065e05bf8b5294d222a3700d2cc8 Mon Sep 17 00:00:00 2001
>> From: Yong Zhang <yong.zhang0@gmail.com>
>> Date: Sun, 27 Sep 2009 22:42:41 +0800
>> Subject: [PATCH] net/b44: keep irq state at suspend_resume
>>
>> suspend() and resume() assume irq is disabled. So keep the irq
>> state when do this.
>
> Remove previous patch, add it to clean 2.6.31-git17. It doesn't help.
>
>> --
>> 1.6.0.4
>>
>>> So can you test the follow patch. And show the dmesg info(DEBUG
>>> level) after WARNING is triggered?
>>>
>>> diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
>>> index fb0f46f..4a00a1a 100644
>
> Still test it?
>
If you could, then please do it. It can give us some helpful information.
Thanks,
Yong
> Regards
> --
> Maciej Rutecki
> http://www.maciek.unixy.pl
>
^ permalink raw reply
* [PATCH] ax25: Add missing dev_put in ax25_setsockopt
From: Jarek Poplawski @ 2009-09-28 7:12 UTC (permalink / raw)
To: David Miller
Cc: Bernard Pidoux F6BVP, Bernard Pidoux, Ralf Baechle DL5RB,
Linux Netdev List, linux-hams
In-Reply-To: <4ABA9058.3010605@free.fr>
There is no dev_put ending positive SO_BINDTODEVICE call in
ax25_setsockopt and no matching dev_put later. This ref isn't used by
ax25_cb's because it's handled with up and down device events.
BTW of reported-by: Bernard Pidoux F6BVP <f6bvp@free.fr>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
---
net/ax25/af_ax25.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c
index fbcac76..3eee8eb 100644
--- a/net/ax25/af_ax25.c
+++ b/net/ax25/af_ax25.c
@@ -663,6 +663,7 @@ static int ax25_setsockopt(struct socket *sock, int level, int optname,
ax25->ax25_dev = ax25_dev_ax25dev(dev);
ax25_fillin_cb(ax25, ax25->ax25_dev);
+ dev_put(dev);
break;
default:
^ permalink raw reply related
* Re: [PATCH 2/2] cfg80211: fix wireless handlers assignment
From: Johannes Berg @ 2009-09-28 7:41 UTC (permalink / raw)
To: Hugh Dickins; +Cc: netdev, linux-wireless
In-Reply-To: <Pine.LNX.4.64.0909272139280.4061-T/S/X05ZC3jbmfIwyoSfiQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]
On Sun, 2009-09-27 at 21:58 +0100, Hugh Dickins wrote:
> This 2/2 patch does indeed work: many thanks. But...
... it won't fix anything by itself.
> > This should fix the regression Hugh reported (of course requires the
> > other patch which unfortunately I forgot to CC you, Hugh, I'll send you
> > a copy in private).
>
> ... the 1/2 patch has a couple of problems.
>
> The trivial problem is that include/linux/notifier.h in Linus's git has
> #define NETDEV_PRE_UP 0x000D
> #define NETDEV_BONDING_OLDTYPE 0x000E
> #define NETDEV_BONDING_NEWTYPE 0x000F
>
> So it rejects the patch you posted: I changed it to add
> #define NETDEV_PRE_INIT 0x0010
> just after the NETDEV_BONDING_NEWTYPE line.
Right, that's fixable, I was evidently working against the wrong tree.
> The more serious problem is that it stops both my machines from booting,
> too early for framebuffer to show any messages, but vga=normal shows a
> long stacktrace scrolling offscreen, with some notifier stuff in there.
Ahrg. That's strange.
> I've experimented by moving your NETDEV_PRE_INIT hunk later in the
> sequence, just before the netdev_initialize_kobject(dev) (so I also
> changed the "goto out" to "goto err_uninit"): both* machines then boot
> correctly, and this mail leaves me wirelessly.
>
> I'll now experiment to see how early I can move that hunk.
Interesting. Thanks for that; must be some notifier that doesn't expect
to be run. For all I care, it can be right before the kobject stuff, so
maybe that makes more sense as it's a fairly last-minute fix now. Of
course then it should be POST_INIT or PRE_REGISTER I suppose.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
* Re: [ath5k-devel] Fw: Cannot register at bugzilla (bugreport added) [ ath5k bugreport ]
From: Holger Schurig @ 2009-09-28 7:42 UTC (permalink / raw)
To: ath5k-devel-xDcbHBWguxEUs3QNXV6qNA
Cc: Florian Mickler, Hans-J. Ullrich, Jiri Slaby,
linux-wireless-u79uwXL29TY76Z2rM5mHXA, John W. Linville,
netdev-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20090925191524.7b2b228c@schatten>
> There are already other reports of this problem in discussion
forums.
> It seems, the old madwifi-driver works better with dhcp - so
people say.
I cannot second that. For me, ath5k works perfectly with DHCP,
with WEXT ("iwconfig") and NL80211 ("iw") and with
wpa_supplicant.
DHCP was NEVER an issue.
--
http://www.holgerschurig.de
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 2/2] cfg80211: fix wireless handlers assignment
From: Johannes Berg @ 2009-09-28 7:54 UTC (permalink / raw)
To: Hugh Dickins; +Cc: netdev, linux-wireless
In-Reply-To: <Pine.LNX.4.64.0909272237190.4098@sister.anvils>
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
On Sun, 2009-09-27 at 22:50 +0100, Hugh Dickins wrote:
> On Sun, 27 Sep 2009, Hugh Dickins wrote:
> >
> > I've experimented by moving your NETDEV_PRE_INIT hunk later in the
> > sequence, just before the netdev_initialize_kobject(dev) (so I also
> > changed the "goto out" to "goto err_uninit"): both* machines then boot
> > correctly, and this mail leaves me wirelessly.
> >
> > I'll now experiment to see how early I can move that hunk.
>
> Both machines boot (and do wireless) correctly with your NETDEV_PRE_INIT
> hunk placed just after the ndo_init block, instead of just before where
> you placed it. That's i386 kernels on both.
>
> But curiouser and curiouser... the laptop can do 64-bit, so I built
> my 64-bit kernel, and went through the motions to reproduce the
> early boot crash with the patch as you had it: but the x86_64 kernel
> boots (and does wireless) correctly with the NETDEV_PRE_INIT hunk
> just where you placed it, before the ndo_init block.
>
> Perhaps there's a difference in the 32- and 64-bit startup sequence
> with respect to notifiers; or perhaps your change tickles another bug.
> I don't know, I'm turning off now.
Interesting, thanks for taking the time to test. I'll post an updated
patchset that calls it POST_INIT and moves it to there.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox