* RE: NETLINK sockets dont honor SO_RCVLOWAT?
From: Jeff Haran @ 2009-11-18 19:00 UTC (permalink / raw)
To: David Miller; +Cc: netdev@vger.kernel.org
In-Reply-To: <20091118.104434.185425439.davem@davemloft.net>
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Wednesday, November 18, 2009 10:45 AM
> To: Jeff Haran
> Cc: netdev@vger.kernel.org
> Subject: Re: NETLINK sockets dont honor SO_RCVLOWAT?
>
> From: Jeff Haran <jharan@Brocade.COM>
> Date: Wed, 18 Nov 2009 10:41:06 -0800
>
> > The operative term is "shall". The RFCs define "shall" to be
> > required behavior. I realize the RFCs do not dictate how Linux
> > works, but even the common English language usage of the word
> > "shall" conveys this meaning.
>
> The low water mark can be seen as a hint, therefore we can
> apply the term "support" loosely here.
>
> And the errors are advisory, just like things like -EFAULT.
>
> Look, I'm not going to add a feature flag or some callback just to
> handle this.
>
> You have to know what kind of protocol you are working with, and
> therefore which socket options make any sense for it.
If the open source community doesn't want a fix for something that is obviously broken, that's fine. We fix a lot of broken kernel code here at Brocade. But at least now I know that I need not bother with submitting a patch. That will save everybody a lot of time.
Thanks,
Jeff Haran
Brocade Communications
^ permalink raw reply
* Re: [PATCH 16/16] drivers/net/wireless/rtl818x: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:52 UTC (permalink / raw)
To: julia
Cc: linville, linux-wireless, netdev, arnd, joe, linux-kernel,
kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181925440.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:26:02 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 15/16] drivers/net/wireless/p54: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:52 UTC (permalink / raw)
To: julia-dAYI7NvHqcQ
Cc: flamingice-R9e9/4HEdknk1uMJSBkQmQ,
linville-2XuSBdqkA4R54TAoqtyWWQ,
linux-wireless-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, arnd-r2nGTMty4D4,
joe-6d6DIl74uiNBDgjK7y7TUQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
kernel-janitors-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <Pine.LNX.4.64.0911181925260.20943-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org>
From: Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>
Date: Wed, 18 Nov 2009 19:25:43 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 13/16] drivers/net/adm8211.c: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:52 UTC (permalink / raw)
To: julia
Cc: flamingice, linville, linux-wireless, netdev, arnd, joe,
linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181924310.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:24:50 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 14/16] drivers/net/wireless/iwlwifi: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:52 UTC (permalink / raw)
To: julia
Cc: yi.zhu, reinette.chatre, ilw, linville, linux-wireless, netdev,
arnd, joe, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181924510.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:25:25 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 11/16] drivers/net/via-velocity.c: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:51 UTC (permalink / raw)
To: julia; +Cc: romieu, netdev, arnd, joe, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181923540.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:24:13 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 12/16] drivers/net/wan: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:52 UTC (permalink / raw)
To: julia; +Cc: romieu, netdev, arnd, joe, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181924140.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:24:30 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 10/16] drivers/net/via-rhine.c: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:51 UTC (permalink / raw)
To: julia; +Cc: rl, netdev, arnd, joe, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181923340.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:23:53 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 9/16] drivers/net/typhoon.c: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:51 UTC (permalink / raw)
To: julia; +Cc: dave, netdev, arnd, joe, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181923180.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:23:34 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 8/16] drivers/net/smsc9420.c: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:51 UTC (permalink / raw)
To: julia; +Cc: steve.glendinning, netdev, arnd, joe, linux-kernel,
kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181923010.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:23:17 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 7/16] drivers/net/r6040.c: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:50 UTC (permalink / raw)
To: julia; +Cc: florian, netdev, arnd, joe, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181922450.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:23:00 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 5/16] drivers/net/irda: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:49 UTC (permalink / raw)
To: julia; +Cc: samuel, netdev, arnd, joe, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181921450.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:22:05 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 6/16] drivers/net/pppol2tp.c: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:49 UTC (permalink / raw)
To: julia; +Cc: jchapman, netdev, arnd, joe, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181922240.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:22:44 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 3/16] drivers/net: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:49 UTC (permalink / raw)
To: julia; +Cc: netdev, arnd, joe, linux-kernel, kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181920450.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:21:04 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 4/16] drivers/net/ipg.c: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:49 UTC (permalink / raw)
To: julia
Cc: romieu, sorbica, jesse, netdev, arnd, joe, linux-kernel,
kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181921050.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:21:45 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: [PATCH 2/16] drivers/net/can: remove exceptional & on function name
From: David Miller @ 2009-11-18 18:48 UTC (permalink / raw)
To: julia
Cc: urs.thuermann, oliver.hartkopp, netdev, arnd, joe, linux-kernel,
kernel-janitors
In-Reply-To: <Pine.LNX.4.64.0911181920250.20943@ask.diku.dk>
From: Julia Lawall <julia@diku.dk>
Date: Wed, 18 Nov 2009 19:20:44 +0100 (CET)
> In this file, function names are otherwise used as pointers without &.
...
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply
* Re: NETLINK sockets dont honor SO_RCVLOWAT?
From: David Miller @ 2009-11-18 18:44 UTC (permalink / raw)
To: jharan; +Cc: netdev
In-Reply-To: <D67825C5985D0647BE40A5F5B0B70D1106E9C568FE@HQ-EXCH-7.corp.brocade.com>
From: Jeff Haran <jharan@Brocade.COM>
Date: Wed, 18 Nov 2009 10:41:06 -0800
> The operative term is "shall". The RFCs define "shall" to be
> required behavior. I realize the RFCs do not dictate how Linux
> works, but even the common English language usage of the word
> "shall" conveys this meaning.
The low water mark can be seen as a hint, therefore we can
apply the term "support" loosely here.
And the errors are advisory, just like things like -EFAULT.
Look, I'm not going to add a feature flag or some callback just to
handle this.
You have to know what kind of protocol you are working with, and
therefore which socket options make any sense for it.
^ permalink raw reply
* RE: NETLINK sockets dont honor SO_RCVLOWAT?
From: Jeff Haran @ 2009-11-18 18:41 UTC (permalink / raw)
To: David Miller; +Cc: netdev@vger.kernel.org
In-Reply-To: <20091118.102434.160976750.davem@davemloft.net>
> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Wednesday, November 18, 2009 10:25 AM
> To: Jeff Haran
> Cc: netdev@vger.kernel.org
> Subject: Re: NETLINK sockets dont honor SO_RCVLOWAT?
>
> From: Jeff Haran <jharan@Brocade.COM>
> Date: Wed, 18 Nov 2009 10:22:54 -0800
>
> > So is this a bug or a feature?
>
> It definitely seems intentional.
>
> > When I call setsockopt() to set this option on a NETLINK socket,
> > setsockopt() appears to return 0 to indicate success. If it's not
> > going to be supported, shouldn't setsockopt() return -1 with
> > ENOPROTOOPT in errno in this case?
>
> There are a lot of socket option values that can be set but which
> are not used by the protocol in question.
All that means is that there are a lot of bugs.
>
> I don't think any changes need to be made.
>From the setsockopt man page:
SETSOCKOPT(P) SETSOCKOPT(P)
NAME
setsockopt - set the socket options
SYNOPSIS
#include <sys/socket.h>
int setsockopt(int socket, int level, int option_name,
const void *option_value, socklen_t option_len);
...
ERRORS
The setsockopt() function shall fail if:
...
ENOPROTOOPT
The option is not supported by the protocol.
The operative term is "shall". The RFCs define "shall" to be required behavior. I realize the RFCs do not dictate how Linux works, but even the common English language usage of the word "shall" conveys this meaning.
Thanks,
Jeff Haran
Brocade Communications
^ permalink raw reply
* [PATCH 16/16] drivers/net/wireless/rtl818x: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:26 UTC (permalink / raw)
To: John W. Linville, linux-wireless, netdev, arnd, joe, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
In this file, function names are otherwise used as pointers without &.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/wireless/rtl818x/rtl8180_dev.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/rtl818x/rtl8180_dev.c b/drivers/net/wireless/rtl818x/rtl8180_dev.c
index 16429c4..a1a3dd1 100644
--- a/drivers/net/wireless/rtl818x/rtl8180_dev.c
+++ b/drivers/net/wireless/rtl818x/rtl8180_dev.c
@@ -548,7 +548,7 @@ static int rtl8180_start(struct ieee80211_hw *dev)
rtl818x_iowrite32(priv, &priv->map->TNPDA, priv->tx_ring[1].dma);
rtl818x_iowrite32(priv, &priv->map->TLPDA, priv->tx_ring[0].dma);
- ret = request_irq(priv->pdev->irq, &rtl8180_interrupt,
+ ret = request_irq(priv->pdev->irq, rtl8180_interrupt,
IRQF_SHARED, KBUILD_MODNAME, dev);
if (ret) {
printk(KERN_ERR "%s: failed to register IRQ handler\n",
^ permalink raw reply related
* [PATCH 15/16] drivers/net/wireless/p54: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:25 UTC (permalink / raw)
To: Michael Wu, John W. Linville, linux-wireless, netdev, arnd, joe,
linux-kernel
From: Julia Lawall <julia@diku.dk>
In this file, function names are otherwise used as pointers without &.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/wireless/p54/p54pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/p54/p54pci.c b/drivers/net/wireless/p54/p54pci.c
index d348c26..a15962a 100644
--- a/drivers/net/wireless/p54/p54pci.c
+++ b/drivers/net/wireless/p54/p54pci.c
@@ -411,7 +411,7 @@ static int p54p_open(struct ieee80211_hw *dev)
int err;
init_completion(&priv->boot_comp);
- err = request_irq(priv->pdev->irq, &p54p_interrupt,
+ err = request_irq(priv->pdev->irq, p54p_interrupt,
IRQF_SHARED, "p54pci", dev);
if (err) {
dev_err(&priv->pdev->dev, "failed to register IRQ handler\n");
^ permalink raw reply related
* [PATCH 14/16] drivers/net/wireless/iwlwifi: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:25 UTC (permalink / raw)
To: Zhu Yi, Reinette Chatre, Intel Linux Wireless, John W. Linville,
linux-wireless
From: Julia Lawall <julia@diku.dk>
In this file, function names are otherwise used as pointers without &.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/wireless/iwlwifi/iwl-3945-rs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-3945-rs.c b/drivers/net/wireless/iwlwifi/iwl-3945-rs.c
index dc81e19..d4b4988 100644
--- a/drivers/net/wireless/iwlwifi/iwl-3945-rs.c
+++ b/drivers/net/wireless/iwlwifi/iwl-3945-rs.c
@@ -355,7 +355,7 @@ static void rs_rate_init(void *priv_r, struct ieee80211_supported_band *sband,
init_timer(&rs_sta->rate_scale_flush);
rs_sta->rate_scale_flush.data = (unsigned long)rs_sta;
- rs_sta->rate_scale_flush.function = &iwl3945_bg_rate_scale_flush;
+ rs_sta->rate_scale_flush.function = iwl3945_bg_rate_scale_flush;
for (i = 0; i < IWL_RATE_COUNT_3945; i++)
iwl3945_clear_window(&rs_sta->win[i]);
^ permalink raw reply related
* [PATCH 13/16] drivers/net/adm8211.c: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:24 UTC (permalink / raw)
To: Michael Wu, John W. Linville, linux-wireless, netdev, arnd, joe,
linux-kernel
From: Julia Lawall <julia@diku.dk>
In this file, function names are otherwise used as pointers without &.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/wireless/adm8211.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c
index b80f514..3941001 100644
--- a/drivers/net/wireless/adm8211.c
+++ b/drivers/net/wireless/adm8211.c
@@ -1538,7 +1538,7 @@ static int adm8211_start(struct ieee80211_hw *dev)
adm8211_hw_init(dev);
adm8211_rf_set_channel(dev, priv->channel);
- retval = request_irq(priv->pdev->irq, &adm8211_interrupt,
+ retval = request_irq(priv->pdev->irq, adm8211_interrupt,
IRQF_SHARED, "adm8211", dev);
if (retval) {
printk(KERN_ERR "%s: failed to register IRQ handler\n",
^ permalink raw reply related
* [PATCH 12/16] drivers/net/wan: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:24 UTC (permalink / raw)
To: Francois Romieu, netdev, arnd, joe, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
In this file, function names are otherwise used as pointers without &.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/wan/dscc4.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c
index 07d00b4..8a3513a 100644
--- a/drivers/net/wan/dscc4.c
+++ b/drivers/net/wan/dscc4.c
@@ -1128,7 +1128,7 @@ done:
init_timer(&dpriv->timer);
dpriv->timer.expires = jiffies + 10*HZ;
dpriv->timer.data = (unsigned long)dev;
- dpriv->timer.function = &dscc4_timer;
+ dpriv->timer.function = dscc4_timer;
add_timer(&dpriv->timer);
netif_carrier_on(dev);
^ permalink raw reply related
* Re: NETLINK sockets dont honor SO_RCVLOWAT?
From: David Miller @ 2009-11-18 18:24 UTC (permalink / raw)
To: jharan; +Cc: netdev
In-Reply-To: <D67825C5985D0647BE40A5F5B0B70D1106E9C568F1@HQ-EXCH-7.corp.brocade.com>
From: Jeff Haran <jharan@Brocade.COM>
Date: Wed, 18 Nov 2009 10:22:54 -0800
> So is this a bug or a feature?
It definitely seems intentional.
> When I call setsockopt() to set this option on a NETLINK socket,
> setsockopt() appears to return 0 to indicate success. If it's not
> going to be supported, shouldn't setsockopt() return -1 with
> ENOPROTOOPT in errno in this case?
There are a lot of socket option values that can be set but which
are not used by the protocol in question.
I don't think any changes need to be made.
^ permalink raw reply
* [PATCH 11/16] drivers/net/via-velocity.c: remove exceptional & on function name
From: Julia Lawall @ 2009-11-18 18:24 UTC (permalink / raw)
To: Francois Romieu, netdev, arnd, joe, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
In this file, function names are otherwise used as pointers without &.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier f;
@@
f(...) { ... }
@@
identifier r.f;
@@
- &f
+ f
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/via-velocity.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
index 158f411..1e6b395 100644
--- a/drivers/net/via-velocity.c
+++ b/drivers/net/via-velocity.c
@@ -2176,7 +2176,7 @@ static int velocity_open(struct net_device *dev)
velocity_init_registers(vptr, VELOCITY_INIT_COLD);
- ret = request_irq(vptr->pdev->irq, &velocity_intr, IRQF_SHARED,
+ ret = request_irq(vptr->pdev->irq, velocity_intr, IRQF_SHARED,
dev->name, dev);
if (ret < 0) {
/* Power down the chip */
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox