* Re: [PATCH net-next-2.6] net: use netdev_mc_count and netdev_mc_empty when appropriate
From: David Miller @ 2010-02-12 19:39 UTC (permalink / raw)
To: jpirko; +Cc: netdev
In-Reply-To: <20100208143032.GD2601@psychotron.lab.eng.brq.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Mon, 8 Feb 2010 15:30:35 +0100
> This patch replaces dev->mc_count in all drivers (hopefully I didn't miss
> anything). Used spatch and did small tweaks and conding style changes when
> it was suitable.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Applied to net-next-2.6, thanks.
^ permalink raw reply
* Re: [PATCH net-next-2.6] macb: straighten out macb_mii_probe function
From: David Miller @ 2010-02-12 19:39 UTC (permalink / raw)
To: haavard.skinnemoen; +Cc: jpirko, netdev, hskinnemoen
In-Reply-To: <20100210151706.6f12d431@hskinnemoen-d830>
From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Date: Wed, 10 Feb 2010 15:17:06 +0530
> Jiri Pirko <jpirko@redhat.com> wrote:
>> Use "phy_find_first" instead of manual lookup. Also use "phy_connect_direct"
>> instead of "phy_connect" since we already have phy_device pointer here.
>>
>> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
>
> Looks reasonable as far as I can see.
>
> Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Applied, thanks guys.
^ permalink raw reply
* Re: inet: Remove bogus IGMPv3 report handling
From: David Miller @ 2010-02-12 19:42 UTC (permalink / raw)
To: herbert; +Cc: netdev
In-Reply-To: <20100208032630.GA4369@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 8 Feb 2010 14:26:30 +1100
> inet: Remove bogus IGMPv3 report handling
>
> Currently we treat IGMPv3 reports as if it were an IGMPv2/v1 report.
> This is broken as IGMPv3 reports are formatted differently. So we
> end up suppressing a bogus multicast group (which should be harmless
> as long as the leading reserved field is zero).
>
> In fact, IGMPv3 does not allow membership report suppression so
> we should simply ignore IGMPv3 membership reports as a host.
>
> This patch does exactly that. I kept the case statement for it
> so people won't accidentally add it back thinking that we overlooked
> this case.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied to net-2.6 and queued up for -stable, thanks!
^ permalink raw reply
* Re: ixgbe RSS not working as expected with 8021q and bridging
From: Eric Dumazet @ 2010-02-12 19:48 UTC (permalink / raw)
To: Eldon Koyle; +Cc: netdev
In-Reply-To: <20100212190340.GB20231@esk.cs.usu.edu>
Le vendredi 12 février 2010 à 12:03 -0700, Eldon Koyle a écrit :
> On Feb 10 13:50-0700, Eldon Koyle wrote:
> <snip>
> > I am now trying 2.6.32.7 with the in-tree ixgbe driver. I am still
> > seeing some unusual behavior when bridging VLAN interfaces. It looks
> > like there is an off-by-one error in the mapping from rx queue to tx
> > queue (ie. packets are sent on <rx queue number>-1 instead of using the
> > same rx and tx queue number).
> >
> > Any idea what might cause this?
>
> Looking at the code, we are having difficulty finding the problem. I
> think we did find an accounting error in the vlan code, though.
>
> In net/8021q/vlan_dev.c:
>
> static netdev_tx_t vlan_dev_hard_start_xmit(struct sk_buff *skb,
> struct net_device *dev)
> {
> int i = skb_get_queue_mapping(skb);
> struct netdev_queue *txq = netdev_get_tx_queue(dev, i);
> ...
> if (likely(ret == NET_XMIT_SUCCESS)) {
> txq->tx_packets++;
> txq->tx_bytes += len;
> } else
> txq->tx_dropped++;
> ...
> }
>
> skb_get_queue_mapping returns skb->queue_mapping, which is rx_queue + 1
> or 0 for unset.
>
> Does dev->_tx[0] have some special meaning, or is this wrong?
>
All multi queue drivers do same thing than vlan_dev_hard_start_xmit()
TX path is supposed to go through dev_pick_tx() & skb_tx_hash(), maybe
bridging has a shortcut and need a fix, like we also do in pktgen (sorry
I wont be able to check this before few days)
^ permalink raw reply
* Re: ixgbe RSS not working as expected with 8021q and bridging
From: David Miller @ 2010-02-12 19:52 UTC (permalink / raw)
To: eric.dumazet; +Cc: esk-netdev, netdev
In-Reply-To: <1266004097.2939.4.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 12 Feb 2010 20:48:17 +0100
> TX path is supposed to go through dev_pick_tx() & skb_tx_hash(), maybe
> bridging has a shortcut and need a fix, like we also do in pktgen (sorry
> I wont be able to check this before few days)
I just made a quick check and bridging seems lack any such shortcuts
and is a good citizen. :-)
It transmits packets using dev_queue_xmit().
^ permalink raw reply
* Re: ixgbe: [RFC] [PATCH] Fix return of invalid txq
From: David Miller @ 2010-02-12 19:55 UTC (permalink / raw)
To: peter.p.waskiewicz.jr; +Cc: krkumar2, netdev, jeffrey.t.kirsher
In-Reply-To: <F86E8680A7D9D74A99DC6345E35A6929501BA2CA@orsmsx503.amr.corp.intel.com>
From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Date: Sat, 16 Jan 2010 02:53:15 -0800
> Either way works though. I still think the table is the better way
> to go, because of the determinism for any system and NIC
> configuration/layout. The overhead of configuring the table is
> taken during open(), so it's not in the hotpath at all.
How many minus operations can your cpu perform in the same amount
of time it takes to access memory? :-)
^ permalink raw reply
* Re: ipv6: fib: fix crash when changing large fib while dumping it
From: David Miller @ 2010-02-12 20:07 UTC (permalink / raw)
To: kaber; +Cc: netdev, yoshfuji
In-Reply-To: <4B702B67.4000900@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Mon, 08 Feb 2010 16:19:03 +0100
> Please review carefully, I'm not too familiar with this code.
It looks OK to me, I've applied this to net-next-2.6. We can backport
or submit to -stable if needed after it cooks for a while in
net-next-2.6.
^ permalink raw reply
* Re: [PATCH 1/1] dccp: allow probing of CCID-array length
From: David Miller @ 2010-02-12 20:07 UTC (permalink / raw)
To: gerrit; +Cc: dccp, netdev
In-Reply-To: <20100208062028.GA5478@gerrit.erg.abdn.ac.uk>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Mon, 8 Feb 2010 07:20:28 +0100
> This fixes a problem in the DCCP getsockopt() API: currently there is no way
> for a user to a priori know the number of built-in CCIDs, other than trying
> DCCP_SOCKOPT_AVAILABLE_CCIDS in a loop, incrementing the option length until
> EINVAL is no longer returned.
>
> This patch truncates the array to the user-provided length. No copy is made
> when the length is <= 0.
>
> Due to the length restriction in do_dccp_getsockopt() to sizeof(int), the
> minimum array length remains 4, which is a reasonable default (only 3
> CCIDs, CCID-2..4, are currently defined).
>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Applied to net-next-2.6, thanks Gerrit.
^ permalink raw reply
* Re: [PATCH 9/9] net: move am79c961's probe function to .devinit.text
From: David Miller @ 2010-02-12 20:11 UTC (permalink / raw)
To: u.kleine-koenig; +Cc: gregkh, linux-kernel, 12o3l, rmk+kernel, netdev, akpm
In-Reply-To: <20100204200638.GA3035@pengutronix.de>
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Thu, 4 Feb 2010 21:06:38 +0100
> On Thu, Feb 04, 2010 at 12:05:01PM -0800, David Miller wrote:
>> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Date: Thu, 4 Feb 2010 20:56:57 +0100
>>
>> > @David Miller: this patch is in patchwork with State: Not Applicable.
>> > Does that mean that netdev isn't the right tree for this patch?
>>
>> I was under the impression that someone would pick up the
>> whole set as a unit.
> Ah, OK. I hope Greg does exactly that now.
I've tossed this into my net-next-2.6 tree anyways to make sure it
doesn't get lost.
Thanks.
^ permalink raw reply
* [PATCH] b44: Ratelimit timeout error message.
From: Jochen Friedrich @ 2010-02-12 20:11 UTC (permalink / raw)
To: Gary Zambrano; +Cc: netdev, Jochen Friedrich
Signed-off-by: Jochen Friedrich <jochen@scram.de>
---
drivers/net/b44.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/b44.c b/drivers/net/b44.c
index 4869adb..499212e 100644
--- a/drivers/net/b44.c
+++ b/drivers/net/b44.c
@@ -189,11 +189,13 @@ static int b44_wait_bit(struct b44 *bp, unsigned long reg,
udelay(10);
}
if (i == timeout) {
- printk(KERN_ERR PFX "%s: BUG! Timeout waiting for bit %08x of register "
- "%lx to %s.\n",
- bp->dev->name,
- bit, reg,
- (clear ? "clear" : "set"));
+ if (net_ratelimit())
+ printk(KERN_ERR PFX "%s: BUG! Timeout waiting for bit "
+ "%08x of register "
+ "%lx to %s.\n",
+ bp->dev->name,
+ bit, reg,
+ (clear ? "clear" : "set"));
return -ENODEV;
}
return 0;
--
1.6.6
^ permalink raw reply related
* Re: [PATCH v2] skbuff: align sk_buff::cb to 64 bit
From: David Miller @ 2010-02-12 20:13 UTC (permalink / raw)
To: nbd; +Cc: ddaney, eric.dumazet, netdev, buytenh
In-Reply-To: <4B671F79.8090808@openwrt.org>
From: Felix Fietkau <nbd@openwrt.org>
Date: Mon, 01 Feb 2010 19:37:45 +0100
> On 2010-02-01 7:26 PM, David Daney wrote:
>> Then perhaps add __aligned(8) to the entire structure instead of just
>> this field.
> Makes sense, I'll send a patch for that.
Did that patch ever materialize? :-)
^ permalink raw reply
* Re: ixgbe: [RFC] [PATCH] Fix return of invalid txq
From: Peter P Waskiewicz Jr @ 2010-02-12 20:12 UTC (permalink / raw)
To: David Miller
Cc: krkumar2@in.ibm.com, netdev@vger.kernel.org, Kirsher, Jeffrey T
In-Reply-To: <20100212.115552.166740353.davem@davemloft.net>
On Fri, 2010-02-12 at 12:55 -0700, David Miller wrote:
> From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
> Date: Sat, 16 Jan 2010 02:53:15 -0800
>
> > Either way works though. I still think the table is the better way
> > to go, because of the determinism for any system and NIC
> > configuration/layout. The overhead of configuring the table is
> > taken during open(), so it's not in the hotpath at all.
>
> How many minus operations can your cpu perform in the same amount
> of time it takes to access memory? :-)
Touche. :)
^ permalink raw reply
* Re: [PATCH 1/1 net-next] virtio_net: remove send queue
From: David Miller @ 2010-02-12 20:28 UTC (permalink / raw)
To: mashirle; +Cc: netdev, kvm, rusty, mst, linux-kernel
In-Reply-To: <1265674482.4484.10.camel@localhost.localdomain>
From: Shirley Ma <mashirle@us.ibm.com>
Date: Mon, 08 Feb 2010 16:14:42 -0800
> Now we have a virtio detach API (in commit
> f9bfbebf34eab707b065116cdc9699d25ba4252a), we don't need to track xmit
> skbs in the virio_net driver, which improves transmission performance.
>
> Signed-off-by: Shirley Ma <xma@us.ibm.com>
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Applied to net-next-2.6, thanks everyone.
^ permalink raw reply
* Re: [PATCH net-next-2.6] be2net: bug fix in be_read_eeprom
From: David Miller @ 2010-02-12 20:28 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209035115.GA6577@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 09:21:26 +0530
> The offset to read the eeprom data was missing and
> wrong eeprom data was being dumped. This patch fixes this.
>
>>From Suresh R <sureshr@serverengines.com>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/7] be2net: remove unused pci device id
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209112824.GA10418@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 16:58:35 +0530
> We are not going to use this device id.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 2/7] be2net: bug fix for flashing the BladeEngine3 ASIC
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209113024.GA10453@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 17:00:35 +0530
> Now flashing both BE2 and BE3 devices is supported.
>
> From: Naresh G <nareshg@serverengines.com>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 3/7] be2net: bug fix in be_change_mtu
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209113233.GA10485@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 17:02:43 +0530
> Current code allows the new mtu to cross the supported value.
> This patch fixes the boundary checks.
>
> From: Suresh R <sureshr@serverengines.com>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 4/7] be2net: minor code optimizations
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209113411.GA10498@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 17:04:21 +0530
> Couple of code optimizations in the Rx path (to avoid a memset).
>
> From: Sathya P <sathyap@serverengines.com>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 5/7] be2net: fix to limit max vlans supported in certain skews
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209113447.GA10511@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 17:04:57 +0530
> In certain skews the ASIC can support only 16 vlans per interface.
> Once the limit is crossed, the ASIC is programmed in vlan promiscuous mode.
> Switch off the vlan promiscuous mode once the number of vlans
> falls back to the max vlans supported.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 6/7] be2net: change the driver description
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209113755.GA10577@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 17:08:06 +0530
> Since the driver is supporting multiple generations of the ASIC
> remove ASIC generation information from the driver description.
> This information is displayed by modinfo.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 7/7] be2net: remove ASIC generation number from Kconfig
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209113855.GA10593@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 17:09:05 +0530
> Since the driver is supporting multiple generations of the ASIC
> don't mention any ASIC generation number.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 1/2] IPv6: keep permanent addresses on admin down
From: David Miller @ 2010-02-12 20:30 UTC (permalink / raw)
To: shemminger; +Cc: yoshfuji, netdev
In-Reply-To: <20100208214805.1f8f2c6d@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 8 Feb 2010 21:48:05 -0800
> Permanent IPV6 addresses should not be removed when the link is
> set to admin down, only when device is removed.
>
> When link is lost permanent addresses should be marked as tentative
> so that when link comes back they are subject to duplicate address
> detection (if DAD was enabled for that address).
>
> Other routing systems keep manually configured IPv6 addresses
> when link is set down.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 2/2] IPv6: remove trivial nested _bh suffix
From: David Miller @ 2010-02-12 20:30 UTC (permalink / raw)
To: shemminger; +Cc: yoshfuji, netdev
In-Reply-To: <20100208214852.017349dd@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 8 Feb 2010 21:48:52 -0800
> Don't need to disable bottom half it is already down in the
> previous lock. Move some blank lines to group locking in same
> context.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH] xfrm: validate attributes
From: David Miller @ 2010-02-12 20:30 UTC (permalink / raw)
To: hadi; +Cc: herbert, netdev
In-Reply-To: <1265723978.3688.82.camel@bigi>
From: jamal <hadi@cyberus.ca>
Date: Tue, 09 Feb 2010 08:59:38 -0500
> xfrm: validate attributes
>
> Some XFRM attributes were not going through basic validation.
>
> Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH] xfrm: use proper kernel types
From: David Miller @ 2010-02-12 20:30 UTC (permalink / raw)
To: hadi; +Cc: herbert, netdev
In-Reply-To: <1265757677.3688.87.camel@bigi>
From: jamal <hadi@cyberus.ca>
Date: Tue, 09 Feb 2010 18:21:17 -0500
> xfrm: use proper kernel types
>
> kernel side should use uxx instead of __uxx types
>
> Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Applied to net-next-2.6
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox