* Re: ixgbe RSS not working as expected with 8021q and bridging
From: David Miller @ 2010-02-12 19:52 UTC (permalink / raw)
To: eric.dumazet; +Cc: esk-netdev, netdev
In-Reply-To: <1266004097.2939.4.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 12 Feb 2010 20:48:17 +0100
> TX path is supposed to go through dev_pick_tx() & skb_tx_hash(), maybe
> bridging has a shortcut and need a fix, like we also do in pktgen (sorry
> I wont be able to check this before few days)
I just made a quick check and bridging seems lack any such shortcuts
and is a good citizen. :-)
It transmits packets using dev_queue_xmit().
^ permalink raw reply
* Re: ixgbe: [RFC] [PATCH] Fix return of invalid txq
From: David Miller @ 2010-02-12 19:55 UTC (permalink / raw)
To: peter.p.waskiewicz.jr; +Cc: krkumar2, netdev, jeffrey.t.kirsher
In-Reply-To: <F86E8680A7D9D74A99DC6345E35A6929501BA2CA@orsmsx503.amr.corp.intel.com>
From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
Date: Sat, 16 Jan 2010 02:53:15 -0800
> Either way works though. I still think the table is the better way
> to go, because of the determinism for any system and NIC
> configuration/layout. The overhead of configuring the table is
> taken during open(), so it's not in the hotpath at all.
How many minus operations can your cpu perform in the same amount
of time it takes to access memory? :-)
^ permalink raw reply
* Re: ipv6: fib: fix crash when changing large fib while dumping it
From: David Miller @ 2010-02-12 20:07 UTC (permalink / raw)
To: kaber; +Cc: netdev, yoshfuji
In-Reply-To: <4B702B67.4000900@trash.net>
From: Patrick McHardy <kaber@trash.net>
Date: Mon, 08 Feb 2010 16:19:03 +0100
> Please review carefully, I'm not too familiar with this code.
It looks OK to me, I've applied this to net-next-2.6. We can backport
or submit to -stable if needed after it cooks for a while in
net-next-2.6.
^ permalink raw reply
* Re: [PATCH 1/1] dccp: allow probing of CCID-array length
From: David Miller @ 2010-02-12 20:07 UTC (permalink / raw)
To: gerrit; +Cc: dccp, netdev
In-Reply-To: <20100208062028.GA5478@gerrit.erg.abdn.ac.uk>
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Date: Mon, 8 Feb 2010 07:20:28 +0100
> This fixes a problem in the DCCP getsockopt() API: currently there is no way
> for a user to a priori know the number of built-in CCIDs, other than trying
> DCCP_SOCKOPT_AVAILABLE_CCIDS in a loop, incrementing the option length until
> EINVAL is no longer returned.
>
> This patch truncates the array to the user-provided length. No copy is made
> when the length is <= 0.
>
> Due to the length restriction in do_dccp_getsockopt() to sizeof(int), the
> minimum array length remains 4, which is a reasonable default (only 3
> CCIDs, CCID-2..4, are currently defined).
>
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Applied to net-next-2.6, thanks Gerrit.
^ permalink raw reply
* Re: [PATCH 9/9] net: move am79c961's probe function to .devinit.text
From: David Miller @ 2010-02-12 20:11 UTC (permalink / raw)
To: u.kleine-koenig; +Cc: gregkh, linux-kernel, 12o3l, rmk+kernel, netdev, akpm
In-Reply-To: <20100204200638.GA3035@pengutronix.de>
From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Date: Thu, 4 Feb 2010 21:06:38 +0100
> On Thu, Feb 04, 2010 at 12:05:01PM -0800, David Miller wrote:
>> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Date: Thu, 4 Feb 2010 20:56:57 +0100
>>
>> > @David Miller: this patch is in patchwork with State: Not Applicable.
>> > Does that mean that netdev isn't the right tree for this patch?
>>
>> I was under the impression that someone would pick up the
>> whole set as a unit.
> Ah, OK. I hope Greg does exactly that now.
I've tossed this into my net-next-2.6 tree anyways to make sure it
doesn't get lost.
Thanks.
^ permalink raw reply
* [PATCH] b44: Ratelimit timeout error message.
From: Jochen Friedrich @ 2010-02-12 20:11 UTC (permalink / raw)
To: Gary Zambrano; +Cc: netdev, Jochen Friedrich
Signed-off-by: Jochen Friedrich <jochen@scram.de>
---
drivers/net/b44.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/b44.c b/drivers/net/b44.c
index 4869adb..499212e 100644
--- a/drivers/net/b44.c
+++ b/drivers/net/b44.c
@@ -189,11 +189,13 @@ static int b44_wait_bit(struct b44 *bp, unsigned long reg,
udelay(10);
}
if (i == timeout) {
- printk(KERN_ERR PFX "%s: BUG! Timeout waiting for bit %08x of register "
- "%lx to %s.\n",
- bp->dev->name,
- bit, reg,
- (clear ? "clear" : "set"));
+ if (net_ratelimit())
+ printk(KERN_ERR PFX "%s: BUG! Timeout waiting for bit "
+ "%08x of register "
+ "%lx to %s.\n",
+ bp->dev->name,
+ bit, reg,
+ (clear ? "clear" : "set"));
return -ENODEV;
}
return 0;
--
1.6.6
^ permalink raw reply related
* Re: [PATCH v2] skbuff: align sk_buff::cb to 64 bit
From: David Miller @ 2010-02-12 20:13 UTC (permalink / raw)
To: nbd; +Cc: ddaney, eric.dumazet, netdev, buytenh
In-Reply-To: <4B671F79.8090808@openwrt.org>
From: Felix Fietkau <nbd@openwrt.org>
Date: Mon, 01 Feb 2010 19:37:45 +0100
> On 2010-02-01 7:26 PM, David Daney wrote:
>> Then perhaps add __aligned(8) to the entire structure instead of just
>> this field.
> Makes sense, I'll send a patch for that.
Did that patch ever materialize? :-)
^ permalink raw reply
* Re: ixgbe: [RFC] [PATCH] Fix return of invalid txq
From: Peter P Waskiewicz Jr @ 2010-02-12 20:12 UTC (permalink / raw)
To: David Miller
Cc: krkumar2@in.ibm.com, netdev@vger.kernel.org, Kirsher, Jeffrey T
In-Reply-To: <20100212.115552.166740353.davem@davemloft.net>
On Fri, 2010-02-12 at 12:55 -0700, David Miller wrote:
> From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
> Date: Sat, 16 Jan 2010 02:53:15 -0800
>
> > Either way works though. I still think the table is the better way
> > to go, because of the determinism for any system and NIC
> > configuration/layout. The overhead of configuring the table is
> > taken during open(), so it's not in the hotpath at all.
>
> How many minus operations can your cpu perform in the same amount
> of time it takes to access memory? :-)
Touche. :)
^ permalink raw reply
* Re: [PATCH 1/1 net-next] virtio_net: remove send queue
From: David Miller @ 2010-02-12 20:28 UTC (permalink / raw)
To: mashirle; +Cc: netdev, kvm, rusty, mst, linux-kernel
In-Reply-To: <1265674482.4484.10.camel@localhost.localdomain>
From: Shirley Ma <mashirle@us.ibm.com>
Date: Mon, 08 Feb 2010 16:14:42 -0800
> Now we have a virtio detach API (in commit
> f9bfbebf34eab707b065116cdc9699d25ba4252a), we don't need to track xmit
> skbs in the virio_net driver, which improves transmission performance.
>
> Signed-off-by: Shirley Ma <xma@us.ibm.com>
> Acked-by: Rusty Russell <rusty@rustcorp.com.au>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
Applied to net-next-2.6, thanks everyone.
^ permalink raw reply
* Re: [PATCH net-next-2.6] be2net: bug fix in be_read_eeprom
From: David Miller @ 2010-02-12 20:28 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209035115.GA6577@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 09:21:26 +0530
> The offset to read the eeprom data was missing and
> wrong eeprom data was being dumped. This patch fixes this.
>
>>From Suresh R <sureshr@serverengines.com>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied.
^ permalink raw reply
* Re: [PATCH 1/7] be2net: remove unused pci device id
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209112824.GA10418@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 16:58:35 +0530
> We are not going to use this device id.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 2/7] be2net: bug fix for flashing the BladeEngine3 ASIC
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209113024.GA10453@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 17:00:35 +0530
> Now flashing both BE2 and BE3 devices is supported.
>
> From: Naresh G <nareshg@serverengines.com>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 3/7] be2net: bug fix in be_change_mtu
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209113233.GA10485@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 17:02:43 +0530
> Current code allows the new mtu to cross the supported value.
> This patch fixes the boundary checks.
>
> From: Suresh R <sureshr@serverengines.com>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 4/7] be2net: minor code optimizations
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209113411.GA10498@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 17:04:21 +0530
> Couple of code optimizations in the Rx path (to avoid a memset).
>
> From: Sathya P <sathyap@serverengines.com>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 5/7] be2net: fix to limit max vlans supported in certain skews
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209113447.GA10511@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 17:04:57 +0530
> In certain skews the ASIC can support only 16 vlans per interface.
> Once the limit is crossed, the ASIC is programmed in vlan promiscuous mode.
> Switch off the vlan promiscuous mode once the number of vlans
> falls back to the max vlans supported.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 6/7] be2net: change the driver description
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209113755.GA10577@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 17:08:06 +0530
> Since the driver is supporting multiple generations of the ASIC
> remove ASIC generation information from the driver description.
> This information is displayed by modinfo.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 7/7] be2net: remove ASIC generation number from Kconfig
From: David Miller @ 2010-02-12 20:29 UTC (permalink / raw)
To: ajitk, ajitkhaparde; +Cc: netdev
In-Reply-To: <20100209113855.GA10593@serverengines.com>
From: Ajit Khaparde <ajitkhaparde@gmail.com>
Date: Tue, 9 Feb 2010 17:09:05 +0530
> Since the driver is supporting multiple generations of the ASIC
> don't mention any ASIC generation number.
>
> Signed-off-by: Ajit Khaparde <ajitk@serverengines.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 1/2] IPv6: keep permanent addresses on admin down
From: David Miller @ 2010-02-12 20:30 UTC (permalink / raw)
To: shemminger; +Cc: yoshfuji, netdev
In-Reply-To: <20100208214805.1f8f2c6d@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 8 Feb 2010 21:48:05 -0800
> Permanent IPV6 addresses should not be removed when the link is
> set to admin down, only when device is removed.
>
> When link is lost permanent addresses should be marked as tentative
> so that when link comes back they are subject to duplicate address
> detection (if DAD was enabled for that address).
>
> Other routing systems keep manually configured IPv6 addresses
> when link is set down.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH 2/2] IPv6: remove trivial nested _bh suffix
From: David Miller @ 2010-02-12 20:30 UTC (permalink / raw)
To: shemminger; +Cc: yoshfuji, netdev
In-Reply-To: <20100208214852.017349dd@nehalam>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 8 Feb 2010 21:48:52 -0800
> Don't need to disable bottom half it is already down in the
> previous lock. Move some blank lines to group locking in same
> context.
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH] xfrm: validate attributes
From: David Miller @ 2010-02-12 20:30 UTC (permalink / raw)
To: hadi; +Cc: herbert, netdev
In-Reply-To: <1265723978.3688.82.camel@bigi>
From: jamal <hadi@cyberus.ca>
Date: Tue, 09 Feb 2010 08:59:38 -0500
> xfrm: validate attributes
>
> Some XFRM attributes were not going through basic validation.
>
> Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Applied to net-next-2.6
^ permalink raw reply
* Re: [PATCH] xfrm: use proper kernel types
From: David Miller @ 2010-02-12 20:30 UTC (permalink / raw)
To: hadi; +Cc: herbert, netdev
In-Reply-To: <1265757677.3688.87.camel@bigi>
From: jamal <hadi@cyberus.ca>
Date: Tue, 09 Feb 2010 18:21:17 -0500
> xfrm: use proper kernel types
>
> kernel side should use uxx instead of __uxx types
>
> Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
Applied to net-next-2.6
^ permalink raw reply
* Re: [RFC PATCH net-next 0/7] Add netdev_printk and netif_printk macros
From: David Miller @ 2010-02-12 20:31 UTC (permalink / raw)
To: joe; +Cc: netdev, bhutchings
In-Reply-To: <cover.1265751023.git.joe@perches.com>
From: Joe Perches <joe@perches.com>
Date: Tue, 9 Feb 2010 13:49:46 -0800
> Some logging messages duplicate the driver name with the device name like:
>
> ATL1E 0000:03:00.0: ATL1E: eth0 NIC Link is Up<100 Mbps Full Duplex>
>
> Some drivers/net/... have created netif_ macros like:
>
> drivers/net/sis190.c:#define net_drv(p, arg...) if (netif_msg_drv(p)) \
> drivers/net/sis190.c- printk(arg)
> drivers/net/sis190.c:#define net_probe(p, arg...) if (netif_msg_probe(p)) \
> drivers/net/sis190.c- printk(arg)
> drivers/net/sis190.c:#define net_link(p, arg...) if (netif_msg_link(p)) \
> drivers/net/sis190.c- printk(arg)
> drivers/net/sis190.c:#define net_intr(p, arg...) if (netif_msg_intr(p)) \
> drivers/net/sis190.c- printk(arg)
> drivers/net/sis190.c:#define net_tx_err(p, arg...) if (netif_msg_tx_err(p)) \
> drivers/net/sis190.c- printk(arg)
>
> This RFC patch creates a set of these macros to standardize
> the coding and logging style of struct net_device and netif_msg macros
>
> I think they're useful, might be mindless churn to others.
>
> The atl1e change reduces log duplicate names.
>
> The qlge change is an example of what be mindless churn for standardization
> sake, the r8169, jme, and skge are more reasonable.
>
> Comments?
I really like these changes, feel free to make a pass of niu.[ch] making it
use these things :-)
All applied to net-next-2.6, thanks!
^ permalink raw reply
* tunctl issues with FC 12 and 2.6.33-rc5
From: Rose, Gregory V @ 2010-02-12 20:32 UTC (permalink / raw)
To: netdev@vger.kernel.org
I have built and installed the 2.6.33-rc5 kernel on a machine in which the original distro was Fedora Core 12. I have a script set up to create a tap device using tunctl but when I boot to the 2.6.33-rc5 kernel I get TUNSETIFF: Permission Denied. If I boot to the 2.6.31 based kernel that came with FC 12 the tunctl command works fine and create the tap device. The problem I need a tap device added to my bridge so I can pass a network interface into one of my KVM virtual machines.
Has anyone seen this problem or might understand why it is occurring? I checked the netdev archives and found nothing about it there. Several hours of googling about the internet hasn't provided any insight either.
Thanks,
- Greg Rose
LAD
Intel Corp.
^ permalink raw reply
* Re: [PATCH net-2.6] sfc: Fix SFE4002 initialisation
From: David Miller @ 2010-02-12 20:32 UTC (permalink / raw)
To: bhutchings; +Cc: netdev, linux-net-drivers
In-Reply-To: <1265730777.2126.110.camel@achroite.uk.solarflarecom.com>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Tue, 09 Feb 2010 15:52:57 +0000
> From: Steve Hodgson <shodgson@solarflare.com>
>
> Commit 357d46a17e54c9a87e0e6ef3930ff4ab2d232b81 "sfc: QT202x: Remove
> unreliable MMD check at initialisation" broke initialisation of the
> SFE4002. efx_mdio_reset_mmd() returns a positive value rather than 0
> on success. The above commit causes this value to be propagated up
> by qt202x_reset_phy(), which is treated as a failure by its callers.
> Change qt202x_reset_phy() to return 0 if successful.
>
> The PCI layer treats >0 as "fail, but please call remove() anyway",
> which means that unloading the driver would cause a crash. Add a
> WARN_ON() on the failure path of efx_pci_probe() to provide early
> warning if there are any other cases where we do this.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Applied to net-2.6, thanks.
^ permalink raw reply
* Re: [PATCH] usbnet: convert dev(dbg|err|warn|info) macros to usbnet_(dbg|err|warn|info)
From: David Miller @ 2010-02-12 20:38 UTC (permalink / raw)
To: david-b
Cc: joe, gregkh, linux-usb, netdev, linux-kernel, oliver, jacmet,
steve.glendinning
In-Reply-To: <201002092256.30175.david-b@pacbell.net>
From: David Brownell <david-b@pacbell.net>
Date: Tue, 9 Feb 2010 22:56:29 -0800
> On Tuesday 09 February 2010, Joe Perches wrote:
>
>> netdev_printk macros instead.
>>
>> http://patchwork.ozlabs.org/patch/44955/
>
> That'd make sense. Had they existed way back when ...
> they could have been used instead of custom stuff.
Joe, this patch doesn't apply cleanly to net-next-2.6 so could
you respin whatever variant of this you want me to apply?
Thanks!
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox