* Re: [Patch] netpoll: allow spaces in its parameter
From: Cong Wang @ 2010-03-17 6:38 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, netdev
In-Reply-To: <20100316.231434.177653499.davem@davemloft.net>
David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Wed, 17 Mar 2010 14:07:57 +0800
>
>> No, but silently accepting it as 0 is not correct, why don't
>> reject it if it is not allowed?
>
> You have to be careful even with that. For example, if two
> netconsoles are specified, seeing the space shouldn't
> kill the first netconsole specification we parsed.
>
> A warning perhaps, but outright rejection of all specifications is
> really bad behavior.
OK, I will put a warning there instead.
Thanks, David!
^ permalink raw reply
* Re: [PATCH] net: remove rcu locking from fib_rules_event()
From: Eric Dumazet @ 2010-03-17 6:32 UTC (permalink / raw)
To: David Miller; +Cc: netdev, paulmck
In-Reply-To: <20100316.212846.160081359.davem@davemloft.net>
Le mardi 16 mars 2010 à 21:28 -0700, David Miller a écrit :
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Wed, 10 Mar 2010 07:03:38 +0100
>
> > We hold RTNL at this point and dont use RCU variants of list traversals,
> > we dont need rcu_read_lock()/rcu_read_unlock()
> >
> > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
>
> Applied.
Thanks David.
I believe the synchronize_rcu() we have in this file is useless too,
I'll submit a patch.
^ permalink raw reply
* Re: [Patch] netpoll: allow spaces in its parameter
From: David Miller @ 2010-03-17 6:14 UTC (permalink / raw)
To: amwang; +Cc: linux-kernel, netdev
In-Reply-To: <4BA071BD.5040900@redhat.com>
From: Cong Wang <amwang@redhat.com>
Date: Wed, 17 Mar 2010 14:07:57 +0800
> No, but silently accepting it as 0 is not correct, why don't
> reject it if it is not allowed?
You have to be careful even with that. For example, if two
netconsoles are specified, seeing the space shouldn't
kill the first netconsole specification we parsed.
A warning perhaps, but outright rejection of all specifications is
really bad behavior.
^ permalink raw reply
* Re: [Patch] netpoll: allow spaces in its parameter
From: Cong Wang @ 2010-03-17 6:07 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, netdev
In-Reply-To: <20100316.225950.222623826.davem@davemloft.net>
David Miller wrote:
> From: Cong Wang <amwang@redhat.com>
> Date: Wed, 17 Mar 2010 14:01:06 +0800
>
>> The problem is that the dst port is 0 when I even use:
>>
>> "netconsole=@192.168.0.1/eth0, 66666@192.168.0.2/"
>>
>> This is awful too? I don't think so...
>
> It's very simple, don't use spaces. Is it so difficult
> to follow this rule?
>
No, but silently accepting it as 0 is not correct, why don't
reject it if it is not allowed?
^ permalink raw reply
* Re: [PATCH] drivers/net/wimax/i2400m/fw.c fix possible double free
From: Inaky Perez-Gonzalez @ 2010-03-17 6:05 UTC (permalink / raw)
To: David Miller
Cc: cindy.h.kao, wimax, netdev, kernel-janitors, linux-kernel,
linux-wimax, darrenrjenkins
In-Reply-To: <20100316.141445.27416807.davem@davemloft.net>
On Tue, 2010-03-16 at 14:14 -0700, David Miller wrote:
> From: Darren Jenkins <darrenrjenkins@gmail.com>
> Date: Tue, 16 Mar 2010 22:46:28 +1100
>
> > i2400m_fw_check() can free i2400m->fw_hdrs if krealloc() fails causing a double free
> > Add a check so we don't free the memory a second time.
> >
> > coverity CID: 13455
> >
> > Signed-off-by: Darren Jenkins <darrenrjenkins@gmail.com>
>
> Please don't fix it like this, the check is obscure and it's
> allowing other bugs to happen.
>
> If krealloc() fails, any refrence to i2400m->fw_hdrs is
> referencing freed memory.
>
> Therefore the krealloc() failure handling in this driver should NULL
> out i2400m->fw_hdrs and that will fix the double kfree problem as well
> as trap any stray references.
I agree with David, the fix is quite obscure. The error path in
i2400m_fw_check()'s call to i2400m_kzrealloc_2x() should be rather
cleaning up in a better way.
^ permalink raw reply
* RE: [PATCH net-next-2.6 v6 08/12] net-caif: add CAIF socket implementation
From: Marcel Holtmann @ 2010-03-17 6:03 UTC (permalink / raw)
To: Sjur Brændeland
Cc: netdev, davem, Daniel Martensson, kaber, stefano.babic,
randy.dunlap
In-Reply-To: <61D8D34BB13CFE408D154529C120E079033D51A2@eseldmw101.eemea.ericsson.se>
Hi Sjur,
> >> + * The sock->type specifies the socket type to use. The CAIF
> >> socket is + * a packet stream in the sence that it is packet based.
> >> + * CAIF trusts the reliability of the link, no resending is
> >> implemented. + */ + if (sock->type != SOCK_SEQPACKET)
> >> + return -ESOCKTNOSUPPORT;
> >
> > we came to an interesting detail here when testing with a STE modem.
> > Why is this SEQPACKET and not a STREAM.
>
> The reason is that CAIF provides different services not just AT,
> and some of them are really packet oriented such as Utility links and
> Video. It would not be right to provide a stream based solution in this case.
>
> > Especially with the AT
> > command channels it is kinda weird that you have an MTU. The AT
> > specification doesn't really have any defined behavior when using a
> > sequential packet transport. It is more a stream based socket.
>
> Yes I see your point. In order to limit the effort and simplify
> caif_socket we ended up implementing only SEQPACKET.
I think we need to split this. Use SEQPACKET for packet based services
and have STREAM for AT command channel.
So while this might cause internally some more code. It would take away
the complexity from userspace to turn it into a stream. And that is what
the userspace is expecting.
Regards
Marcel
^ permalink raw reply
* Re: [Patch] netpoll: allow spaces in its parameter
From: Cong Wang @ 2010-03-17 6:01 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, netdev
In-Reply-To: <20100316.225431.200776775.davem@davemloft.net>
David Miller wrote:
> From: Amerigo Wang <amwang@redhat.com>
> Date: Wed, 17 Mar 2010 01:53:26 -0400
>
>> It would be nice if we allow spaces in netconsole parameters,
>> otherwise we get weird results if there are spaces in it.
>>
>> After this patch, we will allow things like:
>> "netconsole= @192.168.0.1/eth0 , 66666@192.168.0.2/".
>>
>> Signed-off-by: WANG Cong <amwang@redhat.com>
>> Cc: David Miller <davem@davemloft.net>
>
> That kernel command line looks absolutely awful, not
> better.
>
> Sorry I'm not applying this.
The problem is that the dst port is 0 when I even use:
"netconsole=@192.168.0.1/eth0, 66666@192.168.0.2/"
This is awful too? I don't think so...
^ permalink raw reply
* Re: [Patch] netpoll: allow spaces in its parameter
From: David Miller @ 2010-03-17 5:59 UTC (permalink / raw)
To: amwang; +Cc: linux-kernel, netdev
In-Reply-To: <4BA07022.1040702@redhat.com>
From: Cong Wang <amwang@redhat.com>
Date: Wed, 17 Mar 2010 14:01:06 +0800
> The problem is that the dst port is 0 when I even use:
>
> "netconsole=@192.168.0.1/eth0, 66666@192.168.0.2/"
>
> This is awful too? I don't think so...
It's very simple, don't use spaces. Is it so difficult
to follow this rule?
"ipconfig" does it as do a host of other kernel command
line options.
There is no real reason to make netconsle= special in
this regard, really.
^ permalink raw reply
* Re: [Patch] netpoll: allow spaces in its parameter
From: David Miller @ 2010-03-17 5:54 UTC (permalink / raw)
To: amwang; +Cc: linux-kernel, netdev
In-Reply-To: <20100317055707.5013.72217.sendpatchset@localhost.localdomain>
From: Amerigo Wang <amwang@redhat.com>
Date: Wed, 17 Mar 2010 01:53:26 -0400
>
> It would be nice if we allow spaces in netconsole parameters,
> otherwise we get weird results if there are spaces in it.
>
> After this patch, we will allow things like:
> "netconsole= @192.168.0.1/eth0 , 66666@192.168.0.2/".
>
> Signed-off-by: WANG Cong <amwang@redhat.com>
> Cc: David Miller <davem@davemloft.net>
That kernel command line looks absolutely awful, not
better.
Sorry I'm not applying this.
^ permalink raw reply
* [Patch] netpoll: allow spaces in its parameter
From: Amerigo Wang @ 2010-03-17 5:53 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, Amerigo Wang, David Miller
It would be nice if we allow spaces in netconsole parameters,
otherwise we get weird results if there are spaces in it.
After this patch, we will allow things like:
"netconsole= @192.168.0.1/eth0 , 66666@192.168.0.2/".
Signed-off-by: WANG Cong <amwang@redhat.com>
Cc: David Miller <davem@davemloft.net>
---
diff --git a/net/core/netpoll.c b/net/core/netpoll.c
index 7aa6972..bf3b2f0 100644
--- a/net/core/netpoll.c
+++ b/net/core/netpoll.c
@@ -629,6 +629,7 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
char *cur=opt, *delim;
if (*cur != '@') {
+ cur = skip_spaces(cur);
if ((delim = strchr(cur, '@')) == NULL)
goto parse_failed;
*delim = 0;
@@ -651,12 +652,14 @@ int netpoll_parse_options(struct netpoll *np, char *opt)
if ((delim = strchr(cur, ',')) == NULL)
goto parse_failed;
*delim = 0;
+ strim(cur);
strlcpy(np->dev_name, cur, sizeof(np->dev_name));
cur = delim;
}
cur++;
if (*cur != '@') {
+ cur = skip_spaces(cur);
/* dst port */
if ((delim = strchr(cur, '@')) == NULL)
goto parse_failed;
^ permalink raw reply related
* Re: [Uclinux-dist-devel] [PATCH] can: bfin_can: switch to common Blackfin can header
From: David Miller @ 2010-03-17 5:51 UTC (permalink / raw)
To: vapier.adi-Re5JQEeQqe8AvxtiuMwx3w
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
netdev-u79uwXL29TY76Z2rM5mHXA,
urs.thuermann-l29pVbxQd1IUtdQbppsyvg,
oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg,
uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b
In-Reply-To: <8bd0f97a1003162225i439d9900mfdc03eca5de0ff6e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
From: Mike Frysinger <vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Wed, 17 Mar 2010 01:25:39 -0400
> if the next tree is merged into linux-next, then the header is already there
One of the highest priority trees in -next is net-next-2.6,
because so much other stuff ends up depending upon it.
Therefore I keep it building independently, so no matter what Stephen
Rothwell does the build isn't likely to break.
Just get your stuff merged properly to Linus then resubmit
your patch.
Else, resubmit with the header addition included.
Your choice :-)
^ permalink raw reply
* Re: [Uclinux-dist-devel] [PATCH] can: bfin_can: switch to common Blackfin can header
From: Mike Frysinger @ 2010-03-17 5:25 UTC (permalink / raw)
To: David Miller
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
netdev-u79uwXL29TY76Z2rM5mHXA,
urs.thuermann-l29pVbxQd1IUtdQbppsyvg,
oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg,
uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b
In-Reply-To: <20100316.220232.170244945.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On Wed, Mar 17, 2010 at 01:02, David Miller wrote:
> From: Mike Frysinger <vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> On Wed, Mar 17, 2010 at 00:28, David Miller wrote:
>>> From: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
>>>> The MMR bits are being moved to this header, so include it.
>>>
>>> I can't actually apply this since this asm/bfin_can.h header
>>> doesn't even exist in the tree yet so this change will
>>> break the build.
>>
>> Linus was supposed to pull my tree, but if that isnt going to happen
>> for 2.6.34, then just apply the patch for 2.6.35
>
> That's what I was going to do, apply it to net-next-2.6
> but I can't even do that until the asm/bfin_can.h change
> appears in Linus's tree.
if the next tree is merged into linux-next, then the header is already there
-mike
^ permalink raw reply
* Re: [Uclinux-dist-devel] [PATCH] can: bfin_can: switch to common Blackfin can header
From: David Miller @ 2010-03-17 5:02 UTC (permalink / raw)
To: vapier.adi-Re5JQEeQqe8AvxtiuMwx3w
Cc: vapier-aBrp7R+bbdUdnm+yROfE0A,
urs.thuermann-l29pVbxQd1IUtdQbppsyvg,
netdev-u79uwXL29TY76Z2rM5mHXA,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg,
uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b
In-Reply-To: <8bd0f97a1003162145i77f65158ne255b28239e1b595-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
From: Mike Frysinger <vapier.adi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Wed, 17 Mar 2010 00:45:06 -0400
> On Wed, Mar 17, 2010 at 00:28, David Miller wrote:
>> From: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
>> Date: Tue, 9 Mar 2010 11:03:09 -0500
>>
>>> The MMR bits are being moved to this header, so include it.
>>>
>>> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
>>
>> I can't actually apply this since this asm/bfin_can.h header
>> doesn't even exist in the tree yet so this change will
>> break the build.
>
> Linus was supposed to pull my tree, but if that isnt going to happen
> for 2.6.34, then just apply the patch for 2.6.35
That's what I was going to do, apply it to net-next-2.6
but I can't even do that until the asm/bfin_can.h change
appears in Linus's tree.
^ permalink raw reply
* Re: [Uclinux-dist-devel] [PATCH] can: bfin_can: switch to common Blackfin can header
From: Mike Frysinger @ 2010-03-17 4:45 UTC (permalink / raw)
To: David Miller
Cc: vapier-aBrp7R+bbdUdnm+yROfE0A,
urs.thuermann-l29pVbxQd1IUtdQbppsyvg,
netdev-u79uwXL29TY76Z2rM5mHXA,
socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg,
uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b
In-Reply-To: <20100316.212830.50212878.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On Wed, Mar 17, 2010 at 00:28, David Miller wrote:
> From: Mike Frysinger <vapier@gentoo.org>
> Date: Tue, 9 Mar 2010 11:03:09 -0500
>
>> The MMR bits are being moved to this header, so include it.
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> I can't actually apply this since this asm/bfin_can.h header
> doesn't even exist in the tree yet so this change will
> break the build.
Linus was supposed to pull my tree, but if that isnt going to happen
for 2.6.34, then just apply the patch for 2.6.35
-mike
_______________________________________________
Socketcan-core mailing list
Socketcan-core@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/socketcan-core
^ permalink raw reply
* Re: [PATCH net-next] drivers/net/e100.c: Use pr_<level> and netif_<level>
From: David Miller @ 2010-03-17 4:31 UTC (permalink / raw)
To: joe
Cc: e1000-devel, netdev, bruce.w.allan, jesse.brandeburg,
linux-kernel, john.ronciak, jeffrey.t.kirsher, gallatin, brice
In-Reply-To: <1267478181.12641.142.camel@Joe-Laptop.home>
From: Joe Perches <joe@perches.com>
Date: Mon, 01 Mar 2010 13:16:21 -0800
> Convert DPRINTK, commonly used for debugging, to netif_<level>
> Remove #define PFX
> Use #define pr_fmt
> Consistently use no periods for non-sentence logging messages
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
^ permalink raw reply
* Re: [net-next-2.6 PATCH] net: convert multiple drivers to use netdev_for_each_mc_addr, part7
From: David Miller @ 2010-03-17 4:31 UTC (permalink / raw)
To: jpirko; +Cc: netdev
In-Reply-To: <20100301150913.GE2799@psychotron.lab.eng.brq.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Mon, 1 Mar 2010 16:09:14 +0100
>
> In mlx4, using char * to store mc address in private structure instead.
>
> Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Applied.
^ permalink raw reply
* Re: [RFC PATCH net-next] drivers/net/ks*: Use netdev_<level>, netif_<level> and pr_<level>
From: David Miller @ 2010-03-17 4:31 UTC (permalink / raw)
To: joe; +Cc: Tristram.Ha, ben, david.choi, richard.rojfors.ext, netdev
In-Reply-To: <1267317831.30706.26.camel@Joe-Laptop.home>
From: Joe Perches <joe@perches.com>
Date: Sat, 27 Feb 2010 16:43:51 -0800
> I'm not sure this is correct.
>
> It changes logging macros from:
> dev_<level>(&ks->spidev->dev,
> to
> netdev_<level>(ks->netdev,
I'm just applying this, more than a week to get a review
is more than enough.
Thanks Joe.
^ permalink raw reply
* Re: [PATCH 2/2] e1000e / PCI / PM: Add basic runtime PM support (rev. 4)
From: David Miller @ 2010-03-17 4:29 UTC (permalink / raw)
To: rjw
Cc: netdev, jbarnes, linux-pci, linux-pm, jeffrey.t.kirsher,
jesse.brandeburg, e1000-devel, romieu, mjg59
In-Reply-To: <201003150135.17564.rjw@sisk.pl>
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Mon, 15 Mar 2010 01:35:17 +0100
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Use the PCI runtime power management framework to add basic PCI
> runtime PM support to the e1000e driver. Namely, make the driver
> suspend the device when the link is off and set it up for generating
> a wakeup event after the link has been detected again. [This
> feature is disabled until the user space enables it with the help of
> the /sys/devices/.../power/contol device attribute.]
>
> Based on a patch from Matthew Garrett.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Applied.
^ permalink raw reply
* Re: [PATCH 1/2] r8169 / PCI / PM: Add simplified runtime PM support (rev. 3)
From: David Miller @ 2010-03-17 4:29 UTC (permalink / raw)
To: rjw
Cc: netdev, jbarnes, linux-pci, linux-pm, jeffrey.t.kirsher,
jesse.brandeburg, e1000-devel, romieu, mjg59
In-Reply-To: <201003150133.51239.rjw@sisk.pl>
From: "Rafael J. Wysocki" <rjw@sisk.pl>
Date: Mon, 15 Mar 2010 01:33:51 +0100
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Use the PCI runtime power management framework to add basic PCI
> runtime PM support to the r8169 driver. Namely, make the driver
> suspend the device when the link is not present and set it up for
> generating a wakeup event after the link has been detected again.
> [This feature is disabled until the user space enables it with the
> help of the /sys/devices/.../power/contol device attribute.]
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Applied.
^ permalink raw reply
* Re: [PATCH 3/3] net: core: add IFLA_STATS64 support
From: David Miller @ 2010-03-17 4:29 UTC (permalink / raw)
To: jengelh; +Cc: netdev
In-Reply-To: <1268337450-6749-4-git-send-email-jengelh@medozas.de>
From: Jan Engelhardt <jengelh@medozas.de>
Date: Thu, 11 Mar 2010 20:57:29 +0100
> `ip -s link` shows interface counters truncated to 32 bit. This is
> because interface statistics are transported only in 32-bit quantity
> to userspace. This commit adds a new IFLA_STATS64 attribute that
> exports them in full 64 bit.
>
> References: http://lkml.indiana.edu/hypermail/linux/kernel/0307.3/0215.html
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Applied.
^ permalink raw reply
* Re: [PATCH 2/3] net: tcp: make veno selectable as default congestion module
From: David Miller @ 2010-03-17 4:29 UTC (permalink / raw)
To: jengelh; +Cc: netdev
In-Reply-To: <1268337450-6749-3-git-send-email-jengelh@medozas.de>
From: Jan Engelhardt <jengelh@medozas.de>
Date: Thu, 11 Mar 2010 20:57:28 +0100
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Applied.
^ permalink raw reply
* Re: [PATCH 1/3] net: tcp: make hybla selectable as default congestion module
From: David Miller @ 2010-03-17 4:29 UTC (permalink / raw)
To: jengelh; +Cc: netdev
In-Reply-To: <1268337450-6749-2-git-send-email-jengelh@medozas.de>
From: Jan Engelhardt <jengelh@medozas.de>
Date: Thu, 11 Mar 2010 20:57:27 +0100
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Applied.
^ permalink raw reply
* Re: [PATCH] NET: Support clause 45 MDIO commands at the MDIO bus level
From: David Miller @ 2010-03-17 4:28 UTC (permalink / raw)
To: jgunthorpe; +Cc: netdev, linux-kernel
In-Reply-To: <20100309191742.GB30462@obsidianresearch.com>
From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Date: Tue, 9 Mar 2010 12:17:42 -0700
> IEEE 802.3ae clause 45 specifies a somewhat modified MDIO protocol
> for use by 10GIGE phys. The main change is a 21 bit address split into
> a 5 bit device ID and a 16 bit register offset. The definition is designed
> so that normal and extended devices can run on the same MDIO bus.
>
> Extend mdio-bitbang to do the new protocol. At the MDIO bus level the
> protocol is requested by or'ing MII_ADDR_C45 into the register offset.
>
> Make phy_read/phy_write/etc pass a full 32 bit register offset.
>
> This does not attempt to make the phy layer support C45 style PHYs, just
> to provide the MDIO bus support.
>
> Tested against a Broadcom 10GE phy with ID 0x206034, and several
> Broadcom 10/100/1000 Phys in normal mode.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Applied.
^ permalink raw reply
* Re: [PATCH] can: bfin_can: switch to common Blackfin can header
From: David Miller @ 2010-03-17 4:28 UTC (permalink / raw)
To: vapier-aBrp7R+bbdUdnm+yROfE0A
Cc: socketcan-core-0fE9KPoRgkgATYTw5x5z8w,
netdev-u79uwXL29TY76Z2rM5mHXA,
uclinux-dist-devel-ZG0+EudsQA8dtHy/vicBwGD2FQJk+8+b,
oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg,
urs.thuermann-l29pVbxQd1IUtdQbppsyvg
In-Reply-To: <1268150589-27123-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
From: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
Date: Tue, 9 Mar 2010 11:03:09 -0500
> The MMR bits are being moved to this header, so include it.
>
> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
I can't actually apply this since this asm/bfin_can.h header
doesn't even exist in the tree yet so this change will
break the build.
This doesn't make any sense at all, it's impossible to
prevent breaking the build unless you add the asm/bfin_can.h
header at the same time you do these changes.
Why not submit those two things together as one commit
instead?
Thanks.
^ permalink raw reply
* Re: [PATCH] net: remove rcu locking from fib_rules_event()
From: David Miller @ 2010-03-17 4:28 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, paulmck
In-Reply-To: <1268201018.2872.139.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 10 Mar 2010 07:03:38 +0100
> We hold RTNL at this point and dont use RCU variants of list traversals,
> we dont need rcu_read_lock()/rcu_read_unlock()
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox